Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Telemetry] Send an event when users open the toolbar menu #18855

Closed
7 tasks
tdsmith opened this issue Apr 7, 2021 · 2 comments · Fixed by #18982
Closed
7 tasks

[Telemetry] Send an event when users open the toolbar menu #18855

tdsmith opened this issue Apr 7, 2021 · 2 comments · Fixed by #18982
Assignees
Labels
E3 Estimation Point: average, 2 - 3 days eng:qa:verified QA Verified Feature:Telemetry
Milestone

Comments

@tdsmith
Copy link
Contributor

tdsmith commented Apr 7, 2021

Description & Product Manager / Data Scientist User Story

In order to understand whether we can improve the effectiveness of each messaging surface we’re testing in the set-default experiment (#18796), we should understand how many people see our messages at all. This relates to the branch described in #18608.

As a data scientist, I want to know how often users view the toolbar menu. I would like to observe a Glean event each time users view the toolbar menu.

What questions will you answer with this data?

How many users will see, saw, or could have seen the message we will place on the toolbar menu?

Acceptance Criteria

  • ENG files a DS JIRA request outlining their methodology. Let's discuss in this ticket if you have any questions.
  • DS sign off on instrumentation methodology addressing product questions.
  • Event pings can be queried via re:dash
  • Event pings can be queried via amplitude
  • We are sending telemetry events for the actions listed in the requirements
  • We have documented the telemetry
  • We have asked a data steward to review the telemetry

┆Issue is synchronized with this Jira Task

@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 7, 2021
@amedyne amedyne removed the needs:triage Issue needs triage label Apr 8, 2021
@Amejia481 Amejia481 added the E3 Estimation Point: average, 2 - 3 days label Apr 13, 2021
@Amejia481 Amejia481 self-assigned this Apr 13, 2021
Amejia481 added a commit to Amejia481/fenix that referenced this issue Apr 13, 2021
@Amejia481 Amejia481 added this to the 89 milestone Apr 13, 2021
@Amejia481 Amejia481 linked a pull request Apr 13, 2021 that will close this issue
3 tasks
Amejia481 added a commit to Amejia481/fenix that referenced this issue Apr 14, 2021
Amejia481 added a commit to Amejia481/fenix that referenced this issue Apr 14, 2021
Amejia481 added a commit to Amejia481/fenix that referenced this issue Apr 14, 2021
Amejia481 added a commit to Amejia481/fenix that referenced this issue Apr 14, 2021
…ange their default browser

For mozilla-mobile#18855 [Telemetry] Send an event when users open the toolbar menu

For mozilla-mobile#18851 [Telemetry] Send an event when users click on the "set as default browser" entry in the toolbar menu
Amejia481 added a commit to Amejia481/fenix that referenced this issue Apr 14, 2021
…mobile#18857

For mozilla-mobile#18857 [Telemetry] Send a Glean event when users change their default browser

For mozilla-mobile#18855 [Telemetry] Send an event when users open the toolbar menu

For mozilla-mobile#18851 [Telemetry] Send an event when users click on the "set as default browser" entry in the toolbar menu
Amejia481 added a commit to Amejia481/fenix that referenced this issue Apr 14, 2021
…mobile#18857

For mozilla-mobile#18857 [Telemetry] Send a Glean event when users change their default browser

For mozilla-mobile#18855 [Telemetry] Send an event when users open the toolbar menu

For mozilla-mobile#18851 [Telemetry] Send an event when users click on the "set as default browser" entry in the toolbar menu
Amejia481 added a commit to Amejia481/fenix that referenced this issue Apr 14, 2021
…mobile#18857

For mozilla-mobile#18857 [Telemetry] Send a Glean event when users change their default browser

For mozilla-mobile#18855 [Telemetry] Send an event when users open the toolbar menu

For mozilla-mobile#18851 [Telemetry] Send an event when users click on the "set as default browser" entry in the toolbar menu
mcarare pushed a commit that referenced this issue Apr 15, 2021
For #18857 [Telemetry] Send a Glean event when users change their default browser

For #18855 [Telemetry] Send an event when users open the toolbar menu

For #18851 [Telemetry] Send an event when users click on the "set as default browser" entry in the toolbar menu
@Amejia481 Amejia481 reopened this Apr 15, 2021
@Amejia481 Amejia481 added the eng:qa:needed QA Needed label Apr 19, 2021
@lobontiumira
Copy link

Verified on the 4/20 Nightly build with Google Pixel (Android 10) that the following events are visible - ping 30304923-e389-4c4c-a99c-e41518c6afcf:

  • toolbar_menu_visible:
{
          "category": "events",
          "name": "toolbar_menu_visible",
          "timestamp": 2429
        }
  • default_browser_changed:
{
          "category": "events",
          "name": "default_browser_changed",
          "timestamp": 8631
        }

Glean dashboard
Logcat.txt

@Amejia481 I cannot trigger the "toolbar_menu_clicked". Am I missing something? Thank you!

experiments_default_browser:
  toolbar_menu_clicked:
    type: event
    description: |
      Set default browser was clicked from toolbar menu

@lobontiumira lobontiumira removed the eng:qa:needed QA Needed label Apr 20, 2021
@Amejia481
Copy link
Contributor

Thanks @lobontiumira, sorry for no clarifying earlier experiments_default_browser#toolbar_menu_clicked needs the default browser experiments to be setup in the server, that it hasn't be done yet.

I will close the issue as the probes that don't require experiments are working.

@lobontiumira lobontiumira added the eng:qa:verified QA Verified label Apr 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E3 Estimation Point: average, 2 - 3 days eng:qa:verified QA Verified Feature:Telemetry
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants