Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Show 'Default Browser' Local Notification for New users #19846

Closed
Amejia481 opened this issue Jun 5, 2021 · 8 comments
Closed

Show 'Default Browser' Local Notification for New users #19846

Amejia481 opened this issue Jun 5, 2021 · 8 comments
Assignees
@rocketsroger
Labels
E5 Estimation Point: about 5 days eng:qa:verified QA Verified feature request 🌟 New functionality and improvements
Projects
Android Engineering Team Kanban board
Milestone
91

Comments

@Amejia481
Copy link
Contributor

Amejia481 commented Jun 5, 2021 •
edited by data-sync-user
Loading

Built as a feature of the app, (much like the onboarding flow) that gets scheduled in a user's first session and triggers if they do not set us as default 24 hours after 1st app launch, see an example below.

image

┆Issue is synchronized with this Jira Task
@Amejia481 Amejia481 added feature request 🌟 New functionality and improvements E5 Estimation Point: about 5 days labels Jun 5, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 5, 2021
@Amejia481 Amejia481 mentioned this issue Jun 5, 2021
Closed
@amedyne amedyne removed the needs:triage Issue needs triage label Jun 8, 2021
@rocketsroger rocketsroger self-assigned this Jun 10, 2021
@amedyne amedyne added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation Jun 11, 2021
@rocketsroger rocketsroger moved this from Ready for Engineering (min-5 ; max-22) to In Development (WIP limit - 15) in Android Engineering Team Kanban board Jun 14, 2021
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Jun 23, 2021
@rocketsroger
Closes mozilla-mobile#19846: Show Default Browser Notification if bro…
1a2c438 
…wser is not default
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Jun 23, 2021
@rocketsroger
Closes mozilla-mobile#19846: Show Default Browser Notification if bro…
6a96c1e 
…wser is not default
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Jun 24, 2021
@rocketsroger
Closes mozilla-mobile#19846: Show Default Browser Notification if bro…
fbbf421 
…wser is not default
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Jun 24, 2021
@rocketsroger
Closes mozilla-mobile#19846: Show Default Browser Notification if bro…
8c4dfb3 
…wser is not default
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Jun 24, 2021
@rocketsroger
Closes mozilla-mobile#19846: Show Default Browser Notification if bro…
522ac13 
…wser is not default
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Jun 25, 2021
@rocketsroger
Closes mozilla-mobile#19846: Show Default Browser Notification if bro…
0365872 
…wser is not default
@rocketsroger rocketsroger moved this from In Development (WIP limit - 15) to Review in progress (WIP limit - 11) in Android Engineering Team Kanban board Jul 6, 2021
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Jul 6, 2021
@rocketsroger
Closes mozilla-mobile#19846: Show Default Browser Notification if bro…
c19a23b 
…wser is not default
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Jul 8, 2021
@rocketsroger
Closes mozilla-mobile#19846: Show Default Browser Notification if bro…
6ce67f1 
…wser is not default
@mergify mergify bot closed this as completed in 0133f42 Jul 8, 2021
Android Engineering Team Kanban board automation moved this from Review in progress (WIP limit - 11) to Done Jul 8, 2021
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Jul 8, 2021
@rocketsroger
Closes mozilla-mobile#19846: Only add default browser notification wo…
01b4810 
…rk if work is not pending
@jonalmeida jonalmeida reopened this Jul 8, 2021
Android Engineering Team Kanban board automation moved this from Done to In Development (WIP limit - 15) Jul 8, 2021
@jonalmeida jonalmeida added the eng:qa:needed QA Needed label Jul 8, 2021
@jonalmeida jonalmeida moved this from In Development (WIP limit - 15) to Reviewer approved, ready for test (WIP limit - ?) in Android Engineering Team Kanban board Jul 8, 2021
@mergify mergify bot closed this as completed in 6d1a44e Jul 8, 2021
Android Engineering Team Kanban board automation moved this from Reviewer approved, ready for test (WIP limit - ?) to Done Jul 8, 2021
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Jul 8, 2021
@rocketsroger
Closes mozilla-mobile#19846: Update default browser notification strings
a57284c
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Jul 8, 2021
@rocketsroger
Closes mozilla-mobile#19846: Update default browser notification strings
8349a0b
mergify bot pushed a commit that referenced this issue Jul 8, 2021
@rocketsroger @mergify
Closes #19846: Update default browser notification strings
d4af940
@jonalmeida jonalmeida reopened this Jul 8, 2021
@rocketsroger rocketsroger removed the eng:qa:needed QA Needed label Jul 14, 2021
@rocketsroger
Copy link
Contributor

Fixing a case when user does not tap on the notification but swiped it away.

mergify bot pushed a commit that referenced this issue Jul 15, 2021
@rocketsroger @mergify
Issue #19846: Make sure default browser notification only happens once
68b56ff
@jonalmeida jonalmeida added the eng:qa:needed QA Needed label Jul 15, 2021
@abodea
Copy link
Member

abodea commented Jul 15, 2021

Hello, @Amejia481 do we have a timer for the Default browser notification?
I'm trying to test this issue but after the onboarding flow, I saw no notification.

@abodea, after you first installed Fenix on the device (clean install) you'll have to wait 24 hours to make sure the notification shows up. Unfortunately, there's no other way to test this.

Thank you, Roger, yesterday I was in PTO but I have left a device for this bug.
Please note that I was able to trigger the Local Notification for new users.
Also, when I tapped on the notification I was correctly redirected to the select default browser and I was able to set it without issues.

I have left a device for tomorrow to verify the swiping side too.
Removing eng:qa:needed until I confirm this issue.

@abodea abodea removed the eng:qa:needed QA Needed label Jul 15, 2021
@rocketsroger rocketsroger moved this from Review in progress (WIP limit - 11) to In Testing/QA in Android Engineering Team Kanban board Jul 15, 2021
@rocketsroger rocketsroger added the eng:qa:needed QA Needed label Jul 15, 2021
mergify bot pushed a commit that referenced this issue Jul 15, 2021
@rocketsroger
Issue #19846: Make sure default browser notification only happens once
a26aaa0 
(cherry picked from commit 68b56ff)
rocketsroger added a commit that referenced this issue Jul 16, 2021
@mergify @rocketsroger
Issue #19846: Make sure default browser notification only happens once (
1048521 
#20383)

(cherry picked from commit 68b56ff)

Co-authored-by: Roger Yang <royang@mozilla.com>
@abodea
Copy link
Member

abodea commented Jul 19, 2021 •
edited
Loading

Hello, @rocketsroger please note that for the swipe notification after 24h I had the following behavior:
The notification went away and it didnt really appear anymore, it should be displayed again or not be able to dismiss it? Removing eng:qa:needed` until further notice, note that I have left another device for the new notification.

@abodea abodea removed the eng:qa:needed QA Needed label Jul 19, 2021
@rocketsroger
Copy link
Contributor

Hello, @rocketsroger please note that for the swipe notification after 24h I had the following behavior:
The notification went away and it didnt really appear anymore, it should be displayed again or not be able to dismiss it? Removing eng:qa:needed` until further notice, note that I have left another device for the new notification.

Yes, that's the correct behaviour. The user should be able to swipe the notification away. Once the user swiped the notification away it will not be displayed anymore. The notification will show only one time and regardless if the user tapped on it or swiped it away it will not be shown again.

@rocketsroger rocketsroger added the eng:qa:needed QA Needed label Jul 19, 2021
@abodea
Copy link
Member

abodea commented Jul 20, 2021

Hello, @rocketsroger please note that for the swipe notification after 24h I had the following behavior:
The notification went away and it didnt really appear anymore, it should be displayed again or not be able to dismiss it? Removing eng:qa:needed` until further notice, note that I have left another device for the new notification.

Yes, that's the correct behaviour. The user should be able to swipe the notification away. Once the user swiped the notification away it will not be displayed anymore. The notification will show only one time and regardless if the user tapped on it or swiped it away it will not be shown again.

Thank you very much @rocketsroger I was able to verify this on Beta Beta 91.0.0-beta.2 and the latest Nightly as mentioned above.
I swiped the notification without a problem.

@abodea abodea closed this as completed Jul 20, 2021
Android Engineering Team Kanban board automation moved this from In Testing/QA to Done Jul 20, 2021
@abodea abodea added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jul 20, 2021
@rocketsroger rocketsroger modified the milestones: 92, 91 Jul 20, 2021
czlucius pushed a commit to czlucius/fenix that referenced this issue Aug 20, 2021
@rocketsroger @czlucius
Closes mozilla-mobile#19846: Show Default Browser Notification if bro…
5cc21e3 
…wser is not default
czlucius pushed a commit to czlucius/fenix that referenced this issue Aug 20, 2021
@rocketsroger @czlucius
Closes mozilla-mobile#19846: Only add default browser notification wo…
b0c5a95 
…rk if work is not pending
czlucius pushed a commit to czlucius/fenix that referenced this issue Aug 20, 2021
@rocketsroger @czlucius
Closes mozilla-mobile#19846: Update default browser notification strings
335034d
czlucius pushed a commit to czlucius/fenix that referenced this issue Aug 20, 2021
@rocketsroger @czlucius
Issue mozilla-mobile#19846: Make sure default browser notification on…
62086c7 
…ly happens once
czlucius pushed a commit to czlucius/fenix that referenced this issue Aug 22, 2021
@rocketsroger @czlucius
Closes mozilla-mobile#19846: Show Default Browser Notification if bro…
b2c412d 
…wser is not default
czlucius pushed a commit to czlucius/fenix that referenced this issue Aug 22, 2021
@rocketsroger @czlucius
Closes mozilla-mobile#19846: Only add default browser notification wo…
2def01e 
…rk if work is not pending
czlucius pushed a commit to czlucius/fenix that referenced this issue Aug 22, 2021
@rocketsroger @czlucius
Closes mozilla-mobile#19846: Update default browser notification strings
2f74220
czlucius pushed a commit to czlucius/fenix that referenced this issue Aug 22, 2021
@rocketsroger @czlucius
Issue mozilla-mobile#19846: Make sure default browser notification on…
c1327db 
…ly happens once
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rocketsroger rocketsroger

Labels
E5 Estimation Point: about 5 days eng:qa:verified QA Verified feature request 🌟 New functionality and improvements
Projects
No open projects
Android Engineering Team Kanban board
Done
Milestone
91
Development

No branches or pull requests
5 participants
@Amejia481 @jonalmeida @rocketsroger @abodea @amedyne