Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Device names sticky in sync list #19942

Closed
topotropic opened this issue Jun 10, 2021 · 2 comments · Fixed by #23788
Closed

Device names sticky in sync list #19942

topotropic opened this issue Jun 10, 2021 · 2 comments · Fixed by #23788
Assignees
@MozillaNoah
Labels
feature request 🌟 New functionality and improvements Feature:SyncTabs Sync tabs TaskContinuity https://mozilla-hub.atlassian.net/browse/FNXV2-19368
Projects
Android Engineering Team Kanban board

Comments

@topotropic
Copy link

topotropic commented Jun 10, 2021 •
edited by data-sync-user

Make the device names sticky in the synced tabs view so that when people scroll they see the device name until another device is listed.

┆Issue is synchronized with this Jira Task
@topotropic topotropic added the Feature:SyncTabs Sync tabs label Jun 10, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 10, 2021
@jonalmeida jonalmeida mentioned this issue Jun 10, 2021
Closed
@jonalmeida
Copy link
Contributor

Eng notes: We can do this with an ItemDecoration that we can extend from our existing SyncedTabsTitleDecoration

@jonalmeida jonalmeida added the feature request 🌟 New functionality and improvements label Jun 10, 2021
@amedyne amedyne removed the needs:triage Issue needs triage label Jun 11, 2021
@jonalmeida jonalmeida mentioned this issue Nov 18, 2021
Closed
@jonalmeida jonalmeida mentioned this issue Dec 20, 2021
Merged
3 tasks
@MozillaNoah MozillaNoah self-assigned this Jan 6, 2022
@topotropic topotropic mentioned this issue Jan 21, 2022
Closed
@MozillaNoah MozillaNoah added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation Feb 15, 2022
@MozillaNoah MozillaNoah added this to the 99 milestone Feb 15, 2022
@MozillaNoah MozillaNoah moved this from Ready for Engineering (min-5 ; max-22) to In Development (WIP limit - 15) in Android Engineering Team Kanban board Feb 15, 2022
@MozillaNoah MozillaNoah removed this from the 99 milestone Feb 16, 2022
@MozillaNoah MozillaNoah mentioned this issue Feb 16, 2022
Merged
3 tasks
@gabrielluong
Copy link
Member

Designs https://www.figma.com/file/hJfV1KGZuOK7OYr29pooL5/Lists?node-id=69%3A6540

@MozillaNoah MozillaNoah moved this from In Development (WIP limit - 15) to Review in progress (WIP limit - 11) in Android Engineering Team Kanban board Feb 17, 2022
@mergify mergify bot closed this as completed in #23788 Feb 17, 2022
Android Engineering Team Kanban board automation moved this from Review in progress (WIP limit - 11) to Done Feb 17, 2022
mergify bot pushed a commit that referenced this issue Feb 17, 2022
@MozillaNoah @mergify
For #19942 - Add support for sticky headers to the synced tabs list
bd47420
@MozillaNoah MozillaNoah added the TaskContinuity https://mozilla-hub.atlassian.net/browse/FNXV2-19368 label Feb 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MozillaNoah MozillaNoah

Labels
feature request 🌟 New functionality and improvements Feature:SyncTabs Sync tabs TaskContinuity https://mozilla-hub.atlassian.net/browse/FNXV2-19368
Projects
No open projects
Android Engineering Team Kanban board
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

For #19942 - Add support for sticky headers on the synced tabs list MozillaNoah/fenix
5 participants
@topotropic @gabrielluong @jonalmeida @amedyne @MozillaNoah