Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Several missing icons in all themes #20292

Closed
hwinnemoe opened this issue Jul 8, 2021 · 14 comments
Closed

[Bug] Several missing icons in all themes #20292

hwinnemoe opened this issue Jul 8, 2021 · 14 comments
Assignees
@mcarare
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:MainMenu The three-dot menu that is seen on the browser and homescreen. Feature:Toolbar Address bar, see also Feature:Search needs:ac Needs Android Component Work qa-triaged Issues triaged by qa S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
Android Engineering Team Kanban board
Milestone
92

Comments

@hwinnemoe
Copy link

hwinnemoe commented Jul 8, 2021 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Open any website
  2. Open the three-dot menu

Expected behavior

All icons are present.

Actual behavior

In all themes (light, dark, private), several icons are missing, see the screenshots below:

missing_icon1_marked
missing_icon2_marked

Device information

  • Device vendor / model and Android version: Sony Xperia Z2, Android 6.0.1
  • Firefox for Android version: 91.0a1 (Build #2015820745)
    AC: 91.0.20210707143115, 8bf33ff684
    GV: 91.0a1-20210707095209
    AS: 79.0.0

┆Issue is synchronized with this Jira Task
@hwinnemoe hwinnemoe added the 🐞 bug Crashes, Something isn't working, .. label Jul 8, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Jul 8, 2021
@hwinnemoe
Copy link
Author

Since this hasn't been caught on other android versions, this may be an API specific issue. I'm experiencing this issue since 2021-07-06, so maybe a7a45df could be the culprit here since it was not tested on Android 6 devices.

@Nickoriginal
Copy link

Nickoriginal commented Jul 8, 2021 •
edited
Loading

Hello!
Not reproducible in Nightly 91.0a1 2021-07-07T20:05:59.523 on Samsung Galaxy A20s (Android 10). All icons are present.

@Nickoriginal
Copy link

Related to #20154.

@AndiAJ
Copy link
Collaborator

AndiAJ commented Jul 8, 2021

Hi, reproducible on the latest Nightly 91.0a1 using the following devices:
• OnePlus A3 (Android 6.0.1)
• LG Nexus 5 (Android 6.0.1)

► Video
20210708-141304

@AndiAJ AndiAJ added S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist Feature:MainMenu The three-dot menu that is seen on the browser and homescreen. Feature:Toolbar Address bar, see also Feature:Search labels Jul 8, 2021
@Nickoriginal
Copy link

Nickoriginal commented Jul 8, 2021 •
edited
Loading

#20292 (comment)
@hwinnemoe, you are right. Confirmed in Nightly 91.0a1 2021-07-07T20:05:59.523 on Samsung Galaxy J2 Prime (Android 6.0.1)

@mcarare mcarare self-assigned this Jul 8, 2021
@mcarare mcarare added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation Jul 8, 2021
@mcarare mcarare moved this from Ready for Engineering (min-5 ; max-22) to In Development (WIP limit - 15) in Android Engineering Team Kanban board Jul 8, 2021
@mcarare mcarare added the needs:ac Needs Android Component Work label Jul 8, 2021
@mcarare mcarare mentioned this issue Jul 8, 2021
Closed
@mcarare
Copy link
Contributor

mcarare commented Jul 8, 2021

AC issue: mozilla-mobile/android-components#10571.

mcarare added a commit to mcarare/fenix that referenced this issue Jul 8, 2021
@mcarare
For mozilla-mobile#20292: Use tint for home button icon.
3158d63
@sflorean sflorean added the qa-triaged Issues triaged by qa label Jul 9, 2021
@mcarare mcarare moved this from In Development (WIP limit - 15) to Dev Complete (WIP limit - 5) in Android Engineering Team Kanban board Jul 13, 2021
mcarare added a commit to mcarare/fenix that referenced this issue Jul 13, 2021
@mcarare
For mozilla-mobile#20292: Use tint for home button icon.
88e514c
mergify bot pushed a commit that referenced this issue Jul 14, 2021
@mcarare @mergify
For #20292: Use tint for home button icon.
b2a5723
@mcarare mcarare moved this from Dev Complete (WIP limit - 5) to Reviewer approved, ready for test (WIP limit - ?) in Android Engineering Team Kanban board Jul 14, 2021
@mcarare mcarare added eng:qa:needed QA Needed and removed needs:triage Issue needs triage labels Jul 14, 2021
@SoftVision-LorandJanos
Copy link

Still reproducible on the latest Nightly (91.0a1 - 2021-07-14T05:06:58.101). Will be retested tomorrow.

Device used: LG Nexus 5 (Android 6.0.1).

@gabrielluong gabrielluong moved this from Reviewer approved, ready for test (WIP limit - ?) to In Testing/QA in Android Engineering Team Kanban board Jul 14, 2021
@gabrielluong gabrielluong added this to the 92 milestone Jul 14, 2021
@SoftVision-LorandJanos
Copy link

Verified as fixed in the latest Nightly (92.0a1 2021-07-15T05:06:45.440).

Device used: LG Nexus 5 (Android 6.0.1).

Android Engineering Team Kanban board automation moved this from In Testing/QA to Done Jul 15, 2021
@AndiAJ
Copy link
Collaborator

AndiAJ commented Jul 16, 2021 •
edited
Loading

Still reproducible on Firefox Beta 91.0.0-beta.1 using a OnePlus A3 (Android 6.0.1) @amedyne

@sflorean
Copy link
Contributor

Reproducible also with Huawei MediaPad M2 (Android 5.1.1) on the above build.

@amedyne
Copy link
Contributor

amedyne commented Jul 16, 2021

@mcarare Can you put a PR to uplift the fix on Beta for this? Thanks!

@Nickoriginal
Copy link

Nickoriginal commented Jul 16, 2021 •
edited
Loading

There are also missing lock icon in the pop-up window, ✓ symbol opposite the selected language and + symbol opposite the recommended add-ons.


(Samsung Galaxy J2 Prime, Android 6.0.1, 91.0.0-beta.1)

mergify bot pushed a commit that referenced this issue Jul 16, 2021
@mcarare
For #20292: Use tint for home button icon.
a47d1d0 
(cherry picked from commit b2a5723)
Amejia481 pushed a commit that referenced this issue Jul 16, 2021
@mcarare @Amejia481
For #20292: Use tint for home button icon.
5194ba9 
(cherry picked from commit b2a5723)
@Nickoriginal
Copy link

Fixed in Firefox 91.0.0-beta.2 on Samsung Galaxy J2 Prime (Android 6.0.1)

@SoftVision-LorandJanos
Copy link

Verified as fixed with the latest beta (91.0.0-beta.2).
Device Used: LG Nexus 5 (Android 6.0.1).
Not reproducible on the latest Release (RC 90.1.2).

czlucius pushed a commit to czlucius/fenix that referenced this issue Aug 20, 2021
@mcarare @czlucius
For mozilla-mobile#20292: Use tint for home button icon.
9055acf
czlucius pushed a commit to czlucius/fenix that referenced this issue Aug 22, 2021
@mcarare @czlucius
For mozilla-mobile#20292: Use tint for home button icon.
cb671b9
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:MainMenu The three-dot menu that is seen on the browser and homescreen. Feature:Toolbar Address bar, see also Feature:Search needs:ac Needs Android Component Work qa-triaged Issues triaged by qa S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
No open projects
Android Engineering Team Kanban board
Done
Milestone
92
Development

No branches or pull requests
8 participants
@gabrielluong @hwinnemoe @SoftVision-LorandJanos @mcarare @AndiAJ @sflorean @amedyne @Nickoriginal