Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Temporary disable SearchTest#shortcutButtonTest test #20420

Closed
Mugurell opened this issue Jul 19, 2021 · 2 comments
Closed

Temporary disable SearchTest#shortcutButtonTest test #20420

Mugurell opened this issue Jul 19, 2021 · 2 comments
Assignees
@Mugurell
Labels
eng:disabled-test For any test that has been disabled eng:ui-test UI Tests

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Jul 19, 2021 •
edited by data-sync-user

SearchTest#shortcutButtonTest fails here because of a recent change that prepends the left to right mark for text in [DisplayToolbar].
So the text is now actually
\u200Educkduckgo.com/?q=mozilla instead of the searched for
duckduckgo.com/?q=mozilla

To not go on a slippery slope and add \u200E here now and who knows where also later I propose unblocking the AC bump by temporarily disabling this test until the AC functionality is improved.

CC @sv-ohorvath

┆Issue is synchronized with this Jira Task
@Mugurell Mugurell self-assigned this Jul 19, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Jul 19, 2021
@sv-ohorvath
Copy link
Contributor

Thanks, Petru!

@Mugurell Mugurell mentioned this issue Jul 19, 2021
Closed
@sv-ohorvath sv-ohorvath added eng:disabled-test For any test that has been disabled eng:intermittent-test Evil test failures that only happen now-and-then and are a productivity killer eng:ui-test UI Tests and removed needs:triage Issue needs triage eng:intermittent-test Evil test failures that only happen now-and-then and are a productivity killer labels Jul 19, 2021
@Mugurell Mugurell mentioned this issue Jul 19, 2021
Merged
mergify bot pushed a commit that referenced this issue Jul 19, 2021
@Mugurell @mergify
For #20420 - Temporarily disable SearchTest#shortcutButtonTest
0944135
mergify bot pushed a commit that referenced this issue Jul 23, 2021
@Mugurell @mergify
For #20420 - Re-enable shortcutButtonTest
52e1523 
The issue affecting this was resolved in AC.
@sv-ohorvath
Copy link
Contributor

The test was re-enabled, I'll close this now. Thanks again, Petru!

czlucius pushed a commit to czlucius/fenix that referenced this issue Aug 20, 2021
@Mugurell @czlucius
For mozilla-mobile#20420 - Temporarily disable SearchTest#shortcutBut…
fa08adb 
…tonTest
czlucius pushed a commit to czlucius/fenix that referenced this issue Aug 20, 2021
@Mugurell @czlucius
For mozilla-mobile#20420 - Re-enable shortcutButtonTest
7252126 
The issue affecting this was resolved in AC.
czlucius pushed a commit to czlucius/fenix that referenced this issue Aug 22, 2021
@Mugurell @czlucius
For mozilla-mobile#20420 - Temporarily disable SearchTest#shortcutBut…
c4c75d2 
…tonTest
czlucius pushed a commit to czlucius/fenix that referenced this issue Aug 22, 2021
@Mugurell @czlucius
For mozilla-mobile#20420 - Re-enable shortcutButtonTest
a19c91b 
The issue affecting this was resolved in AC.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Mugurell Mugurell

Labels
eng:disabled-test For any test that has been disabled eng:ui-test UI Tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sv-ohorvath @Mugurell