Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]: TopSites page count not updating #20440

Closed
codrut-topliceanu opened this issue Jul 20, 2021 · 1 comment
Closed

[Bug]: TopSites page count not updating #20440

codrut-topliceanu opened this issue Jul 20, 2021 · 1 comment
Assignees
@codrut-topliceanu
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Shortcuts Top Sites/Topsites on the Firefox home page
Projects
Android Engineering Team Kanban board

Comments

@codrut-topliceanu
Copy link
Contributor

codrut-topliceanu commented Jul 20, 2021 •
edited by data-sync-user

Steps to reproduce

  1. Have 9 topsites available, thus needing two pages
  2. Delete one topsite

Expected behaviour

With 8 TopSites only one page should be available

Actual behaviour

There are still two pages, the 2nd one is empty, the page indicator is still visible

Device name

OneTouch 6

Android version

Android 9

Firefox release type

Firefox Nightly

Firefox version

latest master

Additional information

This bug was introduced by the fix for #15499 -> PR: #20189

Video of the issue :

extra.page.mp4

┆Issue is synchronized with this Jira Task
@codrut-topliceanu codrut-topliceanu added 🐞 bug Crashes, Something isn't working, .. needs:triage Issue needs triage Feature:Shortcuts Top Sites/Topsites on the Firefox home page labels Jul 20, 2021
@codrut-topliceanu codrut-topliceanu self-assigned this Jul 21, 2021
@codrut-topliceanu codrut-topliceanu added this to Triage in Tabs Tray via automation Jul 21, 2021
@codrut-topliceanu codrut-topliceanu added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation Jul 21, 2021
@codrut-topliceanu codrut-topliceanu removed this from Triage in Tabs Tray Jul 21, 2021
@codrut-topliceanu codrut-topliceanu moved this from Ready for Engineering (min-5 ; max-22) to In Development (WIP limit - 15) in Android Engineering Team Kanban board Jul 21, 2021
@codrut-topliceanu codrut-topliceanu removed the needs:triage Issue needs triage label Jul 21, 2021
codrut-topliceanu pushed a commit to codrut-topliceanu/fenix that referenced this issue Jul 26, 2021
For mozilla-mobile#20440 - Forces TopSitePager bind if no. of pages c…
93cf8a3 
…hanged
@codrut-topliceanu codrut-topliceanu mentioned this issue Jul 26, 2021
Merged
3 tasks
@codrut-topliceanu codrut-topliceanu moved this from In Development (WIP limit - 15) to Dev Complete (WIP limit - 5) in Android Engineering Team Kanban board Jul 26, 2021
codrut-topliceanu pushed a commit to codrut-topliceanu/fenix that referenced this issue Jul 26, 2021
For mozilla-mobile#20440 - Forces TopSitePager bind if no. of pages c…
b46347f 
…hanged
codrut-topliceanu pushed a commit to codrut-topliceanu/fenix that referenced this issue Jul 26, 2021
For mozilla-mobile#20440 - Forces TopSitePager bind if no. of pages c…
09fa7c5 
…hanged
mergify bot pushed a commit that referenced this issue Jul 27, 2021
@mergify
For #20440 - Forces TopSitePager bind if no. of pages changed
e2af42a
@codrut-topliceanu codrut-topliceanu moved this from Dev Complete (WIP limit - 5) to Reviewer approved, ready for test (WIP limit - ?) in Android Engineering Team Kanban board Jul 28, 2021
@sflorean sflorean moved this from Reviewer approved, ready for test (WIP limit - ?) to In Testing/QA in Android Engineering Team Kanban board Jul 28, 2021
@SoftVision-LorandJanos
Copy link

Verified as fixed in the latest Nightly (92.0a1 20210728T05:08:41.498400).

Devices used:

  • Motorola Nexus 6 (Android 7.1.1)
  • Samsung Galaxy Tab 3 (Android 9)
  • Google Pixel 4 (Android 11)
  • Huawei P9 Lite (Android 7.0).

Android Engineering Team Kanban board automation moved this from In Testing/QA to Done Jul 29, 2021
@sflorean sflorean removed the eng:qa:needed QA Needed label Aug 4, 2021
czlucius pushed a commit to czlucius/fenix that referenced this issue Aug 20, 2021
@czlucius
For mozilla-mobile#20440 - Forces TopSitePager bind if no. of pages c…
88873e9 
…hanged
czlucius pushed a commit to czlucius/fenix that referenced this issue Aug 22, 2021
@czlucius
For mozilla-mobile#20440 - Forces TopSitePager bind if no. of pages c…
c42739b 
…hanged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@codrut-topliceanu codrut-topliceanu

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Shortcuts Top Sites/Topsites on the Firefox home page
Projects
No open projects
Android Engineering Team Kanban board
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SoftVision-LorandJanos @sflorean @codrut-topliceanu