This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Introduce an app store to hold state for the lifecycle of the app #20704
Labels
Projects
Comments
3 tasks
We can possibly add top sites to this store as well. Data classes are cheap.. we should consider holding more of the The |
After talking to mcomella about tabs tray performance, there may be reason to move that state to the app store level too. |
mcomella
added this to Needs prioritization
in Performance, front-end roadmap
via automation
Aug 19, 2021
MarcLeclair
moved this from Needs prioritization
to Top 10 Inter-Team bugs
in Performance, front-end roadmap
Sep 1, 2021
jonalmeida
added a commit
to jonalmeida/fenix
that referenced
this issue
Nov 1, 2021
jonalmeida
added a commit
to jonalmeida/fenix
that referenced
this issue
Nov 1, 2021
jonalmeida
added a commit
to jonalmeida/fenix
that referenced
this issue
Nov 1, 2021
jonalmeida
added a commit
to jonalmeida/fenix
that referenced
this issue
Nov 1, 2021
As of now, I've landed an AppStore in Fenix that can be used to hold in-memory state during a warm startup. The store landed with a trivial flag for inactive tabs as an example use case. When should you decide to use it?There are various constraints to consider before using the
Other possible uses
|
pkirakosyan
pushed a commit
to gexsi/user-agent-android
that referenced
this issue
Mar 7, 2022
pkirakosyan
pushed a commit
to gexsi/user-agent-android
that referenced
this issue
Mar 7, 2022
3 tasks
4 tasks
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In #20687, we spoke about the value of an AppStore to hold state that needs to live as long as the app (or longer than the fragment).
With the introduction of UI state like the collapsible inactive tabs list, this is a good opportunity to create one and add it in there.
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: