Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Bookmarks in "Your Library" appear as "bookmarked" style in quick actions panel #2083

Closed
yoasif opened this issue Apr 26, 2019 · 5 comments
Closed

Bookmarks in "Your Library" appear as "bookmarked" style in quick actions panel #2083

yoasif opened this issue Apr 26, 2019 · 5 comments
Labels
eng:qa:verified QA Verified Feature:Bookmarks P1 Current sprint
Milestone
MVP Backlog

Comments

@yoasif
Copy link
Contributor

yoasif commented Apr 26, 2019 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Open Fenix
  2. Menu > Your Library

Expected behavior

"Bookmarks" styling shouldn't look "active" or "bookmarked".

Actual behavior

The bookmarks icon is the same as used when a user swipes up in a quick action panel and the page has been bookmarked. History is not "filled in" like Bookmarks is, so it looks out of place.

signal-attachment-2019-04-26-143930

Device information

  • Android device: Pixel 2
  • Fenix version: latest from play store

┆Issue is synchronized with this Jira Task
@yoasif yoasif added the 🐞 bug Crashes, Something isn't working, .. label Apr 26, 2019
@ekager
Copy link
Contributor

ekager commented Apr 26, 2019

@AmyYLee which bookmark icon should be used for this library icon? The outline version from #1601 ?

@ekager ekager added needs:UX-feedback Needs UX Feedback and removed 🐞 bug Crashes, Something isn't working, .. labels Apr 26, 2019
@kbrosnan
Copy link
Contributor

These are items the user has bookmarked so the filled in icon makes sense here.

@yoasif
Copy link
Contributor Author

yoasif commented Apr 26, 2019 •
edited
Loading

These are items the user has bookmarked so the filled in icon makes sense here.

Only issue I find here is that the styling for the history vs. the bookmarks icon looks inconsistent.

@ekager ekager changed the title [Bug] Bookmarks in "Your Library" appear as "bookmarked" style in quick actions panel Bookmarks in "Your Library" appear as "bookmarked" style in quick actions panel Apr 26, 2019
@AmyYLee
Copy link
Collaborator

AmyYLee commented Apr 29, 2019

@AmyYLee which bookmark icon should be used for this library icon? The outline version from #1601 ?

Hi, yes can you please use the outline version here?

@vesta0 vesta0 removed the needs:UX-feedback Needs UX Feedback label Apr 30, 2019
@vesta0 vesta0 added this to the MVP Backlog milestone Apr 30, 2019
@vesta0 vesta0 added the P1 Current sprint label Apr 30, 2019
@vesta0 vesta0 added this to Done in Fenix Sprint Kanban Apr 30, 2019
@vesta0 vesta0 moved this from Done to UX Review in Fenix Sprint Kanban Apr 30, 2019
@vesta0 vesta0 moved this from UX Review to Ready for Dev in Fenix Sprint Kanban Apr 30, 2019
@colintheshots colintheshots self-assigned this May 1, 2019
colintheshots added a commit to colintheshots/fenix that referenced this issue May 1, 2019
@colintheshots
For mozilla-mobile#2083: Bookmarks in "Your Library" appear as "bookm…
ff9c847 
…arked" style
@vesta0 vesta0 moved this from Ready for Dev to In Progress in Fenix Sprint Kanban May 1, 2019
colintheshots added a commit that referenced this issue May 1, 2019
@colintheshots
For #2083: Bookmarks in "Your Library" appear as "bookmarked" style (#…
6cff732 
…2201)
@colintheshots colintheshots added eng:qa:needed QA Needed and removed review labels May 1, 2019
@project-bot project-bot bot moved this from In Progress to Ready for QA in Fenix Sprint Kanban May 1, 2019
@colintheshots colintheshots moved this from Ready for QA to In Progress in Fenix Sprint Kanban May 1, 2019
@colintheshots colintheshots moved this from In Progress to Ready for QA in Fenix Sprint Kanban May 1, 2019
@sv-ohorvath
Copy link
Contributor

Verified as fixed on master. build 5/2

@sv-ohorvath sv-ohorvath added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels May 2, 2019
@sv-ohorvath sv-ohorvath moved this from Ready for QA to Done in Fenix Sprint Kanban May 2, 2019
@bifleming bifleming removed this from Done in Fenix Sprint Kanban May 7, 2019
@data-sync-user data-sync-user changed the title Bookmarks in "Your Library" appear as "bookmarked" style in quick actions panel FNX2-17646 ⁃ Bookmarks in "Your Library" appear as "bookmarked" style in quick actions panel Aug 4, 2020
@data-sync-user data-sync-user changed the title FNX2-17646 ⁃ Bookmarks in "Your Library" appear as "bookmarked" style in quick actions panel FNX3-16046 ⁃ Bookmarks in "Your Library" appear as "bookmarked" style in quick actions panel Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-16046 ⁃ Bookmarks in "Your Library" appear as "bookmarked" style in quick actions panel FNX-5443 ⁃ Bookmarks in "Your Library" appear as "bookmarked" style in quick actions panel Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-5443 ⁃ Bookmarks in "Your Library" appear as "bookmarked" style in quick actions panel Bookmarks in "Your Library" appear as "bookmarked" style in quick actions panel May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
eng:qa:verified QA Verified Feature:Bookmarks P1 Current sprint
Projects
None yet
Milestone
MVP Backlog
Development

No branches or pull requests
8 participants
@yoasif @kbrosnan @colintheshots @sv-ohorvath @AmyYLee @ekager @vesta0 @data-sync-user