Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Quick Action Toolbar Bookmark icon should have visual affordance if bookmarked #1601

Closed
yoasif opened this issue Apr 12, 2019 · 6 comments
Closed

Quick Action Toolbar Bookmark icon should have visual affordance if bookmarked #1601

yoasif opened this issue Apr 12, 2019 · 6 comments
Assignees
@AmyYLee @ekager
Labels
eng:qa:verified QA Verified P1 Current sprint
Milestone
Sprint 5-1 (Miles...

Comments

@yoasif
Copy link
Contributor

yoasif commented Apr 12, 2019 •
edited by data-sync-user

Why/User Benefit/User Problem

As a user, I would like to know if a page is bookmarked before I tap bookmark again, to prevent myself from creating a new bookmark #1586 or to edit the bookmark (new story?).

What / Requirements

The quick action bar bookmark icon should not be filled in (solid black) unless I have bookmarked the page previously.

FWIW, Fennec does the same thing.

Acceptance Criteria (how do I know when I’m done?)

  • Pages that are not bookmarked has icon that is not filled in.
  • Pages that are bookmarked are solid colored (not just border)

┆Issue is synchronized with this Jira Task
@ekager ekager added the needs:UX-feedback Needs UX Feedback label Apr 12, 2019
@sv-ohorvath sv-ohorvath mentioned this issue Apr 15, 2019
Closed
@vesta0 vesta0 added the P1 Current sprint label Apr 17, 2019
@vesta0 vesta0 added this to the MVP Backlog milestone Apr 17, 2019
@bifleming bifleming added this to Blocked by UX in Blocking Fenix Apr 17, 2019
@vesta0 vesta0 added the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Apr 17, 2019
@mheubusch
Copy link
Contributor

@AmyYLee Can you look at this or reassign to Nicole?

@topotropic topotropic mentioned this issue Apr 23, 2019
Closed
@AmyYLee
Copy link
Collaborator

AmyYLee commented Apr 23, 2019 •
edited

Hi,
Here is a spec of bookmarked vs non-bookmarked states. @ekager

Screen Shot 2019-04-23 at 4 19 35 PM

@ekager ekager self-assigned this Apr 23, 2019
ekager added a commit to ekager/fenix that referenced this issue Apr 23, 2019
@ekager
For mozilla-mobile#1601 - Bookmark icon should change visually if pag…
b00ec54 
…e is bookmarked
ekager added a commit to ekager/fenix that referenced this issue Apr 23, 2019
@ekager
For mozilla-mobile#1601 - Bookmark icon should change visually if pag…
8e6bad0 
…e is bookmarked
@AmyYLee
Copy link
Collaborator

AmyYLee commented Apr 23, 2019

@ekager Just updated this bug with a colour edit.

@AmyYLee AmyYLee added 👍 shorlander approved and removed needs:UX-feedback Needs UX Feedback labels Apr 23, 2019
@ekager
Copy link
Contributor

ekager commented Apr 23, 2019

Got it, thanks!

ekager added a commit to ekager/fenix that referenced this issue Apr 23, 2019
@ekager
For mozilla-mobile#1601 - Bookmark icon should change visually if pag…
eea1936 
…e is bookmarked
ekager added a commit to ekager/fenix that referenced this issue Apr 23, 2019
@ekager
For mozilla-mobile#1601 - Bookmark icon should change visually if pag…
1e211fd 
…e is bookmarked
@lime124 lime124 removed the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Apr 23, 2019
@lime124 lime124 removed this from Blocked by UX in Blocking Fenix Apr 23, 2019
ekager added a commit to ekager/fenix that referenced this issue Apr 23, 2019
@ekager
For mozilla-mobile#1601 - Bookmark icon should change visually if pag…
1c18529 
…e is bookmarked
@vesta0 vesta0 added this to In Progress in Fenix Sprint Kanban Apr 24, 2019
@colintheshots colintheshots mentioned this issue Apr 24, 2019
Closed
ekager added a commit to ekager/fenix that referenced this issue Apr 25, 2019
@ekager
For mozilla-mobile#1601 - Bookmark icon should change visually if pag…
383506c 
…e is bookmarked
ekager added a commit to ekager/fenix that referenced this issue Apr 25, 2019
@ekager
For mozilla-mobile#1601 - Bookmark icon should change visually if pag…
b5bfac0 
…e is bookmarked
ekager added a commit to ekager/fenix that referenced this issue Apr 25, 2019
@ekager
For mozilla-mobile#1601 - Bookmark icon should change visually if pag…
afb0007 
…e is bookmarked
ekager added a commit to ekager/fenix that referenced this issue Apr 26, 2019
@ekager
For mozilla-mobile#1601 - Bookmark icon should change visually if pag…
ebd91e8 
…e is bookmarked
ekager added a commit to ekager/fenix that referenced this issue Apr 26, 2019
@ekager
For mozilla-mobile#1601 - Bookmark icon should change visually if pag…
5d777a8 
…e is bookmarked
ekager added a commit that referenced this issue Apr 26, 2019
@ekager
For #1601 - Bookmark icon should change visually if page is bookmarked
99f979e
@kbrosnan
Copy link
Contributor

kbrosnan commented Apr 26, 2019 •
edited

@ekager Found #2063 and #2068 while testing this.

@ekager ekager mentioned this issue Apr 26, 2019
Closed
@colintheshots colintheshots added the eng:qa:needed QA Needed label May 1, 2019
@project-bot project-bot bot moved this from In Progress to Ready for QA in Fenix Sprint Kanban May 1, 2019
@sv-ohorvath
Copy link
Contributor

Verified on master 5/2. Remaining known issue: #2068.

@sv-ohorvath sv-ohorvath added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels May 2, 2019
@sv-ohorvath sv-ohorvath moved this from Ready for QA to Done in Fenix Sprint Kanban May 2, 2019
@bifleming bifleming removed this from Done in Fenix Sprint Kanban May 7, 2019
@data-sync-user data-sync-user changed the title Quick Action Toolbar Bookmark icon should have visual affordance if bookmarked FNX2-17255 ⁃ Quick Action Toolbar Bookmark icon should have visual affordance if bookmarked Aug 3, 2020
@data-sync-user data-sync-user changed the title FNX2-17255 ⁃ Quick Action Toolbar Bookmark icon should have visual affordance if bookmarked FNX3-15677 ⁃ Quick Action Toolbar Bookmark icon should have visual affordance if bookmarked Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-15677 ⁃ Quick Action Toolbar Bookmark icon should have visual affordance if bookmarked FNX-5130 ⁃ Quick Action Toolbar Bookmark icon should have visual affordance if bookmarked Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-5130 ⁃ Quick Action Toolbar Bookmark icon should have visual affordance if bookmarked Quick Action Toolbar Bookmark icon should have visual affordance if bookmarked May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AmyYLee AmyYLee

@ekager ekager

Labels
eng:qa:verified QA Verified P1 Current sprint
Projects
None yet
Milestone
Sprint 5-1 (Milestone 5)
Development

No branches or pull requests
10 participants
@yoasif @kbrosnan @lime124 @colintheshots @sv-ohorvath @AmyYLee @mheubusch @ekager @vesta0 @data-sync-user