Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Include git revision in About Nightly screen #21084

Closed
mcomella opened this issue Aug 31, 2021 · 1 comment
Closed

Include git revision in About Nightly screen #21084

mcomella opened this issue Aug 31, 2021 · 1 comment
Assignees
@mcomella
Labels
performance Possible performance wins
Projects
Performance, front-end roadmap

Comments

@mcomella
Copy link
Contributor

mcomella commented Aug 31, 2021 •
edited by data-sync-user
Loading

If you want to bisect a performance problem between two Nightly builds, you currently have to guess which revisions are in which Nightly. We can address that in a low effort way by including the git revision on the About Nightly screen, like how ac does it:
image

┆Issue is synchronized with this Jira Task
@mcomella mcomella created this issue from a note in Performance, front-end roadmap (Backlog (prioritized)) Aug 31, 2021
@mcomella mcomella added the performance Possible performance wins label Aug 31, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Aug 31, 2021
@mcomella mcomella mentioned this issue Aug 31, 2021
Closed
@kbrosnan kbrosnan removed the needs:triage Issue needs triage label Sep 1, 2021
@mcomella mcomella moved this from Backlog, perf team (prioritized) to Needs triage in Performance, front-end roadmap Nov 2, 2021
@mcomella mcomella moved this from Needs triage to Backlog, perf team (prioritized) in Performance, front-end roadmap Nov 3, 2021
@mcomella mcomella self-assigned this Nov 5, 2021
@mcomella mcomella moved this from Backlog, perf team (prioritized) to In progress in Performance, front-end roadmap Nov 5, 2021
mcomella added a commit to mcomella/fenix that referenced this issue Nov 5, 2021
@mcomella
For mozilla-mobile#21084: add Runtime.execReadStandardOutOrThrow.
d56c3ee 
This command makes it a one liner to execute an external command, which will
allow us to easily run git commands in the next section.

Sample error output:

```
* What went wrong:
Execution failed for task ':app:gitHash'.
> command exited with non-zero exit value: 1.
  cmd: git reev-parse --short HEAD
  stderr:
  git: 'reev-parse' is not a git command. See 'git --help'.

  The most similar command is
        rev-parse
```
mcomella added a commit to mcomella/fenix that referenced this issue Nov 5, 2021
@mcomella
For mozilla-mobile#21084: add Config.getGitHash.
0d7383f
mcomella added a commit to mcomella/fenix that referenced this issue Nov 5, 2021
@mcomella
For mozilla-mobile#21084: put git hash on About screen in release bui…
4b6834f 
…lds.
mergify bot pushed a commit that referenced this issue Nov 8, 2021
@mcomella @mergify
For #21084: add Runtime.execReadStandardOutOrThrow.
d35e687 
This command makes it a one liner to execute an external command, which will
allow us to easily run git commands in the next section.

Sample error output:

```
* What went wrong:
Execution failed for task ':app:gitHash'.
> command exited with non-zero exit value: 1.
  cmd: git reev-parse --short HEAD
  stderr:
  git: 'reev-parse' is not a git command. See 'git --help'.

  The most similar command is
        rev-parse
```
mergify bot pushed a commit that referenced this issue Nov 8, 2021
@mcomella @mergify
For #21084: add Config.getGitHash.
117b35a
mergify bot pushed a commit that referenced this issue Nov 8, 2021
@mcomella @mergify
For #21084: put git hash on About screen in release builds.
c026d8b
@mcomella
Copy link
Contributor Author

mcomella commented Nov 8, 2021

Closed by #22336

@mcomella mcomella closed this as completed Nov 8, 2021
Performance, front-end roadmap automation moved this from In progress to Done Nov 8, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@mcomella @pkirakosyan
For mozilla-mobile#21084: add Runtime.execReadStandardOutOrThrow.
e690646 
This command makes it a one liner to execute an external command, which will
allow us to easily run git commands in the next section.

Sample error output:

```
* What went wrong:
Execution failed for task ':app:gitHash'.
> command exited with non-zero exit value: 1.
  cmd: git reev-parse --short HEAD
  stderr:
  git: 'reev-parse' is not a git command. See 'git --help'.

  The most similar command is
        rev-parse
```
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@mcomella @pkirakosyan
For mozilla-mobile#21084: add Config.getGitHash.
6aa9961
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@mcomella @pkirakosyan
For mozilla-mobile#21084: put git hash on About screen in release bui…
6e19033 
…lds.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcomella mcomella

Labels
performance Possible performance wins
Projects
Performance, front-end roadmap
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kbrosnan @mcomella