-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Replace BrowserAwesomeBar (browser-awesomebar) with AwesomeBar composable (compose-awesomebar) #21172
Comments
@pocmo with the above commit do you know how we can re-enable |
…meBar() composable.
@AaronMT This is still an issue, right? I think there's a way to get the suggestion count. I'll take a look. |
Andi is using a workaround in #21517 |
@AaronMT In mozilla-mobile/android-components#11050 I am adding a tag to every suggestion ( fun ComposeTestRule.countSuggestions(): Int {
val nodes = onAllNodesWithTag("mozac.awesomebar.suggestion")
val matchedNodes = nodes.fetchSemanticsNodes(
atLeastOneRootRequired = false
)
return matchedNodes.size
} And can also wait for them to appear: fun ComposeTestRule.waitForSuggestions(timeoutMillis: Long = 1_000) {
waitUntil(timeoutMillis) {
countSuggestions() > 0
}
} I guess that should work from an idle resource too, if we pass the |
Closing the issue since the integration PR already landed. |
A while ago we integrated the
AwesomeBar()
composable into Focus. Now, after mozilla-mobile/android-components#10922, we are ready to integrate it into Fenix too. I would like to land this change at the beginning of the 94 Nightly cycle.┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: