Add profiler markers for activity lifecycle callbacks #21299

mcomella · 2021-09-15T00:42:28Z

These are key events in the application so we should display them in the profiler.

┆Issue is synchronized with this Jira Task

…backs. We implement these all in the same track because between it'd create a lot noise between this and fragment lifecycle callbacks.

…ity.onCreate. We only instrument onCreate because it's the only one with an implementation. While declaring this as a function that accepts a lambda is less fragile, we've previously had issues with it such as suspected memory leaks when used for telemetry. Therefore, we go with the simpler approach.

…e/Start. We only instrument these methods because they're the only ones that noticeably long running in the current implementation.

We implement these all in the same track because between it'd create a lot noise between this and fragment lifecycle callbacks.

We only instrument onCreate because it's the only one with an implementation. While declaring this as a function that accepts a lambda is less fragile, we've previously had issues with it such as suspected memory leaks when used for telemetry. Therefore, we go with the simpler approach.

We only instrument these methods because they're the only ones that noticeably long running in the current implementation.

…backs.

…ity.onCreate. We only instrument onCreate because it's the only one with an implementation. While declaring this as a function that accepts a lambda is less fragile, we've previously had issues with it such as suspected memory leaks when used for telemetry. Therefore, we go with the simpler approach.

…e/Start.

mcomella added the performance Possible performance wins label Sep 15, 2021

mcomella added this to Needs prioritization in Performance, front-end roadmap via automation Sep 15, 2021

mcomella self-assigned this Sep 15, 2021

mcomella moved this from Needs prioritization to In progress in Performance, front-end roadmap Sep 15, 2021

github-actions bot added the needs:triage Issue needs triage label Sep 15, 2021

mcomella linked a pull request Sep 15, 2021 that will close this issue

For #21299: add activity lifecycle profiler markers #21300

Merged

3 tasks

mergify bot closed this as completed in #21300 Sep 17, 2021

Performance, front-end roadmap automation moved this from In progress to Done Sep 17, 2021

mergify bot pushed a commit that referenced this issue Sep 17, 2021

For #21299: add markers for all activity lifecycle callbacks.

f8a4113

We implement these all in the same track because between it'd create a lot noise between this and fragment lifecycle callbacks.

mergify bot pushed a commit that referenced this issue Sep 17, 2021

For #21299: add duration markers for HomeActivity Create/Start.

bb632c7

We only instrument these methods because they're the only ones that noticeably long running in the current implementation.

pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Sep 24, 2021

For mozilla-mobile#21299: add markers for all activity lifecycle call…

f4cb785

…backs.

pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Sep 24, 2021

For mozilla-mobile#21299: add duration markers for HomeActivity Creat…

b1c1fec

…e/Start.

mcomella mentioned this issue Oct 13, 2021

Add markers for Fragment lifecycle callbacks #21921

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add profiler markers for activity lifecycle callbacks #21299

Add profiler markers for activity lifecycle callbacks #21299

mcomella commented Sep 15, 2021 •

edited by data-sync-user

Add profiler markers for activity lifecycle callbacks #21299

Add profiler markers for activity lifecycle callbacks #21299

Comments

mcomella commented Sep 15, 2021 • edited by data-sync-user

mcomella commented Sep 15, 2021 •

edited by data-sync-user