Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Add markers for onGlobalLayout #21309

Closed
mcomella opened this issue Sep 15, 2021 · 0 comments · Fixed by #21311
Closed

Add markers for onGlobalLayout #21309

mcomella opened this issue Sep 15, 2021 · 0 comments · Fixed by #21311
Assignees
@mcomella
Labels
needs:triage Issue needs triage performance Possible performance wins
Projects
Performance, front-end roadmap

Comments

@mcomella
Copy link
Contributor

mcomella commented Sep 15, 2021 •
edited by data-sync-user
Loading

It'd be useful to see how often we call layout, e.g. to avoid redundant layouts.

┆Issue is synchronized with this Jira Task
@mcomella mcomella added the performance Possible performance wins label Sep 15, 2021
@mcomella mcomella self-assigned this Sep 15, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Sep 15, 2021
mcomella added a commit to mcomella/fenix that referenced this issue Sep 15, 2021
@mcomella
For mozilla-mobile#21309: remove outdated comment regarding async nav…
0fa4c37 
… graph.
mcomella added a commit to mcomella/fenix that referenced this issue Sep 15, 2021
@mcomella
For mozilla-mobile#21309: set up HomeActivityBinding the recommended …
e2564f7 
…way.

The recommended way is here:
https://developer.android.com/topic/libraries/view-binding

I was concerned with the existing implementation that binding was being
set conditionally.
mcomella added a commit to mcomella/fenix that referenced this issue Sep 15, 2021
@mcomella
For mozilla-mobile#21309: add profiler markers on global layout.
f851394
@mcomella mcomella linked a pull request Sep 15, 2021 that will close this issue
For #21309: add profiler marker for onGlobalLayout #21311
Merged
3 tasks
@mergify mergify bot closed this as completed in #21311 Sep 16, 2021
Performance, front-end roadmap automation moved this from In progress to Done Sep 16, 2021
mergify bot pushed a commit that referenced this issue Sep 16, 2021
@mcomella @mergify
For #21309: remove outdated comment regarding async nav graph.
c251e4c
mergify bot pushed a commit that referenced this issue Sep 16, 2021
@mcomella @mergify
For #21309: set up HomeActivityBinding the recommended way.
cafc23a 
The recommended way is here:
https://developer.android.com/topic/libraries/view-binding

I was concerned with the existing implementation that binding was being
set conditionally.
mergify bot pushed a commit that referenced this issue Sep 16, 2021
@mcomella @mergify
For #21309: add profiler markers on global layout.
e6560c2
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Sep 17, 2021
@mcomella @pkirakosyan
For mozilla-mobile#21309: remove outdated comment regarding async nav…
6d6f17f 
… graph.
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Sep 17, 2021
@mcomella @pkirakosyan
For mozilla-mobile#21309: set up HomeActivityBinding the recommended …
800c680 
…way.

The recommended way is here:
https://developer.android.com/topic/libraries/view-binding

I was concerned with the existing implementation that binding was being
set conditionally.
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Sep 17, 2021
@mcomella @pkirakosyan
For mozilla-mobile#21309: add profiler markers on global layout.
26342f5
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcomella mcomella

Labels
needs:triage Issue needs triage performance Possible performance wins
Projects
Performance, front-end roadmap
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

For #21309: add profiler marker for onGlobalLayout mcomella/fenix
1 participant
@mcomella