Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Only show "Other" section if tab groups exist #21576

Closed
eliserichards opened this issue Sep 29, 2021 · 2 comments
Closed

Only show "Other" section if tab groups exist #21576

eliserichards opened this issue Sep 29, 2021 · 2 comments
Assignees
@jonalmeida
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:SearchTermTabs Tabs in the tabs tray that have the same search term. Feature:Tabs needs:triage Issue needs triage

Comments

@eliserichards
Copy link
Contributor

eliserichards commented Sep 29, 2021 •
edited by data-sync-user

If there is only one tab group -- "other" -- it should not be shown. If the user has one or more group in addition to "other", we can show it.

┆Issue is synchronized with this Jira Task
@eliserichards eliserichards added Feature:SearchTermTabs Tabs in the tabs tray that have the same search term. Feature:Tabs 🐞 bug Crashes, Something isn't working, .. labels Sep 29, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Sep 29, 2021
@jonalmeida jonalmeida self-assigned this Oct 2, 2021
jonalmeida added a commit to jonalmeida/fenix that referenced this issue Oct 2, 2021
@jonalmeida
Issue mozilla-mobile#21576: Hide 'Other' title when there are no sear…
910f3e1 
…ch groups
@pocmo
Copy link
Contributor

pocmo commented Oct 4, 2021

This is even more confusing if tab grouping is disabled (#21360) and all tabs are always "other tabs" :)

mergify bot pushed a commit that referenced this issue Oct 4, 2021
@jonalmeida @mergify
Issue #21576: Hide 'Other' title when there are no search groups
061de54
@jonalmeida jonalmeida added the eng:qa:needed QA Needed label Oct 4, 2021
@LaurentiuApahideanSV
Copy link

Verified as fixed on Firefox Preview Nightly 2021-10-05.

Devices used:

  • Oppo Find X3 (Android 11)
  • OnePlus 6T (Android 9)

@LaurentiuApahideanSV LaurentiuApahideanSV added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Oct 5, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@jonalmeida @pkirakosyan
Issue mozilla-mobile#21576: Hide 'Other' title when there are no sear…
42f0005 
…ch groups
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jonalmeida jonalmeida

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:SearchTermTabs Tabs in the tabs tray that have the same search term. Feature:Tabs needs:triage Issue needs triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pocmo @jonalmeida @eliserichards @LaurentiuApahideanSV