This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Bug]: Pocket stories horizontal shadows are clipped #21621
Labels
Comments
Mugurell
added
🐞 bug
Crashes, Something isn't working, ..
needs:triage
Issue needs triage
labels
Oct 1, 2021
After talking with Nicole about the fact that the "Recently bookmarked" section is not clipped and so it can show shadows but also extend to the edge of the screen when scrolled it might be worth to remove the 16dp padding from the list and have each child declare it's own. |
In the interim Nicole proposed adding a 4dp padding to the stories so that they'd have a bit of shadow. |
Mugurell
added this to Ready for Engineering (min-5 ; max-22)
in Android Engineering Team Kanban board
via automation
Oct 4, 2021
Mugurell
moved this from Ready for Engineering (min-5 ; max-22)
to In Development (WIP limit - 15)
in Android Engineering Team Kanban board
Oct 4, 2021
Mugurell
moved this from In Development (WIP limit - 15)
to Dev Complete (WIP limit - 5)
in Android Engineering Team Kanban board
Oct 4, 2021
mergify bot
pushed a commit
that referenced
this issue
Oct 5, 2021
Added from the ViewHolders, the same as for XML Views.
Mugurell
moved this from Dev Complete (WIP limit - 5)
to Reviewer approved, ready for test (WIP limit - ?)
in Android Engineering Team Kanban board
Oct 5, 2021
Verified as fixed on the latest Nightly (95.0a1 - 2021-10-06T05:11:35.245780) and on the latest Beta 94.0.0 beta1. Devices used:
Closing the ticket as verified. |
Android Engineering Team Kanban board
automation
moved this from Reviewer approved, ready for test (WIP limit - ?)
to Done
Oct 6, 2021
SoftVision-LorandJanos
added
eng:qa:verified
QA Verified
and removed
eng:qa:needed
QA Needed
labels
Oct 6, 2021
pkirakosyan
pushed a commit
to gexsi/user-agent-android
that referenced
this issue
Mar 7, 2022
pkirakosyan
pushed a commit
to gexsi/user-agent-android
that referenced
this issue
Mar 7, 2022
pkirakosyan
pushed a commit
to gexsi/user-agent-android
that referenced
this issue
Mar 7, 2022
… browsing home description
pkirakosyan
pushed a commit
to gexsi/user-agent-android
that referenced
this issue
Mar 7, 2022
…browsing home items
pkirakosyan
pushed a commit
to gexsi/user-agent-android
that referenced
this issue
Mar 7, 2022
…ables. Added from the ViewHolders, the same as for XML Views.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Steps to reproduce
App's homescreen - Pocket recommended stories section
Expected behaviour
Horizontal shadows should be shown the same as they do for the above recent tab items.
Actual behaviour
Horizontal shadows are clipped.
Device name
No response
Android version
All
Firefox release type
Firefox Nightly
Firefox version
Latest Nightly
Device logs
No response
Additional information
Based on https://issuetracker.google.com/issues/186318448#comment4 clipping main axis shadows is the expected behavior but maybe we can work around this.
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: