Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Fix some ktlint warnings from code inspection #21776

Closed
gabrielluong opened this issue Oct 7, 2021 · 0 comments · Fixed by #21778
Closed

Fix some ktlint warnings from code inspection #21776

gabrielluong opened this issue Oct 7, 2021 · 0 comments · Fixed by #21778
Assignees
@gabrielluong
Projects
Android Engineering Team Kanban board
Milestone
95

Comments

@gabrielluong
Copy link
Member

gabrielluong commented Oct 7, 2021 •
edited by data-sync-user
Loading

Run Analyze -> Code Inspection in Android Studio and fix up some ktlint warnings.

┆Issue is synchronized with this Jira Task
@gabrielluong gabrielluong self-assigned this Oct 7, 2021
@gabrielluong gabrielluong added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation Oct 7, 2021
@gabrielluong gabrielluong added this to the 95 milestone Oct 7, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Oct 7, 2021
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 7, 2021
@gabrielluong
For mozilla-mobile#21776 - Remove val from constructor parameter that…
4b28136 
… are never used as a property
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 7, 2021
@gabrielluong
For mozilla-mobile#21776 - Remove reductant 'suspend' modifier from S…
44861a1 
…ecurePrefsTelemetry
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 7, 2021
@gabrielluong
For mozilla-mobile#21776 - Remove reductant SAM constructor
22ef78e
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 7, 2021
@gabrielluong
For mozilla-mobile#21776 - Remove redundant qualifier name
b4696ef
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 7, 2021
@gabrielluong
For mozilla-mobile#21776 - Remove unnecessary parentheses from functi…
f3bf412 
…on call with lambda
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 7, 2021
@gabrielluong
For mozilla-mobile#21776 - Remove unnecessary type argument
8018730
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 7, 2021
@gabrielluong
For mozilla-mobile#21776 - Remove unused imports
2d11c64
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 7, 2021
@gabrielluong
For mozilla-mobile#21776 - Local 'var' is never modified and can be d…
dcf0a08 
…eclared as 'val'
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 7, 2021
@gabrielluong
For mozilla-mobile#21776 - 'protected' visibility is effectively 'pri…
6206f5b 
…vate' in a final class
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 7, 2021
@gabrielluong
For mozilla-mobile#21776 - Replace 'isEmpty' with 'ifEmpty'
d016d93
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 7, 2021
@gabrielluong
For mozilla-mobile#21776 - Replace Java static method with Kotlin analog
03ff6ba
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 7, 2021
@gabrielluong
For mozilla-mobile#21776 - Class member can have 'private' visibility
e44d423
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 7, 2021
@gabrielluong
For mozilla-mobile#21776 - Remove unused symbols
f02a2f0
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 7, 2021
@gabrielluong
For mozilla-mobile#21776 - Add package path to TabGroupViewHolder
947645e
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 7, 2021
@gabrielluong
For mozilla-mobile#21776 - Call chain on collection type may be simpl…
56dd1d4 
…ified
@gabrielluong gabrielluong mentioned this issue Oct 7, 2021
Merged
3 tasks
@gabrielluong gabrielluong moved this from Ready for Engineering (min-5 ; max-22) to Review in progress (WIP limit - 11) in Android Engineering Team Kanban board Oct 7, 2021
@gabrielluong gabrielluong removed the needs:triage Issue needs triage label Oct 7, 2021
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 7, 2021
@gabrielluong
For mozilla-mobile#21776 - Remove reductant SAM constructor
92dc756
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 7, 2021
@gabrielluong
For mozilla-mobile#21776 - Remove redundant qualifier name
f7c412e
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 7, 2021
@gabrielluong
For mozilla-mobile#21776 - Remove unnecessary parentheses from functi…
2baff7c 
…on call with lambda
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 7, 2021
@gabrielluong
For mozilla-mobile#21776 - Remove unnecessary type argument
d3bbf28
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 7, 2021
@gabrielluong
For mozilla-mobile#21776 - Remove unused imports
9f1338e
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 7, 2021
@gabrielluong
For mozilla-mobile#21776 - Local 'var' is never modified and can be d…
9a8db5c 
…eclared as 'val'
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 7, 2021
@gabrielluong
For mozilla-mobile#21776 - 'protected' visibility is effectively 'pri…
3b9d0ed 
…vate' in a final class
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 7, 2021
@gabrielluong
For mozilla-mobile#21776 - Replace 'isEmpty' with 'ifEmpty'
30bc327
mergify bot pushed a commit that referenced this issue Oct 26, 2021
@gabrielluong @mergify
For #21776 - Remove val from constructor parameter that are never use…
d854c28 
…d as a property
mergify bot pushed a commit that referenced this issue Oct 26, 2021
@gabrielluong @mergify
For #21776 - Remove reductant 'suspend' modifier from SecurePrefsTele…
ed48dc9 
…metry
mergify bot pushed a commit that referenced this issue Oct 26, 2021
@gabrielluong @mergify
For #21776 - Remove reductant SAM constructor
1039a92
mergify bot pushed a commit that referenced this issue Oct 26, 2021
@gabrielluong @mergify
For #21776 - Remove redundant qualifier name
6d1d4be
mergify bot pushed a commit that referenced this issue Oct 26, 2021
@gabrielluong @mergify
For #21776 - Remove unnecessary parentheses from function call with l…
272d31b 
…ambda
mergify bot pushed a commit that referenced this issue Oct 26, 2021
@gabrielluong @mergify
For #21776 - Remove unnecessary type argument
76c746b
mergify bot pushed a commit that referenced this issue Oct 26, 2021
@gabrielluong @mergify
For #21776 - Remove unused imports
5afe393
mergify bot pushed a commit that referenced this issue Oct 26, 2021
@gabrielluong @mergify
For #21776 - Local 'var' is never modified and can be declared as 'val'
da395d1
mergify bot pushed a commit that referenced this issue Oct 26, 2021
@gabrielluong @mergify
For #21776 - 'protected' visibility is effectively 'private' in a fin…
603ba63 
…al class
mergify bot pushed a commit that referenced this issue Oct 26, 2021
@gabrielluong @mergify
For #21776 - Replace 'isEmpty' with 'ifEmpty'
660300f
mergify bot pushed a commit that referenced this issue Oct 26, 2021
@gabrielluong @mergify
For #21776 - Replace Java static method with Kotlin analog
3115f13
mergify bot pushed a commit that referenced this issue Oct 26, 2021
@gabrielluong @mergify
For #21776 - Class member can have 'private' visibility
b54698a
mergify bot pushed a commit that referenced this issue Oct 26, 2021
@gabrielluong @mergify
For #21776 - Remove unused symbols
b04bf99
mergify bot pushed a commit that referenced this issue Oct 26, 2021
@gabrielluong @mergify
For #21776 - Add package path to TabGroupViewHolder
1005471
mergify bot pushed a commit that referenced this issue Oct 26, 2021
@gabrielluong @mergify
For #21776 - Call chain on collection type may be simplified
44666ca
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21776 - Remove val from constructor parameter that…
f145837 
… are never used as a property
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21776 - Remove reductant 'suspend' modifier from S…
8fec580 
…ecurePrefsTelemetry
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21776 - Remove reductant SAM constructor
ab5619c
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21776 - Remove redundant qualifier name
e994229
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21776 - Remove unnecessary parentheses from functi…
c028912 
…on call with lambda
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21776 - Remove unnecessary type argument
a25c8ac
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21776 - Remove unused imports
ee20965
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21776 - Local 'var' is never modified and can be d…
eb80f23 
…eclared as 'val'
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21776 - 'protected' visibility is effectively 'pri…
e4d55a7 
…vate' in a final class
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21776 - Replace 'isEmpty' with 'ifEmpty'
48f2641
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21776 - Replace Java static method with Kotlin analog
4929b67
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21776 - Class member can have 'private' visibility
44c0e0b
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21776 - Remove unused symbols
6fe464d
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21776 - Add package path to TabGroupViewHolder
16d5263
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21776 - Call chain on collection type may be simpl…
2cbd562 
…ified
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gabrielluong gabrielluong

Labels
None yet
Projects
No open projects
Android Engineering Team Kanban board
Done
Milestone
95
Development

Successfully merging a pull request may close this issue.

For #21776 - Fix some ktlint warnings from code inspection gabrielluong/fenix
1 participant
@gabrielluong