Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

MR2 Telemetry: Inactive tabs #21903

Closed
MozillaNoah opened this issue Oct 13, 2021 · 1 comment · Fixed by #21908 or #22071
Closed

MR2 Telemetry: Inactive tabs #21903

MozillaNoah opened this issue Oct 13, 2021 · 1 comment · Fixed by #21908 or #22071
Assignees
Labels
eng:qa:verified QA Verified Feature:InactiveTabs Tabs in the tabs tray that have not been used in some time. Feature:Telemetry
Milestone

Comments

@MozillaNoah
Copy link
Contributor

MozillaNoah commented Oct 13, 2021

https://mozilla-hub.atlassian.net/browse/FNXV2-18052

Add events for:

  • Opening an inactive tab
  • Deleting/closing all inactive tabs
  • Deleting/closing a single inactive tab
  • Whether the inactive tab section is showing
  • The count of inactive tabs
  • Toggling inactive tabs on/off in Settings

┆Issue is synchronized with this Jira Task

@MozillaNoah MozillaNoah added Feature:Telemetry Feature:InactiveTabs Tabs in the tabs tray that have not been used in some time. labels Oct 13, 2021
@MozillaNoah MozillaNoah self-assigned this Oct 13, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Oct 13, 2021
@MozillaNoah MozillaNoah removed the needs:triage Issue needs triage label Oct 13, 2021
@MozillaNoah MozillaNoah changed the title MR2 Telemtry: Inactive tabs MR2 Telemetry: Inactive tabs Oct 13, 2021
@MozillaNoah MozillaNoah added this to the 95 milestone Oct 20, 2021
mergify bot added a commit that referenced this issue Oct 20, 2021
* For #21903 - Added telemetry for interacting with inactive tabs

* For #21903 - Added missing inactive tab delete count event to delete all event

* For #21903 - Added PR numbers to metrics

* For #21903 - Updated broken unit tests. Resolved critical lint warning.

* For #21903 - Fixed inactive tabs setting toggle metric

* For #21903 - Updated FenixApp unit test

* For #21903 - Updated newline character in Metrics. Set inactive tab metrics' lifetime to default. Updated expiration to Nov 2022. Refactored inactive tabs metric to be a single metric.

* PR: addendum for last commit that missed a file

* For #21903 - Changed logic check for reporting inactive tab count

* PR: fixed merge conflict

* For #21903 - Removed tab close tracking when the user closes ALL inactive tabs

* For #21903 - Removed individual tab close metric verify from CLOSE ALL test

* For #21903 - Updated inactive tabs toggle setting expiration to match the expiration of the other events

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@MozillaNoah MozillaNoah added the eng:qa:needed QA Needed label Oct 20, 2021
mergify bot pushed a commit that referenced this issue Oct 20, 2021
* For #21903 - Added telemetry for interacting with inactive tabs

* For #21903 - Added missing inactive tab delete count event to delete all event

* For #21903 - Added PR numbers to metrics

* For #21903 - Updated broken unit tests. Resolved critical lint warning.

* For #21903 - Fixed inactive tabs setting toggle metric

* For #21903 - Updated FenixApp unit test

* For #21903 - Updated newline character in Metrics. Set inactive tab metrics' lifetime to default. Updated expiration to Nov 2022. Refactored inactive tabs metric to be a single metric.

* PR: addendum for last commit that missed a file

* For #21903 - Changed logic check for reporting inactive tab count

* PR: fixed merge conflict

* For #21903 - Removed tab close tracking when the user closes ALL inactive tabs

* For #21903 - Removed individual tab close metric verify from CLOSE ALL test

* For #21903 - Updated inactive tabs toggle setting expiration to match the expiration of the other events

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 8262494)

# Conflicts:
#	app/src/main/java/org/mozilla/fenix/tabstray/browser/NormalBrowserTrayList.kt
#	app/src/main/java/org/mozilla/fenix/tabstray/browser/TabSorter.kt
#	app/src/test/java/org/mozilla/fenix/tabstray/browser/TabSorterTest.kt
rocketsroger pushed a commit that referenced this issue Oct 21, 2021
* For #21903 - Added telemetry for interacting with inactive tabs

* For #21903 - Added missing inactive tab delete count event to delete all event

* For #21903 - Added PR numbers to metrics

* For #21903 - Updated broken unit tests. Resolved critical lint warning.

* For #21903 - Fixed inactive tabs setting toggle metric

* For #21903 - Updated FenixApp unit test

* For #21903 - Updated newline character in Metrics. Set inactive tab metrics' lifetime to default. Updated expiration to Nov 2022. Refactored inactive tabs metric to be a single metric.

* PR: addendum for last commit that missed a file

* For #21903 - Changed logic check for reporting inactive tab count

* PR: fixed merge conflict

* For #21903 - Removed tab close tracking when the user closes ALL inactive tabs

* For #21903 - Removed individual tab close metric verify from CLOSE ALL test

* For #21903 - Updated inactive tabs toggle setting expiration to match the expiration of the other events

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@lobontiumira
Copy link

Verified as fixed on the 10/25 Firefox Nightly 95.0a1 with Google Pixel (Android 10).
Glean dashboard

  • Opening an inactive tab:
 {
          "timestamp": 41573,
          "category": "tabs_tray",
          "name": "opened_existing_tab",
          "extra": {
            "source": "Inactive tabs"
          }
  • Deleting/closing all inactive tabs
 {
          "timestamp": 66710,
          "category": "tabs_tray",
          "name": "close_all_inactive_tabs"
        }
  • Deleting/closing a single inactive tab
 {
          "timestamp": 38998,
          "category": "tabs_tray",
          "name": "closed_existing_tab",
          "extra": {
            "source": "Inactive tabs"
          }
  • Whether the inactive tab section is showing & the count of inactive tabs
{
          "timestamp": 35736,
          "category": "tabs_tray",
          "name": "has_inactive_tabs",
          "extra": {
            "inactive_tabs_count": "6"
          }
  • Toggling inactive tabs on/off in Settings
{
          "timestamp": 7730,
          "category": "home_menu",
          "name": "settings_item_clicked"
        }
  • Expand / collapse the inactive tabs
{
          "timestamp": 64127,
          "category": "tabs_tray",
          "name": "inactive_tabs_collapsed"
        }
 {
          "timestamp": 65417,
          "category": "tabs_tray",
          "name": "inactive_tabs_expanded"
        }

@lobontiumira lobontiumira added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Oct 25, 2021
@MozillaNoah MozillaNoah modified the milestones: 95, 94 Oct 26, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
* For mozilla-mobile#21903 - Added telemetry for interacting with inactive tabs

* For mozilla-mobile#21903 - Added missing inactive tab delete count event to delete all event

* For mozilla-mobile#21903 - Added PR numbers to metrics

* For mozilla-mobile#21903 - Updated broken unit tests. Resolved critical lint warning.

* For mozilla-mobile#21903 - Fixed inactive tabs setting toggle metric

* For mozilla-mobile#21903 - Updated FenixApp unit test

* For mozilla-mobile#21903 - Updated newline character in Metrics. Set inactive tab metrics' lifetime to default. Updated expiration to Nov 2022. Refactored inactive tabs metric to be a single metric.

* PR: addendum for last commit that missed a file

* For mozilla-mobile#21903 - Changed logic check for reporting inactive tab count

* PR: fixed merge conflict

* For mozilla-mobile#21903 - Removed tab close tracking when the user closes ALL inactive tabs

* For mozilla-mobile#21903 - Removed individual tab close metric verify from CLOSE ALL test

* For mozilla-mobile#21903 - Updated inactive tabs toggle setting expiration to match the expiration of the other events

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:qa:verified QA Verified Feature:InactiveTabs Tabs in the tabs tray that have not been used in some time. Feature:Telemetry
Projects
None yet
2 participants