Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Add ability to change Firefox Preview (browser UI) language #220

Closed
1 of 3 tasks
bbinto opened this issue Jan 21, 2019 · 46 comments
Closed
1 of 3 tasks

Add ability to change Firefox Preview (browser UI) language #220

bbinto opened this issue Jan 21, 2019 · 46 comments
Assignees
Labels
E8 Estimation Point: about 8 days eng:qa:verified QA Verified eng:ready Ready for engineering Feature:FennecTransition 🌐 L10N Localization, translation, strings, .. needs:l10n Has strings that will require translation from the l10n team

Comments

@bbinto
Copy link
Contributor

bbinto commented Jan 21, 2019

Why/User Benefit/User Problem

As a user, I want to experience the app in a language other than the system / phone language

Deps

  • AC API for switching languages

Acceptance Criteria (how do I know when I’m done?)

  • I have the ability to change browser UI language separate from the system language
  • Browser language will follow the system language by default

Mocks: https://miro.com/app/board/o9J_kwN9u-I=/
SVG asset for Language icon: https://dzwonsemrish7.cloudfront.net/items/1j0I1L1E282t24241N0l/language.svg

NOT in this issue

This is just scoped to making the picker inside of Fenix, NOT inside AC

┆Issue is synchronized with this Jira Task

@bbinto bbinto added this to the MVP Metas milestone Jan 21, 2019
@bbinto bbinto added this to Unassigned in Fenix MVP Jan 25, 2019
@bbinto bbinto modified the milestones: MVP Metas, Backlog (After MVP) Jan 29, 2019
@bbinto bbinto removed this from Unassigned in Fenix MVP Jan 30, 2019
@vesta0 vesta0 removed the P2 Upcoming release label Mar 28, 2019
@vesta0 vesta0 changed the title [Meta] Change Browser Language Change Browser Language Apr 1, 2019
@vesta0 vesta0 added Feature:Settings 🌐 L10N Localization, translation, strings, .. P1 Current sprint labels Apr 1, 2019
@vesta0 vesta0 modified the milestones: MVP Backlog, MVP Metas Apr 3, 2019
@vesta0 vesta0 changed the title Change Browser Language [Meta] Change Browser Language Apr 3, 2019
@vesta0 vesta0 modified the milestones: MVP Metas, Post-MVP Metas Apr 4, 2019
@vesta0 vesta0 added this to Fenix 2.0 Milestone 2 (Q3) in Fenix Feature Requests Apr 4, 2019
@vesta0 vesta0 removed the P1 Current sprint label Apr 4, 2019
@cpeterso
Copy link

cpeterso commented Apr 18, 2019

Issue #940 confirmed that Fenix's app UI language changes correctly when the user changes the Android system language.

AFAICT, Chrome's Language settings only configure the user's preferred language for web content (i.e. the Accept-Language HTTP header sent to web servers), not Chrome's app UI language.

GV bug https://bugzilla.mozilla.org/show_bug.cgi?id=1543823 is about letting the browser customize Gecko's Accept-Language HTTP header and/or making Gecko use the Android system language.

UX question to consider:

  1. Assume Android system language is en-US.
  2. User changes Fenix's language setting to en-CA.
  3. User then changes the Android system language to en-GB.
  4. Should Fenix's language setting preserve its non-default setting (en-CA) or switch to new system language (en-GB)?

@yoasif
Copy link
Contributor

yoasif commented Apr 18, 2019

  1. Assume Android system language is en-US.
  2. User changes Fenix's language setting to en-CA.
  3. User then changes the Android system language to en-GB.
  4. Should Fenix's language setting preserve its non-default setting (en-CA) or switch to new system language (en-GB)?

It feels to me like Fenix should be en-GB and and websites should be en-CA unless Fenix implements separate website and browser UI preferences for language.

Also, FWIW, Chrome also allows users to set up several languages based on priority, while Fennec only allows users to select a single one (likely because the preference applies to both UI and websites).

@vesta0 vesta0 moved this from Post-MVP Milestone 2 Theme: Extend our global reach (support low connectivity areas and lower end devices) to Post-MVP Milestone 1 (Q3) Theme: deepter integration across Firefox products in Fenix Feature Requests Jun 6, 2019
@vesta0 vesta0 changed the title [Meta] Change Browser Language Change Browser Language Jun 7, 2019
@vesta0 vesta0 removed this from Post-MVP Milestone 1 (Q3) Theme: deepter integration across Firefox products in Fenix Feature Requests Jun 7, 2019
@vesta0 vesta0 moved this from Q1 2020 to Q2 2020 in Fenix Feature Maturity Mar 29, 2020
@vesta0 vesta0 added this to Usability in Fenix Q2 Feature Backlog Mar 29, 2020
@vesta0 vesta0 added this to Prioritized Feature Backlog in Fenix Sprint Kanban Mar 31, 2020
@liuche liuche removed this from Prioritized Feature Backlog in Fenix Sprint Kanban Mar 31, 2020
boek added a commit to boek/fenix that referenced this issue Apr 1, 2020
boek added a commit to boek/fenix that referenced this issue Apr 6, 2020
boek added a commit to boek/fenix that referenced this issue Apr 6, 2020
boek added a commit that referenced this issue Apr 6, 2020
* For #220 - Removes feature flag for language picker

* For #220 - Updates Android Components
@boek boek added the eng:qa:needed QA Needed label Apr 6, 2020
@boek boek self-assigned this Apr 6, 2020
@project-bot project-bot bot added this to Ready for QA in Fenix Sprint Kanban Apr 6, 2020
@liuche
Copy link
Contributor

liuche commented Apr 7, 2020

@boek will we have to wait for the new AC nightly version to be merged into Fenix? Not sure how to track, I'll add a comment to #9413

@boek
Copy link
Contributor

boek commented Apr 7, 2020

@liuche I updated a-c with this PR :)

@lobontiumira
Copy link

Verified that the user can:

  • change the language in Fenix to be different than the system's language,
  • follow the system's language,
  • change the language in Fenix with dark or light theme applied.

Tested with Google Pixel (Android 10), OnePlus 5T (Android 9), Sony Xperia Z5 Premium (Android 7.1.1), Samsung Galaxy Tab A6 (Android 5.1.1), and HTC 10 (Android 8) on the latest Nightly build from 4/8.

I'll remove the qa:needed label.

@liuche #9413 is not entirely fixed, should I leave this issue opened as well?

@lobontiumira lobontiumira removed the eng:qa:needed QA Needed label Apr 8, 2020
@project-bot project-bot bot moved this from Ready for QA to Sprint Backlog in Fenix Sprint Kanban Apr 8, 2020
@liuche
Copy link
Contributor

liuche commented Apr 10, 2020

Took a look at that other bug - thanks for filing and following up! For adding the language-switcher, I think we can fix that in release - it affects not all devices, but RTL support is important to get right. So I'll close this, and we can follow up in the other bug.

@liuche liuche closed this as completed Apr 10, 2020
@project-bot project-bot bot moved this from Sprint Backlog to Sprint 20.4 Done in Fenix Sprint Kanban Apr 10, 2020
@liuche liuche removed this from Usability, Reach, Connectedness in Fenix Q2 Feature Backlog Apr 13, 2020
@liuche liuche mentioned this issue Apr 13, 2020
32 tasks
@liuche liuche mentioned this issue Apr 28, 2020
32 tasks
@vesta0 vesta0 added this to Q2: Fenix in Fenix Product Backlog May 12, 2020
@data-sync-user data-sync-user changed the title Add ability to change Firefox Preview (browser UI) language FNX2-17753 ⁃ Add ability to change Firefox Preview (browser UI) language Aug 5, 2020
@data-sync-user data-sync-user changed the title FNX2-17753 ⁃ Add ability to change Firefox Preview (browser UI) language FNX3-16138 ⁃ Add ability to change Firefox Preview (browser UI) language Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-16138 ⁃ Add ability to change Firefox Preview (browser UI) language FNX-511 ⁃ Add ability to change Firefox Preview (browser UI) language Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-511 ⁃ Add ability to change Firefox Preview (browser UI) language Add ability to change Firefox Preview (browser UI) language May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E8 Estimation Point: about 8 days eng:qa:verified QA Verified eng:ready Ready for engineering Feature:FennecTransition 🌐 L10N Localization, translation, strings, .. needs:l10n Has strings that will require translation from the l10n team
Projects
Development

No branches or pull requests