Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to change Firefox Preview (browser UI) language #220

Open
bbinto opened this issue Jan 21, 2019 · 39 comments
Open

Add ability to change Firefox Preview (browser UI) language #220

bbinto opened this issue Jan 21, 2019 · 39 comments

Comments

@bbinto
Copy link
Contributor

@bbinto bbinto commented Jan 21, 2019

Why/User Benefit/User Problem

As a user, I want to experience the app in a language other than the system / phone language

Deps

  • AC API for switching languages

Acceptance Criteria (how do I know when I’m done?)

  • I have the ability to change browser UI language separate from the system language
  • Browser language will follow the system language by default

Mocks: https://miro.com/app/board/o9J_kwN9u-I=/
SVG asset for Language icon: https://dzwonsemrish7.cloudfront.net/items/1j0I1L1E282t24241N0l/language.svg

NOT in this issue

  • #6502 Allow webpage content language selection
  • expanding the locales we currently support #5496

This is just scoped to making the picker inside of Fenix, NOT inside AC

@bbinto bbinto added this to the MVP Metas milestone Jan 21, 2019
@bbinto bbinto added this to Unassigned in Fenix MVP Jan 25, 2019
@bbinto bbinto added the meta size S label Jan 25, 2019
@bbinto bbinto modified the milestones: MVP Metas, Backlog (After MVP) Jan 29, 2019
@bbinto bbinto removed this from Unassigned in Fenix MVP Jan 30, 2019
@vesta0 vesta0 removed the P2 label Mar 28, 2019
@vesta0 vesta0 changed the title [Meta] Change Browser Language Change Browser Language Apr 1, 2019
@vesta0 vesta0 modified the milestones: MVP Backlog, MVP Metas Apr 3, 2019
@vesta0 vesta0 changed the title Change Browser Language [Meta] Change Browser Language Apr 3, 2019
@vesta0 vesta0 modified the milestones: MVP Metas, Post-MVP Metas Apr 4, 2019
@vesta0 vesta0 added this to Fenix 2.0 Milestone 2 (Q3) in Fenix Roadmap Apr 4, 2019
@vesta0 vesta0 removed the P1 label Apr 4, 2019
@cpeterso

This comment has been minimized.

Copy link

@cpeterso cpeterso commented Apr 18, 2019

Issue #940 confirmed that Fenix's app UI language changes correctly when the user changes the Android system language.

AFAICT, Chrome's Language settings only configure the user's preferred language for web content (i.e. the Accept-Language HTTP header sent to web servers), not Chrome's app UI language.

GV bug https://bugzilla.mozilla.org/show_bug.cgi?id=1543823 is about letting the browser customize Gecko's Accept-Language HTTP header and/or making Gecko use the Android system language.

UX question to consider:

  1. Assume Android system language is en-US.
  2. User changes Fenix's language setting to en-CA.
  3. User then changes the Android system language to en-GB.
  4. Should Fenix's language setting preserve its non-default setting (en-CA) or switch to new system language (en-GB)?
@yoasif

This comment has been minimized.

Copy link

@yoasif yoasif commented Apr 18, 2019

  1. Assume Android system language is en-US.
  2. User changes Fenix's language setting to en-CA.
  3. User then changes the Android system language to en-GB.
  4. Should Fenix's language setting preserve its non-default setting (en-CA) or switch to new system language (en-GB)?

It feels to me like Fenix should be en-GB and and websites should be en-CA unless Fenix implements separate website and browser UI preferences for language.

Also, FWIW, Chrome also allows users to set up several languages based on priority, while Fennec only allows users to select a single one (likely because the preference applies to both UI and websites).

@kbrosnan kbrosnan removed the meta size S label Apr 27, 2019
@vesta0 vesta0 moved this from Post-MVP Milestone 2 Theme: Extend our global reach (support low connectivity areas and lower end devices) to Post-MVP Milestone 1 (Q3) Theme: deepter integration across Firefox products in Fenix Roadmap Jun 6, 2019
@vesta0 vesta0 changed the title [Meta] Change Browser Language Change Browser Language Jun 7, 2019
@vesta0 vesta0 removed this from Post-MVP Milestone 1 (Q3) Theme: deepter integration across Firefox products in Fenix Roadmap Jun 7, 2019
@cadeyrn

This comment has been minimized.

Copy link
Contributor

@cadeyrn cadeyrn commented Jan 10, 2020

The subsections from "Theme" & "Toolbar" aren't changed as per the language from Fenix.( are displayed as per the devices language & input setting)

On my device the exact opposite is true: These strings are (almost) the only strings using the Fenix and not the device language, see #7559 (comment). Interesting. 🤔

the problem is caused by the theme selection, namely if the user is using the dark theme, it will not work at all.

Oh, that's a good hint. There is also the opposite true for me: it only works with the dark and not with the light theme for me. 😅 I will test a bit more and update #7559 with my observations.

@Baron-Severin

This comment has been minimized.

Copy link
Contributor

@Baron-Severin Baron-Severin commented Jan 10, 2020

I checked in and it looks like @BranescuMihai will be back on Monday, so I'm going to leave this one to him.

@sv-ohorvath

This comment has been minimized.

Copy link
Contributor

@sv-ohorvath sv-ohorvath commented Jan 14, 2020

@Baron-Severin @BranescuMihai this landed on Beta 3.1.0 but it still has the issues mentioned above, not in a very good condition. Should we hide it until the bugs are fixed?

@liuche

This comment has been minimized.

Copy link
Member

@liuche liuche commented Jan 14, 2020

Yes, is it easy to hide that language picker setting, or make it Nightly only? @BranescuMihai could you open a PR for that, to make this Language Picker Nightly-only until these bugs and #7559 are fixed? That we can also uplift it into the Beta.

boek added a commit that referenced this issue Jan 16, 2020
liuche added a commit that referenced this issue Jan 17, 2020
@BranescuMihai BranescuMihai moved this from Sprint Backlog to In Progress in Fenix Sprint Kanban Jan 17, 2020
@liuche liuche added E8 and removed E5 labels Jan 17, 2020
@liuche liuche mentioned this issue Jan 22, 2020
20 of 32 tasks complete
@liuche

This comment has been minimized.

Copy link
Member

@liuche liuche commented Jan 22, 2020

@BranescuMihai when you have fixed the issues here, could you also remove the feature flag hiding the language picker?

@liuche liuche moved this from In Progress to Sprint Backlog in Fenix Sprint Kanban Jan 24, 2020
@liuche

This comment has been minimized.

Copy link
Member

@liuche liuche commented Jan 24, 2020

Putting this back into the sprint bc @BranescuMihai isn't available to work on this right now!

@BranescuMihai

This comment has been minimized.

Copy link
Contributor

@BranescuMihai BranescuMihai commented Jan 27, 2020

@liuche I'm back from medical leave, so I'll finish up those bugs

@Delphine

This comment has been minimized.

Copy link
Contributor

@Delphine Delphine commented Jan 28, 2020

I just tried the locale switcher on today's Nightly and it seems to work as expected :)
Maybe QA can do a thorough check and confirm?

@BranescuMihai BranescuMihai self-assigned this Jan 29, 2020
@gabrielluong gabrielluong moved this from Sprint Backlog to In Progress in Fenix Sprint Kanban Jan 30, 2020
@liuche

This comment has been minimized.

Copy link
Member

@liuche liuche commented Jan 31, 2020

Since this seems to be working on Nightly, and #7677 is already filed, sending this to QA. Let's file others as follow-ups if the main feature works.

@softvision-miralobontiu

This comment has been minimized.

Copy link

@softvision-miralobontiu softvision-miralobontiu commented Feb 3, 2020

Hi all,
I've tested on the latest Nightly build from 03/02 with Samsung Galaxy Note 8 (Android 9), and Google Pixel (Android 10), and this is not fixed yet.
On both devices I had dark themes applied.
The newly selected language was switched back to the system's language when the user selected the "Light" theme, instead of the "Dark" theme. Changing back to the "Dark" theme, the newly selected language was enabled again.

20200203

I will remove the eng:qa:needed label. Please let me know if I should file a new issue.
Thanks!

@cadeyrn

This comment has been minimized.

Copy link
Contributor

@cadeyrn cadeyrn commented Feb 3, 2020

Is your device theme dark? If yes, it's #7596 (it only works if system and Fenix theme are either both light or both dark).

edit: It has been fixed in latest build from master, should be in Nightly tomorrow.

@softvision-miralobontiu

This comment has been minimized.

Copy link

@softvision-miralobontiu softvision-miralobontiu commented Feb 4, 2020

Hi!
Verified as fixed on the latest Nightly build 200204 from 2/4, with Sony Xperia Z5 Premium (Android 7.1.1), and Google Pixel (Android 10).
I will set the proper label. Cannot close the issue, since it's blocked by #7677.

@project-bot project-bot bot moved this from In Progress to Sprint 20.2 Done in Fenix Sprint Kanban Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Fenix Roadmap
Mobile Reach
Fenix Sprint Kanban
  
Sprint 20.2 Done
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
You can’t perform that action at this time.