Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

MR2 telemetry: Recent searches (prev. recently visited) #22172

Closed
rocketsroger opened this issue Oct 26, 2021 · 4 comments · Fixed by #22173
Closed

MR2 telemetry: Recent searches (prev. recently visited) #22172

rocketsroger opened this issue Oct 26, 2021 · 4 comments · Fixed by #22173
Assignees
Labels
eng:qa:verified QA Verified needs:triage Issue needs triage
Milestone

Comments

@rocketsroger
Copy link
Contributor

rocketsroger commented Oct 26, 2021

Acceptance Criteria

Add telemetry for the following:

Metric Counter with extra: Number of times a search term group is clicked on from Recently visited

    Extra: what page is it on?

Metric boolean: Is the recently visited section visible

┆Issue is synchronized with this Jira Task

@rocketsroger rocketsroger self-assigned this Oct 26, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Oct 26, 2021
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Oct 26, 2021
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Oct 26, 2021
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Oct 26, 2021
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Oct 27, 2021
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Oct 28, 2021
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Nov 1, 2021
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Nov 1, 2021
@mergify mergify bot closed this as completed in 4e5c9a3 Nov 2, 2021
@rocketsroger rocketsroger added this to the 95 milestone Nov 2, 2021
@AndiAJ
Copy link
Collaborator

AndiAJ commented Nov 4, 2021

Hi @rocketsroger , I've just checked this matter on Firefox 95.0.0 Beta 1 using a OnePlus A3 (Android 6.0.1)

❓ Tap on recent searches from the home screen - Ping 3982d616-da17-420e-8f8a-e4ae5f1323c7
I have 3 recent searches on the home screen, and opened each of them one by one.
When the event type ping is generated it seems that the "page_number" remains set to 1

{
          "timestamp": 2314,
          "category": "history",
          "name": "recent_searches_tapped",
          "extra": {
            "page_number": "1"
          }
        },
        {
          "timestamp": 3424,
          "category": "home_screen",
          "name": "home_screen_displayed"
        },
        {
          "timestamp": 4289,
          "category": "history",
          "name": "recent_searches_tapped",
          "extra": {
            "page_number": "1"
          }
        },
        {
          "timestamp": 5141,
          "category": "home_screen",
          "name": "home_screen_displayed"
        },
        {
          "timestamp": 5791,
          "category": "history",
          "name": "recent_searches_tapped",
          "extra": {
            "page_number": "1"
          }
        }

✅ Recent searches enabled - Ping 9bb835d2-901c-4caf-98c6-b634cf34acaf
"customize_home.recently_visited": true

✅ Recent searches disabled - Ping 88388b8d-a823-4341-94f7-36d7fb7da632
"customize_home.recently_visited": false

Logcat
Glean dashboard

Please review and share your thoughts ☺️

@rocketsroger
Copy link
Contributor Author

Please review and share your thoughts ☺️

Yes, that is the correct behaviour. The page number is the column that the recent searches is on. So for searches number 1-3 they are on page 1. 4-6 are on page 2. 7-9 is on page 3. Try with 9 searches and you'll see the changes in the page number. Thanks,

@AndiAJ
Copy link
Collaborator

AndiAJ commented Nov 4, 2021

All good, thanks @rocketsroger !

       {
          "timestamp": 3355,
          "category": "history",
          "name": "recent_searches_tapped",
          "extra": {
            "page_number": "1"
          }
        {
          "timestamp": 6812,
          "category": "history",
          "name": "recent_searches_tapped",
          "extra": {
            "page_number": "2"
          }
        {
          "timestamp": 13440,
          "category": "history",
          "name": "recent_searches_tapped",
          "extra": {
            "page_number": "3"
          }

Logcat
Glean dashboard

@AndiAJ AndiAJ added the eng:qa:verified QA Verified label Nov 4, 2021
@rocketsroger
Copy link
Contributor Author

@AndiAJ Thanks!

mergify bot pushed a commit that referenced this issue Nov 4, 2021
(cherry picked from commit 4e5c9a3)

# Conflicts:
#	app/metrics.yaml
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Nov 8, 2021
@eliserichards eliserichards linked a pull request Dec 16, 2021 that will close this issue
3 tasks
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:qa:verified QA Verified needs:triage Issue needs triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants