Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

MR2 telemetry: Search term groups in history #22147

Closed
7 tasks
eliserichards opened this issue Oct 25, 2021 · 2 comments
Closed
7 tasks

MR2 telemetry: Search term groups in history #22147

eliserichards opened this issue Oct 25, 2021 · 2 comments

Comments

@eliserichards
Copy link
Contributor

eliserichards commented Oct 25, 2021

Description & Product Manager / Data Scientist User Story

What questions will you answer with this data?

Implement the following telemetry probes: (might be an incomplete list. check with product)

  • A user opens a search term group in history
  • A user opens a tab from the search term group
  • A user closes all tabs in the search term group
  • A user closes a single tab in the search term group

Acceptance Criteria

  • ENG files a DS JIRA request outlining their methodology.
  • DS sign off on instrumentation methodology addressing product questions.
  • Event pings can be queried via re:dash
  • Event pings can be queried via amplitude
  • We are sending telemetry events for the actions listed in the requirements
  • We have documented the telemetry
  • We have asked a data steward to review the telemetry

┆Issue is synchronized with this Jira Task

@github-actions github-actions bot added the needs:triage Issue needs triage label Oct 25, 2021
@Mugurell Mugurell self-assigned this Nov 4, 2021
@Mugurell Mugurell added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation Nov 4, 2021
@Mugurell Mugurell moved this from Ready for Engineering (min-5 ; max-22) to In Development (WIP limit - 15) in Android Engineering Team Kanban board Nov 4, 2021
@Mugurell
Copy link
Contributor

Mugurell commented Nov 8, 2021

Seems like we already have a probe knowing when a search group is opened - https://dictionary.telemetry.mozilla.org/apps/fenix/metrics/history_search_term_group_tapped
Asked Kimmy to confirm the other three.

@Mugurell Mugurell moved this from In Development (WIP limit - 15) to Dev Complete (WIP limit - 5) in Android Engineering Team Kanban board Nov 8, 2021
@amedyne amedyne removed the needs:triage Issue needs triage label Nov 8, 2021
mergify bot pushed a commit that referenced this issue Nov 16, 2021
@Mugurell Mugurell moved this from Dev Complete (WIP limit - 5) to Reviewer approved, ready for test (WIP limit - ?) in Android Engineering Team Kanban board Nov 17, 2021
@Mugurell Mugurell added the eng:qa:needed QA Needed label Nov 17, 2021
@AndiAJ
Copy link
Collaborator

AndiAJ commented Nov 19, 2021

Hi, verified as fixed on the latest Nightly build 96.0a1 from 11/19 using a Google Pixel 3a (Android 11)

✔️ A user opens a search term group in history (Previously done and checked in #22172) - Event Ping ac6c92f5-7ef7-4381-939e-3de638ab512c

{
          "timestamp": 4645,
          "category": "history",
          "name": "search_term_group_tapped"
        }

✔️ A user opens a tab from the search term group - Event Ping 7178208a-5338-4f91-94de-fbee9310ac64

{
          "timestamp": 1244,
          "category": "history",
          "name": "search_term_group_open_tab"
        }

✔️ A user closes all tabs in the search term group - Event Ping 7178208a-5338-4f91-94de-fbee9310ac64

{
          "timestamp": 14669,
          "category": "history",
          "name": "search_term_group_remove_all"
        }

✔️ A user closes a single tab in the search term group - Event Ping 7178208a-5338-4f91-94de-fbee9310ac64

{
          "timestamp": 13194,
          "category": "history",
          "name": "search_term_group_remove_tab"
        } 

Logcat
Glean dashboard

@AndiAJ AndiAJ closed this as completed Nov 19, 2021
Android Engineering Team Kanban board automation moved this from Reviewer approved, ready for test (WIP limit - ?) to Done Nov 19, 2021
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Nov 19, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

No branches or pull requests

4 participants