Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]: "Jump back in" and "Recent bookmarks" options are focused when tapping on "View" after creating a collection #22186

Closed
sflorean opened this issue Oct 27, 2021 · 2 comments · Fixed by #25609, fork-house/fenix#12 or Smaehtin/fenix#113
Closed

[Bug]: "Jump back in" and "Recent bookmarks" options are focused when tapping on "View" after creating a collection #22186

sflorean opened this issue Oct 27, 2021 · 2 comments · Fixed by #25609, fork-house/fenix#12 or Smaehtin/fenix#113
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Collections Feature:HomeScreen S3 Blocks non-critical functionality and a work around exists 🙅 waiting Issues that are blocked or has dependencies that are not ready
Milestone
104

Comments

@sflorean
Copy link
Contributor

sflorean commented Oct 27, 2021 •
edited by data-sync-user
Loading

Prerequisites

"Jump back in" and "Recent bookmarks" options are enabled on homescreen.

Steps to reproduce

  1. Open tabs tray and add a tab to collection 1.
  2. Tap on "View" from the snackbar.

Expected behaviour

The collection 1/new tab added is focused.

Actual behaviour

"Jump back in" and "Recent bookmarks" options are focused.

Device name

Pixel 3

Android version

Android 12

Firefox release type

Firefox Nightly

Firefox version

95.0a1, 94 Beta, 94.1.0

┆Issue is synchronized with this Jira Task
@sflorean sflorean added 🐞 bug Crashes, Something isn't working, .. needs:triage Issue needs triage Feature:Collections Feature:HomeScreen S3 Blocks non-critical functionality and a work around exists labels Oct 27, 2021
@amedyne amedyne removed the needs:triage Issue needs triage label Nov 1, 2021
@mcarare mcarare self-assigned this Jan 18, 2022
@mcarare mcarare added the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Jan 25, 2022
@mcarare
Copy link
Contributor

mcarare commented Jan 25, 2022

To be handled after the merging of home screen improvements refactoring.

@mcarare mcarare removed their assignment Apr 29, 2022
sarah541 added a commit to sarah541/fenix that referenced this issue Jun 14, 2022
@sarah541
For mozilla-mobile#22186 - Scroll to collection after creating one
1b16d45
@sarah541 sarah541 mentioned this issue Jun 14, 2022
Merged
3 tasks
sarah541 added a commit to sarah541/fenix that referenced this issue Jul 13, 2022
@sarah541
For mozilla-mobile#22186 - Scroll to collection after creating one
4abbbd1
@mergify mergify bot closed this as completed in #25609 Jul 19, 2022
mergify bot pushed a commit that referenced this issue Jul 19, 2022
@sarah541 @mergify
For #22186 - Scroll to collection after creating one
da4328e
@github-actions github-actions bot added this to the 104 milestone Jul 19, 2022
This was referenced Jul 19, 2022
Merged
Merged
@SoftVision-LorandJanos
Copy link

Verified as fixed on the latest Nightly 104.0a1 (2022-07-20) build.
Each time a new collection is created and "View" tapped, the focus is on the newly created collection.
Although the collection is focused, it's not expanded for the added pages to be visible.
Device used: Google Pixel 4 (Android 12).
Marking this as verified.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Collections Feature:HomeScreen S3 Blocks non-critical functionality and a work around exists 🙅 waiting Issues that are blocked or has dependencies that are not ready
Projects
None yet
Milestone
104
4 participants
@SoftVision-LorandJanos @mcarare @sflorean @amedyne