Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Use Hero images for Recent Bookmarks #22211

Closed
gabrielluong opened this issue Oct 28, 2021 · 1 comment · Fixed by #22294
Closed

Use Hero images for Recent Bookmarks #22211

gabrielluong opened this issue Oct 28, 2021 · 1 comment · Fixed by #22294
Assignees
@gabrielluong
Labels
eng:qa:verified QA Verified Feature:Bookmarks Feature:HomeScreen
Projects
Android Engineering Team Kanban board
Milestone
96

Comments

@gabrielluong
Copy link
Member

gabrielluong commented Oct 28, 2021 •
edited by data-sync-user

This adds a hero image (if it is available) for items in the "Recent bookmarks" section. Fallback to the favicon if no hero image is available for the site.

┆Issue is synchronized with this Jira Task
@gabrielluong gabrielluong self-assigned this Oct 28, 2021
@gabrielluong gabrielluong added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation Oct 28, 2021
@gabrielluong gabrielluong moved this from Ready for Engineering (min-5 ; max-22) to In Development (WIP limit - 15) in Android Engineering Team Kanban board Oct 28, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Oct 28, 2021
@gabrielluong gabrielluong removed the needs:triage Issue needs triage label Oct 29, 2021
@gabrielluong gabrielluong mentioned this issue Nov 1, 2021
Closed
@gabrielluong gabrielluong added this to the 96 milestone Nov 2, 2021
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Nov 3, 2021
@gabrielluong
For mozilla-mobile#22211 - Use Hero images for Recent Bookmarks
f3fd60b
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Nov 3, 2021
@gabrielluong
For mozilla-mobile#22211 - Use Hero images for Recent Bookmarks
8d7e4c0
@gabrielluong gabrielluong mentioned this issue Nov 4, 2021
Merged
3 tasks
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Nov 4, 2021
@gabrielluong
For mozilla-mobile#22211 - Use Hero images for Recent Bookmarks
5c9b83a
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Nov 4, 2021
@gabrielluong
For mozilla-mobile#22211 - Use Hero images for Recent Bookmarks
0565c6e
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Nov 4, 2021
@gabrielluong
For mozilla-mobile#22211 - Use Hero images for Recent Bookmarks
58a4dd5
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Nov 4, 2021
@gabrielluong
For mozilla-mobile#22211 - Use Hero images for Recent Bookmarks
bf81a9c
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Nov 24, 2021
@gabrielluong
For mozilla-mobile#22211 - Use Hero images for Recent Bookmarks
622c75b
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Nov 24, 2021
@gabrielluong
For mozilla-mobile#22211 - Use Hero images for Recent Bookmarks
af7ae8a
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Nov 25, 2021
@gabrielluong
For mozilla-mobile#22211 - Use Hero images for Recent Bookmarks
008fef4
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Nov 25, 2021
@gabrielluong
For mozilla-mobile#22211 - Use Hero images for Recent Bookmarks
2a508b8
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Nov 25, 2021
@gabrielluong
For mozilla-mobile#22211 - Use Hero images for Recent Bookmarks
73234bf
@mergify mergify bot closed this as completed in #22294 Nov 25, 2021
Android Engineering Team Kanban board automation moved this from In Development (WIP limit - 15) to Done Nov 25, 2021
mergify bot pushed a commit that referenced this issue Nov 25, 2021
@gabrielluong @mergify
For #22211 - Use Hero images for Recent Bookmarks
91da531
@gabrielluong gabrielluong reopened this Nov 26, 2021
Android Engineering Team Kanban board automation moved this from Done to In Development (WIP limit - 15) Nov 26, 2021
@gabrielluong gabrielluong added the eng:qa:needed QA Needed label Nov 26, 2021
@gabrielluong gabrielluong moved this from In Development (WIP limit - 15) to In Testing/QA in Android Engineering Team Kanban board Nov 26, 2021
@SoftVision-LorandJanos
Copy link

Verified as fixed on the latest Nightly 96.0a1 (2021-11-26).

Device used: Xiaomi Mi11 (Android 11).

Closing the ticket as fixed.

Android Engineering Team Kanban board automation moved this from In Testing/QA to Done Nov 26, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#22211 - Use Hero images for Recent Bookmarks
e9cfe09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gabrielluong gabrielluong

Labels
eng:qa:verified QA Verified Feature:Bookmarks Feature:HomeScreen
Projects
No open projects
Android Engineering Team Kanban board
Done
Milestone
96
Development

Successfully merging a pull request may close this issue.

For #22211 - Use Hero images for Recent Bookmarks gabrielluong/fenix
2 participants
@gabrielluong @SoftVision-LorandJanos