Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]: Tapping a search group item should switch to the previously opened website #22314

Closed
AndiAJ opened this issue Nov 4, 2021 · 1 comment
Closed

[Bug]: Tapping a search group item should switch to the previously opened website #22314

AndiAJ opened this issue Nov 4, 2021 · 1 comment
Assignees
@Mugurell
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:SearchGroupHistory Search term groups on History view needs:triage Issue needs triage S3 Blocks non-critical functionality and a work around exists
Projects
Android Engineering Team Kanban board

Comments

@AndiAJ
Copy link
Collaborator

AndiAJ commented Nov 4, 2021 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Search for a term
  2. Open one of the results
  3. Exit to the home screen
  4. Tap the search group
  5. Tap the item
  6. Check tab counter
  7. Open tabs tray
  8. Check open tabs

Expected behaviour

If the search group item is the same as the tab opened previously it should switch automatically to already existing tab

Actual behaviour

The search group item is opened in a new tab

Device name

OnePlus A3 Android 6.0.1

Firefox version

Firefox 95.0.0 Beta 1
Firefox Nightly 96 from 11/04

Additional information

► Video

20211104_144540.mp4

┆Issue is synchronized with this Jira Task
@AndiAJ AndiAJ added 🐞 bug Crashes, Something isn't working, .. needs:triage Issue needs triage Feature:SearchGroupHistory Search term groups on History view S3 Blocks non-critical functionality and a work around exists labels Nov 4, 2021
@Mugurell Mugurell self-assigned this Nov 9, 2021
@Mugurell Mugurell added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation Nov 9, 2021
@Mugurell Mugurell moved this from Ready for Engineering (min-5 ; max-22) to Dev Complete (WIP limit - 5) in Android Engineering Team Kanban board Nov 9, 2021
@Mugurell Mugurell mentioned this issue Nov 9, 2021
Merged
3 tasks
@Mugurell Mugurell moved this from Dev Complete (WIP limit - 5) to In Development (WIP limit - 15) in Android Engineering Team Kanban board Nov 9, 2021
@Mugurell Mugurell moved this from In Development (WIP limit - 15) to Dev Complete (WIP limit - 5) in Android Engineering Team Kanban board Nov 12, 2021
@Mugurell Mugurell mentioned this issue Nov 15, 2021
Closed
@Mugurell Mugurell moved this from Dev Complete (WIP limit - 5) to Reviewer approved, ready for test (WIP limit - ?) in Android Engineering Team Kanban board Jan 25, 2022
@Mugurell Mugurell added the eng:qa:needed QA Needed label Jan 25, 2022
mergify bot pushed a commit that referenced this issue Jan 25, 2022
@Mugurell @mergify
For #22314 - Reuse existing tab for search group items
5c1953d
@SoftVision-LorandJanos
Copy link

Verified as fixed on the latest Nightly 98.0a1 (2022-01-26).

Device used for testing:

  • Oppo Reno 6 (Android 11).
  • Google Pixel 4 (Android 12).

Closing the ticket as fixed.

Android Engineering Team Kanban board automation moved this from Reviewer approved, ready for test (WIP limit - ?) to Done Jan 26, 2022
@SoftVision-LorandJanos SoftVision-LorandJanos added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jan 26, 2022
@AndiAJ AndiAJ reopened this Feb 2, 2022
Android Engineering Team Kanban board automation moved this from Done to In Development (WIP limit - 15) Feb 2, 2022
@AndiAJ AndiAJ closed this as completed Feb 2, 2022
Android Engineering Team Kanban board automation moved this from In Development (WIP limit - 15) to Done Feb 2, 2022
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 9, 2022
@Mugurell @pkirakosyan
For mozilla-mobile#22314 - Reuse existing tab for search group items
bda2f89
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Mugurell Mugurell

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:SearchGroupHistory Search term groups on History view needs:triage Issue needs triage S3 Blocks non-critical functionality and a work around exists
Projects
No open projects
Android Engineering Team Kanban board
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Mugurell @SoftVision-LorandJanos @AndiAJ