Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Investigate removing Fennec -> Fenix migration code #22489

Closed
pocmo opened this issue Nov 18, 2021 · 3 comments · Fixed by #23651
Closed

Investigate removing Fennec -> Fenix migration code #22489

pocmo opened this issue Nov 18, 2021 · 3 comments · Fixed by #23651
Assignees
@grigoryk
Labels
Feature:Migration performance Possible performance wins
Projects
Performance, front-end roadmap
Milestone
100

Comments

@pocmo
Copy link
Contributor

pocmo commented Nov 18, 2021 •
edited by data-sync-user

We are contemplating removing the "Fennec to Fenix" migration code from Fenix. We shipped the first Fenix release with migration code over a year ago (~ Summer 2020). Removing the code will reduce the maintenance burden, improve performance (#15581) and reduce the APK size.
We still need to go through the process of looking at data, getting approval etc. - but that doesn't stop us from investigating the engineering work already.

┆Issue is synchronized with this Jira Task
@pocmo pocmo self-assigned this Nov 18, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Nov 18, 2021
@cadeyrn
Copy link
Contributor

cadeyrn commented Nov 18, 2021

Removing the code will reduce the maintenance burden, improve performance (#15581) and reduce the APK size.

@pocmo: Also the migration of passwords for users with master password can cause a crash: #22279. Removing the migration code would make fixing this crash obsolete.

@pocmo
Copy link
Contributor Author

pocmo commented Nov 18, 2021

@cadeyrn Great, thank you for mentioning that!

@pocmo pocmo mentioned this issue Nov 18, 2021
Closed
@philipwatmor

This comment was marked as spam.

Sign in to view
pocmo added a commit to pocmo/fenix that referenced this issue Nov 19, 2021
@pocmo
Issue mozilla-mobile#22489: Remove "Fennec to Fenix" migration code
70a5de6
@pocmo pocmo mentioned this issue Nov 19, 2021
Closed
pocmo added a commit to pocmo/fenix that referenced this issue Nov 22, 2021
@pocmo
Issue mozilla-mobile#22489: Remove "Fennec to Fenix" migration code
e081ed9
@pocmo pocmo removed their assignment Jan 10, 2022
@grigoryk grigoryk self-assigned this Jan 17, 2022
gabrielluong pushed a commit to gabrielluong/fenix that referenced this issue Feb 9, 2022
@pocmo @gabrielluong
Issue mozilla-mobile#22489: Remove "Fennec to Fenix" migration code
990faaf
@gabrielluong gabrielluong mentioned this issue Feb 9, 2022
Merged
3 tasks
@MarcLeclair MarcLeclair mentioned this issue Feb 9, 2022
Closed
@MarcLeclair MarcLeclair added the performance Possible performance wins label Feb 9, 2022
@MarcLeclair MarcLeclair added this to Needs triage in Performance, front-end roadmap via automation Feb 9, 2022
@gabrielluong gabrielluong removed the needs:triage Issue needs triage label Feb 10, 2022
@gabrielluong gabrielluong added this to the 99 milestone Feb 10, 2022
gabrielluong pushed a commit to gabrielluong/fenix that referenced this issue Feb 14, 2022
@pocmo @gabrielluong
Issue mozilla-mobile#22489: Remove "Fennec to Fenix" migration code
19181fa
@mcomella mcomella moved this from Needs triage to Perf P1 (unordered) in Performance, front-end roadmap Feb 16, 2022
grigoryk pushed a commit to gabrielluong/fenix that referenced this issue Feb 18, 2022
@pocmo @grigoryk
Issue mozilla-mobile#22489: Remove "Fennec to Fenix" migration code
24d6ac7
gabrielluong pushed a commit to gabrielluong/fenix that referenced this issue Feb 22, 2022
@pocmo @gabrielluong
Issue mozilla-mobile#22489: Remove "Fennec to Fenix" migration code
5b85943
gabrielluong pushed a commit to gabrielluong/fenix that referenced this issue Mar 1, 2022
@pocmo @gabrielluong
Issue mozilla-mobile#22489: Remove "Fennec to Fenix" migration code
6dc11cc
gabrielluong pushed a commit to gabrielluong/fenix that referenced this issue Mar 2, 2022
@pocmo @gabrielluong
Issue mozilla-mobile#22489: Remove "Fennec to Fenix" migration code
7712e1e
@gabrielluong gabrielluong removed this from the 99 milestone Mar 8, 2022
gabrielluong pushed a commit to gabrielluong/fenix that referenced this issue Mar 10, 2022
@pocmo @gabrielluong
Issue mozilla-mobile#22489: Remove "Fennec to Fenix" migration code
27e8dfe
gabrielluong pushed a commit to gabrielluong/fenix that referenced this issue Mar 11, 2022
@pocmo @gabrielluong
Issue mozilla-mobile#22489: Remove "Fennec to Fenix" migration code
a85ff7f
gabrielluong pushed a commit to gabrielluong/fenix that referenced this issue Mar 16, 2022
@pocmo @gabrielluong
Issue mozilla-mobile#22489: Remove "Fennec to Fenix" migration code
5c636df
gabrielluong pushed a commit to gabrielluong/fenix that referenced this issue Mar 16, 2022
@pocmo @gabrielluong
Issue mozilla-mobile#22489: Remove "Fennec to Fenix" migration code
b73b654
gabrielluong pushed a commit to gabrielluong/fenix that referenced this issue Mar 28, 2022
@pocmo @gabrielluong
Issue mozilla-mobile#22489: Remove "Fennec to Fenix" migration code
f26795c
gabrielluong pushed a commit to gabrielluong/fenix that referenced this issue Mar 28, 2022
@pocmo @gabrielluong
Issue mozilla-mobile#22489: Remove "Fennec to Fenix" migration code
126ce85
@gabrielluong gabrielluong added this to the 100 milestone Mar 28, 2022
@mergify mergify bot closed this as completed in #23651 Mar 28, 2022
Performance, front-end roadmap automation moved this from Perf P1 (unordered) to Done Mar 28, 2022
mergify bot pushed a commit that referenced this issue Mar 28, 2022
@pocmo @mergify
Issue #22489: Remove "Fennec to Fenix" migration code
834d0ee
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@grigoryk grigoryk

Labels
Feature:Migration performance Possible performance wins
Projects
Performance, front-end roadmap
Done
Milestone
100
Development

Successfully merging a pull request may close this issue.

Issue #22489: Remove "Fennec to Fenix" migration code gabrielluong/fenix
6 participants
@pocmo @grigoryk @cadeyrn @gabrielluong @MarcLeclair @philipwatmor