Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]: The "Remove" button has scrollable text when using holding gesture in "Recent searches" categories #22508

Closed
mariansima opened this issue Nov 19, 2021 · 1 comment
Closed

[Bug]: The "Remove" button has scrollable text when using holding gesture in "Recent searches" categories #22508

mariansima opened this issue Nov 19, 2021 · 1 comment
Assignees
@Mugurell
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:HomeScreen
Projects
Fenix Sprint Kanban

Comments

@mariansima
Copy link

mariansima commented Nov 19, 2021 •
edited by data-sync-user

Steps to reproduce

  1. Create some recent search categories on the app homepage
  2. Hold a finger down on a recent search group to display the contextual "Remove" button
  3. Hold down a finger on the "Remove" button
  4. Scroll up and down

Expected behaviour

The text inside the button is static

Actual behaviour

The text on the button can be scrolled up and down

video-1636037892.mp4

Device name

Samsung Galaxy A8

Android version

Android 9

Firefox release type

Firefox Nightly

Firefox version

96.0a1 2021-11-19

Device logs

No response

Additional information

No response

┆Issue is synchronized with this Jira Task
@mariansima mariansima added needs:triage Issue needs triage 🐞 bug Crashes, Something isn't working, .. labels Nov 19, 2021
@kbrosnan kbrosnan added Feature:HomeScreen and removed needs:triage Issue needs triage labels Dec 14, 2021
@Mugurell Mugurell self-assigned this Dec 16, 2021
@Mugurell Mugurell added this to In Progress in Fenix Sprint Kanban Dec 16, 2021
@Mugurell Mugurell moved this from In Progress to Ready for QA in Fenix Sprint Kanban Dec 17, 2021
@Mugurell Mugurell added the eng:qa:needed QA Needed label Dec 17, 2021
mergify bot pushed a commit that referenced this issue Dec 17, 2021
@Mugurell @mergify
For #22508 - Increase menu height to avoid it become scrollable
eb2ec67 
Compose enforces a DropdownMenuItem having at least a 64dp height
(48 dp height + 8dp vertical padding) so we need to ensure the parent
doesn't hardcode a smaller height.
@sflorean
Copy link
Contributor

Verified as fixed on latest Nightly build with Pixel 3 (Android 12).

Fenix Sprint Kanban automation moved this from Ready for QA to Sprint 20.11 Done Dec 20, 2021
@sflorean sflorean added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Dec 20, 2021
@project-bot project-bot bot moved this from Sprint 20.11 Done to Sprint in Fenix Sprint Kanban Dec 20, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 8, 2022
@Mugurell @pkirakosyan
For mozilla-mobile#22508 - Increase menu height to avoid it become sc…
3aa0036 
…rollable

Compose enforces a DropdownMenuItem having at least a 64dp height
(48 dp height + 8dp vertical padding) so we need to ensure the parent
doesn't hardcode a smaller height.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Mugurell Mugurell

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:HomeScreen
Projects
Fenix Sprint Kanban
  
Sprint
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kbrosnan @Mugurell @sflorean @mariansima