This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Refactor search term tab grouping logic to rely on middleware #22550
Labels
eng:health
Improve code health
Comments
csadilek
added a commit
to rocketsroger/fenix
that referenced
this issue
Dec 2, 2021
…to rely on middleware
csadilek
added a commit
to csadilek/fenix
that referenced
this issue
Dec 2, 2021
…to rely on middleware
3 tasks
rocketsroger
added a commit
to rocketsroger/fenix
that referenced
this issue
Dec 9, 2021
…to rely on middleware
rocketsroger
added a commit
to rocketsroger/fenix
that referenced
this issue
Dec 17, 2021
…to rely on middleware
rocketsroger
added a commit
to rocketsroger/fenix
that referenced
this issue
Dec 17, 2021
…to rely on middleware
rocketsroger
added a commit
to rocketsroger/fenix
that referenced
this issue
Jan 11, 2022
…to rely on middleware
rocketsroger
added a commit
to rocketsroger/fenix
that referenced
this issue
Jan 11, 2022
…to rely on middleware
rocketsroger
added a commit
to rocketsroger/fenix
that referenced
this issue
Jan 12, 2022
…to rely on middleware
rocketsroger
added a commit
to rocketsroger/fenix
that referenced
this issue
Jan 13, 2022
…to rely on middleware
rocketsroger
added a commit
to rocketsroger/fenix
that referenced
this issue
Jan 13, 2022
…to rely on middleware
pkirakosyan
pushed a commit
to gexsi/user-agent-android
that referenced
this issue
Mar 9, 2022
…to rely on middleware
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In mozilla-mobile/android-components#11272 we have added tab partitions/groups to
BrowserState
which will make it easier to represent the state of tab groups, as opposed to inferring those groups on demand.We will need to add a
middleware
to Fenix that manages the corresponding tab groups. A draft of what this would look like can be found in the RFC.The
middleware
will have to react to:SetHistoryMetadataKeyAction
to add a tab to the group or remove it in case the search terms got clearedDisbandSearchGroupAction
to remove the entire groupRestoreCompleteAction
to update the groups based on all restored tabs after startupRestoreTabAction
to put a tab back in its group e.g. when it was deleted and undo was triggered┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: