Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Refactor search term tab grouping logic to rely on middleware #22550

Closed
csadilek opened this issue Nov 23, 2021 · 1 comment
Closed

Refactor search term tab grouping logic to rely on middleware #22550

csadilek opened this issue Nov 23, 2021 · 1 comment
Labels
eng:health Improve code health

Comments

@csadilek
Copy link
Contributor

csadilek commented Nov 23, 2021

In mozilla-mobile/android-components#11272 we have added tab partitions/groups to BrowserState which will make it easier to represent the state of tab groups, as opposed to inferring those groups on demand.

We will need to add a middleware to Fenix that manages the corresponding tab groups. A draft of what this would look like can be found in the RFC.

The middleware will have to react to:

  • SetHistoryMetadataKeyAction to add a tab to the group or remove it in case the search terms got cleared
  • DisbandSearchGroupAction to remove the entire group
  • RestoreCompleteAction to update the groups based on all restored tabs after startup
  • RestoreTabAction to put a tab back in its group e.g. when it was deleted and undo was triggered

┆Issue is synchronized with this Jira Task

@csadilek csadilek added the eng:health Improve code health label Nov 23, 2021
@csadilek
Copy link
Contributor Author

@github-actions github-actions bot added the needs:triage Issue needs triage label Nov 23, 2021
@csadilek csadilek removed the needs:triage Issue needs triage label Nov 23, 2021
csadilek added a commit to rocketsroger/fenix that referenced this issue Dec 2, 2021
csadilek added a commit to csadilek/fenix that referenced this issue Dec 2, 2021
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Dec 9, 2021
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Dec 17, 2021
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Dec 17, 2021
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Jan 11, 2022
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Jan 11, 2022
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Jan 12, 2022
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Jan 13, 2022
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Jan 13, 2022
@mergify mergify bot closed this as completed in 047ec89 Jan 13, 2022
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:health Improve code health
Projects
None yet
Development

No branches or pull requests

1 participant