This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Closes #11208: Add tab partitions and groups to BrowserState #11272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csadilek
commented
Nov 15, 2021
...ents/browser/state/src/main/java/mozilla/components/browser/state/reducer/TabGroupReducer.kt
Show resolved
Hide resolved
csadilek
commented
Nov 15, 2021
...nents/browser/state/src/main/java/mozilla/components/browser/state/reducer/TabListReducer.kt
Show resolved
Hide resolved
pocmo
approved these changes
Nov 16, 2021
...nents/browser/state/src/main/java/mozilla/components/browser/state/reducer/TabListReducer.kt
Show resolved
Hide resolved
csadilek
force-pushed
the
issue-11208
branch
2 times, most recently
from
51c068f
to
1ccb8c1
Compare
|
@pocmo @Amejia481 OK, added lots of tests and additional validation to make sure we throw an exception if a tab is added that doesn't exist. /cc @rocketsroger @jonalmeida in case you want to take a look as well before this lands, but no changes relative to the RFC. |
csadilek
force-pushed
the
issue-11208
branch
from
1ccb8c1
to
5579442
Compare
jonalmeida
approved these changes
Nov 22, 2021
This was referenced Nov 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of our RFC. Besides state and actions the only complexity added here is to automatically create the groups/partitions, as needed, and discussed in the RFC to simplify usage for consuming applications. The other piece is to make sure partitions are automatically cleaned up when tabs are removed.
Tests are on the way, but putting up for (early) review.