Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Update inactive tabs colors on tab tray when in private browsing #22558

Closed
topotropic opened this issue Nov 23, 2021 · 3 comments · Fixed by #26376, fork-house/fenix#12 or nathanmkaya/fenix#108
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:InactiveTabs Tabs in the tabs tray that have not been used in some time. Feature:Tabs
Milestone

Comments

@topotropic
Copy link

topotropic commented Nov 23, 2021

Steps to reproduce

Visit a site in private mode and switch to non-private mode

Expected behaviour

Headlines and "inactive tabs" section have correct colors (what we currently have in non-private mode)

Actual behaviour

Headlines are white, inactive tabs section has accent color background

Device name

No response

Android version

Android 12

Firefox release type

Firefox Nightly

Firefox version

96

Device logs

No response

Additional information

No response

┆Issue is synchronized with this Jira Task

@topotropic topotropic added 🐞 bug Crashes, Something isn't working, .. needs:triage Issue needs triage labels Nov 23, 2021
@jonalmeida jonalmeida added Feature:InactiveTabs Tabs in the tabs tray that have not been used in some time. and removed needs:triage Issue needs triage labels Nov 23, 2021
@jonalmeida jonalmeida changed the title Update colors on tab tray Update inactive tabs colors on tab tray when in private browsing Nov 23, 2021
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Dec 16, 2021
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Dec 16, 2021
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Dec 17, 2021
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Dec 22, 2021
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Dec 22, 2021
@rocketsroger
Copy link
Contributor

This is dependent on #21897

@MozillaNoah MozillaNoah self-assigned this Aug 4, 2022
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Aug 8, 2022
@mergify mergify bot closed this as completed in #26376 Aug 9, 2022
mergify bot pushed a commit that referenced this issue Aug 9, 2022
@github-actions github-actions bot added this to the 105 milestone Aug 9, 2022
@github-actions github-actions bot reopened this Aug 9, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Aug 9, 2022
@delia-pop
Copy link

delia-pop commented Aug 11, 2022

Verified as fixed on latest Nightly 105 from 08/10. The inactive tabs no longer display the private mode color.

However, @MozillaNoah please note that other items on the tabs tray are still affected: the collection prompt (issue #22012 (comment)) and new tabs thumbnail images (issues #25977 (comment), #19226, #11421).

@delia-pop delia-pop added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Aug 11, 2022
@MozillaNoah
Copy link
Contributor

Thanks @delia-pop for posting your findings! I'll close this specific issue now then since there are other issues already to track those separate visual bugs. The others will be deferred until the rest of the tabs tray has been converted over to Compose, our new UI system, where it will just be one top-level change to resolve any more private theming issues.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:InactiveTabs Tabs in the tabs tray that have not been used in some time. Feature:Tabs
Projects
None yet
5 participants