Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Add new color tokens provided by the design systems to FirefoxTheme #22637

Closed
gabrielluong opened this issue Nov 30, 2021 · 0 comments · Fixed by #22666
Closed

Add new color tokens provided by the design systems to FirefoxTheme #22637

gabrielluong opened this issue Nov 30, 2021 · 0 comments · Fixed by #22666
Assignees
@gabrielluong
Labels
Feature:Themes Dark mode, light mode, private browsing mode
Projects
Android Engineering Team Kanban board
Milestone
96

Comments

@gabrielluong
Copy link
Member

gabrielluong commented Nov 30, 2021 •
edited by data-sync-user

We have some new design color tokens that are part of the mobile design system that we can add to FirefoxTheme that can be used in our @composables.

┆Issue is synchronized with this Jira Task
@gabrielluong gabrielluong self-assigned this Nov 30, 2021
@gabrielluong gabrielluong added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation Nov 30, 2021
@gabrielluong gabrielluong moved this from Ready for Engineering (min-5 ; max-22) to In Development (WIP limit - 15) in Android Engineering Team Kanban board Nov 30, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Nov 30, 2021
@gabrielluong gabrielluong removed the needs:triage Issue needs triage label Nov 30, 2021
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Dec 2, 2021
@gabrielluong
For mozilla-mobile#22637 - Add new color tokens provided by the mobil…
c2fda88 
…e styles to FirefoxTheme
@gabrielluong gabrielluong mentioned this issue Dec 2, 2021
Merged
3 tasks
@gabrielluong gabrielluong added this to the 96 milestone Dec 2, 2021
@gabrielluong gabrielluong moved this from In Development (WIP limit - 15) to Reviewer approved, ready for test (WIP limit - ?) in Android Engineering Team Kanban board Dec 2, 2021
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Dec 2, 2021
@gabrielluong
For mozilla-mobile#22637 - Add new color tokens provided by the mobil…
ff14107 
…e styles to FirefoxTheme
@gabrielluong gabrielluong mentioned this issue Dec 2, 2021
Closed
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Dec 2, 2021
@gabrielluong
For mozilla-mobile#22637 - Add new color tokens provided by the mobil…
3c7da08 
…e styles to FirefoxTheme
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Dec 2, 2021
@gabrielluong
For mozilla-mobile#22637 - Add new color tokens provided by the mobil…
3157305 
…e styles to FirefoxTheme
@mergify mergify bot closed this as completed in #22666 Dec 3, 2021
Android Engineering Team Kanban board automation moved this from Reviewer approved, ready for test (WIP limit - ?) to Done Dec 3, 2021
mergify bot pushed a commit that referenced this issue Dec 3, 2021
@gabrielluong @mergify
For #22637 - Add new color tokens provided by the mobile styles to Fi…
e20ef25 
…refoxTheme
@gabrielluong gabrielluong added the Feature:Themes Dark mode, light mode, private browsing mode label Dec 15, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#22637 - Add new color tokens provided by the mobil…
6ba129e 
…e styles to FirefoxTheme
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gabrielluong gabrielluong

Labels
Feature:Themes Dark mode, light mode, private browsing mode
Projects
No open projects
Android Engineering Team Kanban board
Done
Milestone
96
Development

Successfully merging a pull request may close this issue.

For #22637 - Add new color tokens provided by the mobile styles to FirefoxTheme gabrielluong/fenix
1 participant
@gabrielluong