Allow to change the home screen background by tapping on the firefox logo

[Amejia481]

┆Issue is synchronized with this Jira Task

[sheikh-azharuddin]

Nice implementation 👍
These 2 backgrounds color have issue with the text color ...

[pocmo]

@Amejia481 Two suggestions:

• I found the commit and this issue by looking at the APK size graphs and saw a bump, which seems to be coming from the new wallpaper PNGs. Did you run them through ImageOptim? It looks like we could optimize them.
• I'd consider adding such state either to the screen or app store (based on whether it's needed locally only or globally) and using the known mechanisms to update/observe state. Every *Manager creates another source of truth/state and will make it harder to reason about the app's state.

[Amejia481]

👋🏽 thanks for the suggestions.

Did you run them through ImageOptim?

No I didn't, but I will do :) . These images are the final ones, they are only for gathering feedback about the feature, while we get the final ones.

I'd consider adding such state either to the screen or app store (based on whether it's needed locally only or globally) and using the known mechanisms to update/observe state. Every *Manager creates another source of truth/state and will make it harder to reason about the app's state.

Yeah that make sense 👍🏽

[Amejia481]

@pocmo I filed #22937 for addressing the images optimization.

[delia-pop]

Verified as fixed on Beta 99.0.0-beta.5, Nightly 100.0a1. and RC 98.3.0.