Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Set all @color/tab_tray_item_media_stroke usage to @color/photonWhite #22858

Closed
gabrielluong opened this issue Dec 14, 2021 · 0 comments · Fixed by #22859
Closed

Set all @color/tab_tray_item_media_stroke usage to @color/photonWhite #22858

gabrielluong opened this issue Dec 14, 2021 · 0 comments · Fixed by #22859
Assignees
@gabrielluong
Labels
Feature:Themes Dark mode, light mode, private browsing mode
Projects
Android Engineering Team Kanban board
Milestone
97

Comments

@gabrielluong
Copy link
Member

gabrielluong commented Dec 14, 2021 •
edited by data-sync-user
Loading

Let's remove @color/tab_tray_item_media_stroke and simply inline @color/photonWhite where it is used. I don't think we need to keep tab_tray_item_media_stroke as a color variable since the color is static in the icons that uses it.

┆Issue is synchronized with this Jira Task
@gabrielluong gabrielluong self-assigned this Dec 14, 2021
@gabrielluong gabrielluong added the Feature:Themes Dark mode, light mode, private browsing mode label Dec 14, 2021
@gabrielluong gabrielluong added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation Dec 14, 2021
@gabrielluong gabrielluong added this to the 97 milestone Dec 14, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Dec 14, 2021
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Dec 14, 2021
@gabrielluong
For mozilla-mobile#22858 - Set all @color/tab_tray_item_media_stroke …
d70a27a 
…usages to @color/photonWhite
@gabrielluong gabrielluong mentioned this issue Dec 14, 2021
Merged
3 tasks
@mergify mergify bot closed this as completed in #22859 Dec 14, 2021
Android Engineering Team Kanban board automation moved this from Ready for Engineering (min-5 ; max-22) to Done Dec 14, 2021
mergify bot pushed a commit that referenced this issue Dec 14, 2021
@gabrielluong @mergify
For #22858 - Set all @color/tab_tray_item_media_stroke usages to @col…
9e647fd 
…or/photonWhite
@gabrielluong gabrielluong removed the needs:triage Issue needs triage label Dec 15, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 8, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#22858 - Set all @color/tab_tray_item_media_stroke …
bbb9ff6 
…usages to @color/photonWhite
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gabrielluong gabrielluong

Labels
Feature:Themes Dark mode, light mode, private browsing mode
Projects
No open projects
Android Engineering Team Kanban board
Done
Milestone
97
1 participant
@gabrielluong