Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Align detekt config between Fenix and Android Components #23046

Closed
gabrielluong opened this issue Jan 3, 2022 · 0 comments · Fixed by #23112
Closed

Align detekt config between Fenix and Android Components #23046

gabrielluong opened this issue Jan 3, 2022 · 0 comments · Fixed by #23112
Assignees
@gabrielluong
Labels
eng:health Improve code health
Projects
Android Engineering Team Kanban board

Comments

@gabrielluong
Copy link
Member

gabrielluong commented Jan 3, 2022 •
edited by data-sync-user
Loading

I am somewhat shocked that ktlint didn't complain about how there's no kDoc for public functions

It's disabled in detekt here:
https://github.com/mozilla-mobile/fenix/blob/main/config/detekt.yml#L43

But enabled in A-C:
https://github.com/mozilla-mobile/android-components/blob/main/config/detekt.yml#L37

🤷‍♂️

Originally posted by @pocmo in #22953 (comment)

┆Issue is synchronized with this Jira Task
@gabrielluong gabrielluong self-assigned this Jan 3, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Jan 3, 2022
@gabrielluong gabrielluong mentioned this issue Jan 3, 2022
Closed
3 tasks
@gabrielluong gabrielluong added eng:health Improve code health and removed needs:triage Issue needs triage labels Jan 3, 2022
@gabrielluong gabrielluong added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation Jan 3, 2022
@gabrielluong gabrielluong moved this from Ready for Engineering (min-5 ; max-22) to In Development (WIP limit - 15) in Android Engineering Team Kanban board Jan 3, 2022
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jan 7, 2022
@gabrielluong
For mozilla-mobile#23046 - Align detekt config between Fenix and Andr…
97fee6a 
…oid Components
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Mar 25, 2022
@gabrielluong
For mozilla-mobile#23046 - Align detekt config between Fenix and Andr…
255bde9 
…oid Components

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
@gabrielluong gabrielluong mentioned this issue Mar 25, 2022
Merged
3 tasks
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Mar 28, 2022
@gabrielluong
For mozilla-mobile#23046 - Align detekt config between Fenix and Andr…
b20d865 
…oid Components

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Mar 28, 2022
@gabrielluong
For mozilla-mobile#23046 - Align detekt config between Fenix and Andr…
3e00ca0 
…oid Components

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Mar 28, 2022
@gabrielluong
For mozilla-mobile#23046 - Align detekt config between Fenix and Andr…
475f506 
…oid Components

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Mar 28, 2022
@gabrielluong
For mozilla-mobile#23046 - Align detekt config between Fenix and Andr…
612f385 
…oid Components

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
@mergify mergify bot closed this as completed in #23112 Mar 29, 2022
Android Engineering Team Kanban board automation moved this from In Development (WIP limit - 15) to Done Mar 29, 2022
mergify bot pushed a commit that referenced this issue Mar 29, 2022
@gabrielluong @mergify
For #23046 - Align detekt config between Fenix and Android Components
1f633ed 
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gabrielluong gabrielluong

Labels
eng:health Improve code health
Projects
No open projects
Android Engineering Team Kanban board
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

For #23046 - Align detekt config between Fenix and Android Components gabrielluong/fenix
1 participant
@gabrielluong