Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Favicons for synced tabs #23219

Closed
topotropic opened this issue Jan 14, 2022 · 1 comment · Fixed by #24176
Closed

Favicons for synced tabs #23219

topotropic opened this issue Jan 14, 2022 · 1 comment · Fixed by #24176
Assignees
@MozillaNoah
Labels
eng:ready Ready for engineering Feature:SyncTabs Sync tabs TaskContinuity https://mozilla-hub.atlassian.net/browse/FNXV2-19368
Projects
Android Engineering Team Kanban board

Comments

@topotropic
Copy link

topotropic commented Jan 14, 2022 •
edited by data-sync-user

Display favicons for synced tabs to make it easier to recognize sites.

Figma

┆Issue is synchronized with this Jira Task
@topotropic topotropic added Feature:SyncTabs Sync tabs eng:ready Ready for engineering labels Jan 14, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Jan 14, 2022
@MozillaNoah MozillaNoah removed the needs:triage Issue needs triage label Jan 14, 2022
@jonalmeida
Copy link
Contributor

We need to also fix mozilla-mobile/android-components#5179 if we want our favicons to show up in desktop too.

@MozillaNoah MozillaNoah self-assigned this Jan 21, 2022
@MozillaNoah MozillaNoah added the TaskContinuity https://mozilla-hub.atlassian.net/browse/FNXV2-19368 label Feb 17, 2022
@MozillaNoah MozillaNoah added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation Feb 23, 2022
@MozillaNoah MozillaNoah moved this from Ready for Engineering (min-5 ; max-22) to In Development (WIP limit - 15) in Android Engineering Team Kanban board Feb 23, 2022
@MozillaNoah MozillaNoah mentioned this issue Mar 9, 2022
Merged
3 tasks
@MozillaNoah MozillaNoah moved this from In Development (WIP limit - 15) to Review in progress (WIP limit - 11) in Android Engineering Team Kanban board Mar 9, 2022
@mergify mergify bot closed this as completed in #24176 Mar 11, 2022
Android Engineering Team Kanban board automation moved this from Review in progress (WIP limit - 11) to Done Mar 11, 2022
mergify bot pushed a commit that referenced this issue Mar 11, 2022
@MozillaNoah @mergify
For #23219 - Add favicons to synced tabs list
2ea99c9
pedroldk pushed a commit to pedroldk/fenix that referenced this issue Mar 22, 2022
@MozillaNoah @pedroldk
For mozilla-mobile#23219 - Add favicons to synced tabs list
8b5977d
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MozillaNoah MozillaNoah

Labels
eng:ready Ready for engineering Feature:SyncTabs Sync tabs TaskContinuity https://mozilla-hub.atlassian.net/browse/FNXV2-19368
Projects
No open projects
Android Engineering Team Kanban board
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

For #23219 - Add favicons to synced tabs list MozillaNoah/fenix
3 participants
@topotropic @jonalmeida @MozillaNoah