Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Wallpaper settings screen should be scrollable #23662

Closed
MatthewTighe opened this issue Feb 9, 2022 · 1 comment
Closed

Wallpaper settings screen should be scrollable #23662

MatthewTighe opened this issue Feb 9, 2022 · 1 comment
Assignees
@MatthewTighe
Labels
eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Wallpapers

Comments

@MatthewTighe
Copy link
Contributor

MatthewTighe commented Feb 9, 2022 •
edited by data-sync-user
Loading

The wallpaper settings screen is not currently scrollable. In landscape mode, this can cut off the logo switch and the text describing the switch. Update the settings screen to be scrollable.

┆Issue is synchronized with this Jira Task
@MatthewTighe MatthewTighe added eng:ready Ready for engineering Feature:Wallpapers labels Feb 9, 2022
@MatthewTighe MatthewTighe self-assigned this Feb 9, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Feb 9, 2022
@MatthewTighe MatthewTighe removed the needs:triage Issue needs triage label Feb 9, 2022
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Feb 9, 2022
@MatthewTighe
closes mozilla-mobile#23662: replace wallpaper thumbnail lazyvertical…
d8bd798 
…grid with manual scroll layout
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Feb 9, 2022
@MatthewTighe
closes mozilla-mobile#23662: replace wallpaper thumbnail lazyvertical…
8e72dc0 
…grid with manual scroll layout
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Feb 14, 2022
@MatthewTighe
closes mozilla-mobile#23662: replace wallpaper thumbnail lazyvertical…
edb9a69 
…grid with manual scroll layout
@mergify mergify bot closed this as completed in f146cef Feb 14, 2022
mergify bot pushed a commit that referenced this issue Feb 15, 2022
@MatthewTighe
closes #23662: replace wallpaper thumbnail lazyverticalgrid with manu…
8dc0b36 
…al scroll layout

(cherry picked from commit f146cef)
jcristau pushed a commit that referenced this issue Feb 15, 2022
@MatthewTighe
closes #23662: replace wallpaper thumbnail lazyverticalgrid with manu…
75a2251 
…al scroll layout

(cherry picked from commit f146cef)
MatthewTighe added a commit that referenced this issue Feb 15, 2022
@mergify @MatthewTighe
closes #23662: replace wallpaper thumbnail lazyverticalgrid with manu…
f1f8038 
…al scroll layout (#23760)

(cherry picked from commit f146cef)

Co-authored-by: Matt Tighe <mtighe@mozilla.com>
@sflorean
Copy link
Contributor

sflorean commented Mar 9, 2022

Verified as fixed on Beta 99.0.0-beta.1 and Nightly 100.0a1.

@sflorean sflorean added the eng:qa:verified QA Verified label Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MatthewTighe MatthewTighe

Labels
eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Wallpapers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MatthewTighe @sflorean