Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]: The pinned top sites and sponsored tiles are still available after disabling the "Shortcuts" option #24130

Closed
SoftVision-CosminMuntean opened this issue Mar 7, 2022 · 2 comments · Fixed by #24218
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Shortcuts Top Sites/Topsites on the Firefox home page S3 Blocks non-critical functionality and a work around exists
Milestone

Comments

@SoftVision-CosminMuntean
Copy link

SoftVision-CosminMuntean commented Mar 7, 2022

Prerequisites:

  • Have at least one pinned top site available.
  • Have at least one sponsored tile available.

Steps to reproduce

  1. Open the Nightly browser.
  2. Tab the "Hamburger" menu.
  3. Tap the "Customize homepage.
  4. Disable the "Shortcuts" option.
  5. Return to the homepage and observe the top sites section.

Expected behaviour

  • The top sites section is no longer displayed.

Actual behaviour

  • The pinned top sites and the Sponsored tiles are still available.

Device name

One Plus 8 Pro

Android version

Android 11

Firefox release type

Firefox Nightly

Firefox version

99.0a1

Device logs

No response

Additional information

  • Only the history tiles disappear after disabling the "Shortcuts" option.
22-03-07-12-03-14.mp4

┆Issue is synchronized with this Jira Task

@SoftVision-CosminMuntean SoftVision-CosminMuntean added needs:triage Issue needs triage 🐞 bug Crashes, Something isn't working, .. labels Mar 7, 2022
@sflorean sflorean added the Feature:Shortcuts Top Sites/Topsites on the Firefox home page label Mar 7, 2022
@kbrosnan
Copy link
Contributor

kbrosnan commented Mar 9, 2022

Talked with Verdi about the behavior. We want to change this to behave like desktop. The shortcut toggle will disable the entire top sites section. This pref should be reset for existing users, because this behavior is changing dramatically. Sponsored shortcuts only disables the sponsored shortcuts, not any default pined sites. Sponsored shortcuts checkbox would be disabled if the whole feature is disabled.

@gabrielluong gabrielluong added this to the 100 milestone Mar 10, 2022
@sflorean sflorean added the S3 Blocks non-critical functionality and a work around exists label Mar 11, 2022
@gabrielluong gabrielluong self-assigned this Mar 11, 2022
@gabrielluong gabrielluong removed the needs:triage Issue needs triage label Mar 11, 2022
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Mar 11, 2022
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Mar 11, 2022
@mergify mergify bot closed this as completed in #24218 Mar 11, 2022
@SoftVision-CosminMuntean
Copy link
Author

I have verified this issue using Nightly 100.0a1 local build on Android 11 on One Plus 8 device.

  • The entire "Top Sites" section correctly disappears if the "Shortcuts" option is disabled.

pedroldk pushed a commit to pedroldk/fenix that referenced this issue Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Shortcuts Top Sites/Topsites on the Firefox home page S3 Blocks non-critical functionality and a work around exists
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants