Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Remove wrapper for login dialog #24208

Closed
mcarare opened this issue Mar 11, 2022 · 1 comment
Closed

Remove wrapper for login dialog #24208

mcarare opened this issue Mar 11, 2022 · 1 comment

Comments

@mcarare
Copy link
Contributor

mcarare commented Mar 11, 2022

Breakout from #21292.

┆Issue is synchronized with this Jira Task

@github-actions github-actions bot added the needs:triage Issue needs triage label Mar 11, 2022
@mcarare mcarare removed the needs:triage Issue needs triage label Mar 11, 2022
@Alexandru2909 Alexandru2909 self-assigned this Mar 21, 2022
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Mar 21, 2022
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Mar 23, 2022
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Mar 29, 2022
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Mar 30, 2022
@Alexandru2909 Alexandru2909 added the eng:qa:needed QA Needed label Mar 30, 2022
@LaurentiuApahideanSV
Copy link

I tested the issue on Firefox Nightly 2022-04-01 by performing the following interaction with logins and observing the events that are generated.
Sync logins
{"timestamp": 6193,
"category": "sync_account",
"name": "sync_now"}

Turn ON Logins sync
{"timestamp": 7134,
"category": "events",
"name": "preference_toggled",
"extra": {
"preference_key": "pref_key_sync_logins",
"enabled": "true"
}

Turn OFF Logins sync
{"timestamp": 4842,
"category": "events",
"name": "preference_toggled",
"extra": {
"preference_key": "pref_key_sync_logins",
"enabled": "false"
}

Access Logins in settings
{"timestamp":7524,
"category":"logins",
"name":"open_logins"}

Open an individual login
{"timestamp":8878,
"category":"logins",
"name":"open_individual_login"}

Delete a login
{"timestamp":13104,
"category":"logins",
"name":"delete_saved_login"},

Copy a login (Site, Username, Password)
{"timestamp": 97790,
"category": "logins",
"name": "copy_login"}

View a password Ping - Ping be8365e9-708b-437e-9c1e-446864614bee
{"timestamp": 96000,
"category": "logins",
"name": "view_password_login"}

Choose whether Fenix will remember logins:

NEVER_SAVE
{"timestamp":41999,
"category":"login_dialog",
"name":"never_save"}

ASK_TO_SAVE
{"timestamp":81874,
"category":"login_dialog",
"name":"saved"}

Glean Dashboard

Device used:

  • OnePlus 6T (Android 9)

@LaurentiuApahideanSV LaurentiuApahideanSV added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Apr 1, 2022
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Apr 18, 2022
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Apr 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants