Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Rename color attributes to their design token equivalent #24252

Closed
gabrielluong opened this issue Mar 13, 2022 · 0 comments · Fixed by #24253
Closed

Rename color attributes to their design token equivalent #24252

gabrielluong opened this issue Mar 13, 2022 · 0 comments · Fixed by #24253
Assignees
@gabrielluong
Labels
Feature:Themes Dark mode, light mode, private browsing mode
Milestone
100

Comments

@gabrielluong
Copy link
Member

gabrielluong commented Mar 13, 2022 •
edited by data-sync-user

Since some color attributes have been change to use the design tokens, we should refactor the old naming of our color attributes to match the naming of the design system and FirefoxThemes.

┆Issue is synchronized with this Jira Task
@gabrielluong gabrielluong added the Feature:Themes Dark mode, light mode, private browsing mode label Mar 13, 2022
@gabrielluong gabrielluong added this to the 100 milestone Mar 13, 2022
@gabrielluong gabrielluong self-assigned this Mar 13, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Mar 13, 2022
@gabrielluong gabrielluong removed the needs:triage Issue needs triage label Mar 13, 2022
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Mar 13, 2022
@gabrielluong
For mozilla-mobile#24252 - Rename primaryText attribute to textPrimary
4da48b3
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Mar 13, 2022
@gabrielluong
For mozilla-mobile#24252 - Rename secondaryText attribute to textSeco…
55d9d90 
…ndary
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Mar 13, 2022
@gabrielluong
For mozilla-mobile#24252 - Rename foundation attribute to layer1
d159cb9
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Mar 13, 2022
@gabrielluong
For mozilla-mobile#24252 - Rename above attribute to layer2
79ddf53
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Mar 13, 2022
@gabrielluong
For mozilla-mobile#24252 - Rename disabled attribute to textDisabled
6ca81a5
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Mar 13, 2022
@gabrielluong
For mozilla-mobile#24252 - Rename destructive attribute to textWarning
9c3728f
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Mar 13, 2022
@gabrielluong
For mozilla-mobile#24252 - Rename unused snackbar attribute
45df9eb
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Mar 13, 2022
@gabrielluong
For mozilla-mobile#24252 - Rename contrastText attribute to textOnCol…
02f7240 
…orPrimary
@gabrielluong gabrielluong mentioned this issue Mar 13, 2022
Merged
3 tasks
@mergify mergify bot closed this as completed in #24253 Mar 14, 2022
mergify bot pushed a commit that referenced this issue Mar 14, 2022
@gabrielluong @mergify
For #24252 - Rename primaryText attribute to textPrimary
f1e7b49
mergify bot pushed a commit that referenced this issue Mar 14, 2022
@gabrielluong @mergify
For #24252 - Rename secondaryText attribute to textSecondary
331dc3a
mergify bot pushed a commit that referenced this issue Mar 14, 2022
@gabrielluong @mergify
For #24252 - Rename foundation attribute to layer1
9817be4
mergify bot pushed a commit that referenced this issue Mar 14, 2022
@gabrielluong @mergify
For #24252 - Rename above attribute to layer2
4263e1f
mergify bot pushed a commit that referenced this issue Mar 14, 2022
@gabrielluong @mergify
For #24252 - Rename disabled attribute to textDisabled
a59d319
mergify bot pushed a commit that referenced this issue Mar 14, 2022
@gabrielluong @mergify
For #24252 - Rename destructive attribute to textWarning
a6c8f8b
mergify bot pushed a commit that referenced this issue Mar 14, 2022
@gabrielluong @mergify
For #24252 - Rename unused snackbar attribute
e5d8f1e
mergify bot pushed a commit that referenced this issue Mar 14, 2022
@gabrielluong @mergify
For #24252 - Rename contrastText attribute to textOnColorPrimary
ad95f95
pedroldk pushed a commit to pedroldk/fenix that referenced this issue Mar 22, 2022
@gabrielluong @pedroldk
For mozilla-mobile#24252 - Rename primaryText attribute to textPrimary
003bb78
pedroldk pushed a commit to pedroldk/fenix that referenced this issue Mar 22, 2022
@gabrielluong @pedroldk
For mozilla-mobile#24252 - Rename secondaryText attribute to textSeco…
557cf59 
…ndary
pedroldk pushed a commit to pedroldk/fenix that referenced this issue Mar 22, 2022
@gabrielluong @pedroldk
For mozilla-mobile#24252 - Rename foundation attribute to layer1
5b301d5
pedroldk pushed a commit to pedroldk/fenix that referenced this issue Mar 22, 2022
@gabrielluong @pedroldk
For mozilla-mobile#24252 - Rename above attribute to layer2
11b39ee
pedroldk pushed a commit to pedroldk/fenix that referenced this issue Mar 22, 2022
@gabrielluong @pedroldk
For mozilla-mobile#24252 - Rename disabled attribute to textDisabled
2343cbf
pedroldk pushed a commit to pedroldk/fenix that referenced this issue Mar 22, 2022
@gabrielluong @pedroldk
For mozilla-mobile#24252 - Rename destructive attribute to textWarning
321460b
pedroldk pushed a commit to pedroldk/fenix that referenced this issue Mar 22, 2022
@gabrielluong @pedroldk
For mozilla-mobile#24252 - Rename unused snackbar attribute
6216562
pedroldk pushed a commit to pedroldk/fenix that referenced this issue Mar 22, 2022
@gabrielluong @pedroldk
For mozilla-mobile#24252 - Rename contrastText attribute to textOnCol…
b8622ac 
…orPrimary
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gabrielluong gabrielluong

Labels
Feature:Themes Dark mode, light mode, private browsing mode
Projects
None yet
Milestone
100
Development

Successfully merging a pull request may close this issue.

For #24252 - Rename color attributes to their design token equivalent gabrielluong/fenix
1 participant
@gabrielluong