Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Add History to the search engine menu #24299

Closed
gabrielluong opened this issue Mar 16, 2022 · 2 comments · Fixed by #25267
Closed

Add History to the search engine menu #24299

gabrielluong opened this issue Mar 16, 2022 · 2 comments · Fixed by #25267
Assignees
@rocketsroger
Labels
eng:qa:verified QA Verified Feature:Search
Milestone
102

Comments

@gabrielluong
Copy link
Member

gabrielluong commented Mar 16, 2022 •
edited by data-sync-user

https://mozilla-hub.atlassian.net/browse/FNXV2-19758

┆Issue is synchronized with this Jira Task
@github-actions github-actions bot added the needs:triage Issue needs triage label Mar 16, 2022
@gabrielluong gabrielluong removed the needs:triage Issue needs triage label Mar 16, 2022
@gabrielluong gabrielluong removed their assignment Apr 29, 2022
rocketsroger added a commit to rocketsroger/fenix that referenced this issue May 2, 2022
@rocketsroger
Issue mozilla-mobile#24299: Add History to the search engine menu
4d64b1e
@rocketsroger rocketsroger mentioned this issue May 12, 2022
Closed
rocketsroger added a commit to rocketsroger/fenix that referenced this issue May 17, 2022
@rocketsroger
Issue mozilla-mobile#24299: Add history to the search engine menu
456cad0
rocketsroger added a commit to rocketsroger/fenix that referenced this issue May 17, 2022
@rocketsroger
Issue mozilla-mobile#24299: Add history to the search engine menu
21fc9e8
rocketsroger added a commit to rocketsroger/fenix that referenced this issue May 18, 2022
@rocketsroger
Issue mozilla-mobile#24299: Add history to the search engine menu
9ea47de
rocketsroger added a commit to rocketsroger/fenix that referenced this issue May 18, 2022
@rocketsroger
Issue mozilla-mobile#24299: Add history to the search engine menu
4e8390c
rocketsroger added a commit to rocketsroger/fenix that referenced this issue May 18, 2022
@rocketsroger
Issue mozilla-mobile#24299: Add history to the search engine menu
debc1ad
mergify bot pushed a commit that referenced this issue May 18, 2022
@rocketsroger @mergify
Issue #24299: Add history to the search engine menu
7f29461
@rocketsroger rocketsroger added the eng:qa:needed QA Needed label May 19, 2022
rocketsroger added a commit to rocketsroger/fenix that referenced this issue May 24, 2022
@rocketsroger
Issue mozilla-mobile#24299: Sort unified search selector menu items b…
3d97b66 
…ased on user settings
@SoftVision-LorandJanos
Copy link

Hi @gabrielluong!
I have verified the "History" item among the selectable search engines. It looks and functions as expected. However in the ticket attached in the description there is mentioning of "Bookmarks" along with "History" with the same behavior.
I didn't see the Bookmarks part implemented. Is there another ticket for Bookmarks, or maybe will there be? Thank you!

Devices used:

  • Google Pixel 4 (Android 12).
  • Xiaomi Mi11 Lite (Android 11).
  • Samsung Galaxy Tab S3 (Android 9).

Tested on the latest Nightly 102.0a1 (2022-05-25).

rocketsroger added a commit to rocketsroger/fenix that referenced this issue May 25, 2022
@rocketsroger
Issue mozilla-mobile#24299: Sort unified search selector menu items b…
e916a87 
…ased on user settings
@gabrielluong
Copy link
Member Author

Hi @gabrielluong! I have verified the "History" item among the selectable search engines. It looks and functions as expected. However in the ticket attached in the description there is mentioning of "Bookmarks" along with "History" with the same behavior. I didn't see the Bookmarks part implemented. Is there another ticket for Bookmarks, or maybe will there be? Thank you!

Devices used:

  • Google Pixel 4 (Android 12).
  • Xiaomi Mi11 Lite (Android 11).
  • Samsung Galaxy Tab S3 (Android 9).

Tested on the latest Nightly 102.0a1 (2022-05-25).

There will be another ticket for "Bookmarks". I will mark this as closed and verified.

@gabrielluong gabrielluong added the eng:qa:verified QA Verified label May 25, 2022
@gabrielluong gabrielluong added this to the 102 milestone May 25, 2022
@gabrielluong gabrielluong mentioned this issue May 25, 2022
Merged
3 tasks
rocketsroger added a commit to rocketsroger/fenix that referenced this issue May 25, 2022
@rocketsroger
Issue mozilla-mobile#24299: Sort unified search selector menu items b…
69b2be1 
…ased on user settings
mergify bot pushed a commit that referenced this issue May 25, 2022
@rocketsroger @mergify
Issue #24299: Sort unified search selector menu items based on user s…
3de3898 
…ettings
rocketsroger added a commit to rocketsroger/fenix that referenced this issue May 25, 2022
@rocketsroger
Issue mozilla-mobile#24299: Do not show history search engine in the …
138b096 
…search settings
rocketsroger added a commit to rocketsroger/fenix that referenced this issue May 25, 2022
@rocketsroger
Issue mozilla-mobile#24299: Do not show history search engine in the …
9af2436 
…search settings
mergify bot pushed a commit that referenced this issue May 26, 2022
@rocketsroger @mergify
Issue #24299: Do not show history search engine in the search settings
2b777c3
@cpeterso cpeterso mentioned this issue Sep 26, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rocketsroger rocketsroger

Labels
eng:qa:verified QA Verified Feature:Search
Projects
None yet
Milestone
102
Development

Successfully merging a pull request may close this issue.

Issue #24299: Add history to the search engine menu rocketsroger/fenix
3 participants
@gabrielluong @rocketsroger @SoftVision-LorandJanos