Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Add Private theme to FirefoxTheme #24519

Closed
gabrielluong opened this issue Mar 30, 2022 · 0 comments · Fixed by #24527
Closed

Add Private theme to FirefoxTheme #24519

gabrielluong opened this issue Mar 30, 2022 · 0 comments · Fixed by #24527
Assignees
@gabrielluong
Labels
Feature:Themes Dark mode, light mode, private browsing mode
Milestone
100

Comments

@gabrielluong
Copy link
Member

gabrielluong commented Mar 30, 2022 •
edited by data-sync-user

At a time when it wasn't clear what colors will the app use or whether we'll roll our own theme or stick with MaterialTheme I started work on a FenixTheme which had support for light/dark and private mode also - https://github.com/mozilla-mobile/fenix/pull/21193/files

Originally posted by @Mugurell in #24505 (comment)

┆Issue is synchronized with this Jira Task
@gabrielluong gabrielluong added the Feature:Themes Dark mode, light mode, private browsing mode label Mar 30, 2022
@gabrielluong gabrielluong added this to the 100 milestone Mar 30, 2022
@gabrielluong gabrielluong self-assigned this Mar 30, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Mar 30, 2022
@gabrielluong gabrielluong removed the needs:triage Issue needs triage label Mar 30, 2022
@gabrielluong gabrielluong changed the title Add Private theme to FIrefoxTheme Add Private theme to FirefoxTheme Mar 30, 2022
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Mar 30, 2022
@gabrielluong
For mozilla-mobile#24519 - Add Private theme to FirefoxTheme
66ef54e
@gabrielluong gabrielluong mentioned this issue Mar 30, 2022
Merged
3 tasks
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Mar 31, 2022
@gabrielluong
For mozilla-mobile#24519 - Add Private theme to FirefoxTheme
dbc4c62
@mergify mergify bot closed this as completed in #24527 Mar 31, 2022
mergify bot pushed a commit that referenced this issue Mar 31, 2022
@gabrielluong @mergify
For #24519 - Add Private theme to FirefoxTheme
8652ff5
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gabrielluong gabrielluong

Labels
Feature:Themes Dark mode, light mode, private browsing mode
Projects
None yet
Milestone
100
Development

Successfully merging a pull request may close this issue.

For #24519 - Add Private theme to FirefoxTheme gabrielluong/fenix
1 participant
@gabrielluong