Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Enable the messaging framework feature #25110

Closed
Amejia481 opened this issue May 4, 2022 · 5 comments
Closed

Enable the messaging framework feature #25110

Amejia481 opened this issue May 4, 2022 · 5 comments
Labels
eng:qa:verified QA Verified

Comments

@Amejia481
Copy link
Contributor

Amejia481 commented May 4, 2022 •
edited by data-sync-user
Loading

We need to enable the messagingFeature feature.

┆Issue is synchronized with this Jira Task
@github-actions github-actions bot added the needs:triage Issue needs triage label May 4, 2022
@Amejia481
Copy link
Contributor Author

https://mozilla-hub.atlassian.net/browse/FNXV2-20374

@Amejia481 Amejia481 removed the needs:triage Issue needs triage label May 4, 2022
@Amejia481 Amejia481 changed the title Enable the messaging framework in beta 101 Enable the messaging framework May 5, 2022
@Amejia481 Amejia481 changed the title Enable the messaging framework Enable the messaging framework feature May 5, 2022
Amejia481 added a commit to Amejia481/fenix that referenced this issue May 5, 2022
@Amejia481
For mozilla-mobile#25110: Enable the messaging framework feature
9a86ea4
Amejia481 added a commit to Amejia481/fenix that referenced this issue May 5, 2022
@Amejia481
For mozilla-mobile#25110: Enable the messaging framework feature
7e2ae72
Amejia481 added a commit to Amejia481/fenix that referenced this issue May 5, 2022
@Amejia481
For mozilla-mobile#25110: Enable the messaging framework feature
53f3dca
Amejia481 added a commit to Amejia481/fenix that referenced this issue May 6, 2022
@Amejia481
For mozilla-mobile#25110: Enable the messaging framework feature
deb22bf
Amejia481 added a commit that referenced this issue May 6, 2022
@Amejia481
For #25110: Enable the messaging framework feature
b22a34d
@amedyne
Copy link
Contributor

amedyne commented May 6, 2022 •
edited
Loading

@Amejia481 I believe based on the discussion we also have to enable the Default Browser(?) message

@Amejia481
Copy link
Contributor Author

Thanks for noticing it :)
Yes, that's correct. Now we are showing the default browser message via the messaging framework, which gets its default values from the nimbus.fml.yaml, previously the default browser message was only available on nightly now we are moving it to all channels :)

mergify bot pushed a commit that referenced this issue May 6, 2022
@Amejia481 @mergify
For #25110: Enable the messaging framework feature
9c29605 
(cherry picked from commit b22a34d)
Amejia481 added a commit that referenced this issue May 7, 2022
@Amejia481
For #25110: Enable the messaging framework feature
aa38ae9 
(cherry picked from commit b22a34d)
@delia-pop
Copy link

Verified as fixed on Firefox Beta 101.0.0-beta.3 with LG G7 fit (Android 8.1.0). The "Set as default browser" message is displayed on home page.
Screenshot (May 9, 2022 16 25 24)

@delia-pop delia-pop added the eng:qa:verified QA Verified label May 9, 2022
@Amejia481
Copy link
Contributor Author

Verified as fixed on Firefox Beta 101.0.0-beta.3 with LG G7 fit (Android 8.1.0). The "Set as default browser" message is displayed on home page. Screenshot (May 9, 2022 16 25 24)

Thanks for verifying @delia-pop 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
eng:qa:verified QA Verified
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Amejia481 @amedyne @delia-pop