Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Hide tabs menu when there is no tab opened #2514

Closed
Lululalu opened this issue May 15, 2019 · 1 comment
Closed

[Bug] Hide tabs menu when there is no tab opened #2514

Lululalu opened this issue May 15, 2019 · 1 comment
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified

Comments

@Lululalu
Copy link

Lululalu commented May 15, 2019 •
edited by data-sync-user
Loading

Expected behavior

When there is nottab, there is no need to show options like "close tabs", after all there are not tabs to be closed.

Actual behavior

The tabs menu e exhibited even is there is no tab available.

Device information

  • Android device: Galaxy A5 8.0
  • Fenix version: 1.0.1920

┆Issue is synchronized with this Jira Task
@Lululalu Lululalu added the 🐞 bug Crashes, Something isn't working, .. label May 15, 2019
boek added a commit to boek/fenix that referenced this issue May 15, 2019
@boek
For mozilla-mobile#2514 - Hide tabs menu when no tabs are open
8e3095e
boek added a commit that referenced this issue May 16, 2019
@boek
Small refactor before we add onboarding cards (#2541)
b3a3c94 
* For #2390 - Cleans up the toAdapterList method before we add onboarding

* For #2514 - Hide tabs menu when no tabs are open
@boek boek added the eng:qa:needed QA Needed label May 16, 2019
@lobontiumira
Copy link

Verified as fixed on the latest build 1.1.1920 (#11360657), with HTC 10 (Android 8), Google Pixel (Android 9), Sony Xperia Z5 Premium (Android 7.1.1).

@sv-ohorvath sv-ohorvath added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels May 16, 2019
@data-sync-user data-sync-user changed the title [Bug] Hide tabs menu when there is no tab opened FNX2-18051 ⁃ [Bug] Hide tabs menu when there is no tab opened Aug 5, 2020
@data-sync-user data-sync-user changed the title FNX2-18051 ⁃ [Bug] Hide tabs menu when there is no tab opened FNX3-16381 ⁃ [Bug] Hide tabs menu when there is no tab opened Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-16381 ⁃ [Bug] Hide tabs menu when there is no tab opened [Bug] Hide tabs menu when there is no tab opened May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@boek @NotWoods @sv-ohorvath @Lululalu @lobontiumira @data-sync-user