Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Tapping on search engine icon should not enter input mode #25809

Closed
rocketsroger opened this issue Jun 29, 2022 · 2 comments · Fixed by #27647, Leland-Takamine/fenix#159, fork-house/fenix#14 or nathanmkaya/fenix#108
Closed

Tapping on search engine icon should not enter input mode #25809

rocketsroger opened this issue Jun 29, 2022 · 2 comments · Fixed by #27647, Leland-Takamine/fenix#159, fork-house/fenix#14 or nathanmkaya/fenix#108
Assignees
@rocketsroger @mavduevskiy
Labels
eng:qa:verified QA Verified
Milestone
109

Comments

@rocketsroger
Copy link
Contributor

rocketsroger commented Jun 29, 2022 •
edited by data-sync-user

When user tap on the search engine icon in the toolbar, we should allow search engine selection menu popup without entering input mode. (No virtual keyboard should show)

┆Issue is synchronized with this Jira Task
@rocketsroger rocketsroger self-assigned this Jun 29, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 29, 2022
@rocketsroger rocketsroger removed the needs:triage Issue needs triage label Jun 29, 2022
@rocketsroger
Copy link
Contributor Author

Menu and the caret should be shown the same way in display mode and edit mode of the toolbar.

@mavduevskiy mavduevskiy self-assigned this Oct 18, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Nov 1, 2022
Closes mozilla-mobile#25809: tapping on search engine triggers engine…
856b760 
… selection
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Nov 1, 2022
Closes mozilla-mobile#25809: tapping on search engine triggers engine…
dbe6304 
… selection
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Nov 1, 2022
Closes mozilla-mobile#25809: fix lint errors
c2ca1bd
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Nov 1, 2022
Closes mozilla-mobile#25809: tapping on search engine triggers engine…
8123809 
… selection
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Nov 1, 2022
@github-actions github-actions bot mentioned this issue Nov 1, 2022
Merged
4 tasks
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Nov 2, 2022
Closes mozilla-mobile#25809: tapping on search engine triggers engine…
09ee8f0 
… selection
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Nov 2, 2022
Closes mozilla-mobile#25809: rebasing
b2c4991
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Nov 2, 2022
Closes mozilla-mobile#25809: fixing tests
15b0225
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Nov 2, 2022
Closes mozilla-mobile#25809: tapping on search engine triggers engine…
a116f0b 
… selection
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Nov 3, 2022
Closes mozilla-mobile#25809: fixing failing test
b8bf730
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Nov 3, 2022
Closes mozilla-mobile#25809: fixing icon scaling
a42e8d3
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Nov 3, 2022
Closes mozilla-mobile#25809: rollback padding change to toolbar in di…
c6111d3 
…splay mode
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Nov 4, 2022
Closes mozilla-mobile#25809: small fixes after PR review
e2584dc
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Nov 5, 2022
Closes mozilla-mobile#25809: small fixes after PR review and add a te…
fb731dd 
…st for DefaultSessionControlControllerTest
@github-actions github-actions bot mentioned this issue Nov 5, 2022
Closed
4 tasks
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Nov 7, 2022
Closes mozilla-mobile#25809: remove a background setter from kotlin f…
1f8be03 
…ile that is duplicated in xml
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Nov 8, 2022
Closes mozilla-mobile#25809: revert search icon scaling code to HomeF…
ad3e8d2 
…ragment
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Nov 9, 2022
Closes mozilla-mobile#25809: tapping on search engine triggers engine…
e1b4652 
… selection
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Nov 9, 2022
Closes mozilla-mobile#25809: tapping on search engine triggers engine…
c452283 
… selection
@mergify mergify bot closed this as completed in #27647 Nov 14, 2022
mergify bot pushed a commit that referenced this issue Nov 14, 2022
@mergify
Closes #25809: tapping on search engine triggers engine selection
7c4050e
@github-actions github-actions bot reopened this Nov 14, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Nov 14, 2022
@github-actions github-actions bot added this to the 108 milestone Nov 14, 2022
@MatthewTighe MatthewTighe modified the milestones: 108, 109 Nov 14, 2022
@SoftVision-LorandJanos
Copy link

Verified on the latest Nightly 109.0a1 (2022-11-22) build.
Device used: Oppo Find X5 (Android 12).
Closing the ticket as verified.

@SoftVision-LorandJanos SoftVision-LorandJanos added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Nov 22, 2022
This was referenced Dec 16, 2022
Merged
Merged
Merged
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@mergify
[fenix] Closes mozilla-mobile/fenix#25809: tapping on search engine t…
82f1a7a 
…riggers engine selection
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rocketsroger rocketsroger

@mavduevskiy mavduevskiy

Labels
eng:qa:verified QA Verified
Projects
None yet
Milestone
109
4 participants
@rocketsroger @MatthewTighe @SoftVision-LorandJanos @mavduevskiy