Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Remove "Show search engines" toggle when unified search is enabled #25814

Closed
rocketsroger opened this issue Jun 29, 2022 · 1 comment · Fixed by #27597, fork-house/fenix#14, Leland-Takamine/fenix#159 or nathanmkaya/fenix#108
Closed

Remove "Show search engines" toggle when unified search is enabled #25814

rocketsroger opened this issue Jun 29, 2022 · 1 comment · Fixed by #27597, fork-house/fenix#14, Leland-Takamine/fenix#159 or nathanmkaya/fenix#108
Assignees
@rocketsroger @Alexandru2909
Labels
eng:qa:verified QA Verified
Milestone
108

Comments

@rocketsroger
Copy link
Contributor

rocketsroger commented Jun 29, 2022 •
edited by data-sync-user

Remove "Show search engines" toggle in search settings when unified search is enabled

┆Issue is synchronized with this Jira Task
@rocketsroger rocketsroger self-assigned this Jun 29, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 29, 2022
@rocketsroger rocketsroger removed the needs:triage Issue needs triage label Jun 29, 2022
@Alexandru2909 Alexandru2909 self-assigned this Oct 27, 2022
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Oct 28, 2022
For mozilla-mobile#25814 - Hide "Show search engines" toggle from sea…
82ac719 
…rch settings when unified search is enabled
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Oct 28, 2022
@github-actions github-actions bot mentioned this issue Oct 28, 2022
Merged
4 tasks
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Oct 28, 2022
For mozilla-mobile#25814 - Hide "Show search engines" toggle from sea…
3b93899 
…rch settings when unified search is enabled
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Oct 31, 2022
For mozilla-mobile#25814 - Hide "Show search engines" toggle from sea…
a076ffe 
…rch settings when unified search is enabled
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Nov 1, 2022
For mozilla-mobile#25814 - Hide "Show search engines" toggle from sea…
e356242 
…rch settings when unified search is enabled
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Nov 2, 2022
For mozilla-mobile#25814 - Hide "Show search engines" toggle from sea…
e3458d9 
…rch settings when unified search is enabled
@mergify mergify bot closed this as completed in #27597 Nov 3, 2022
mergify bot pushed a commit that referenced this issue Nov 3, 2022
@mergify
For #25814 - Hide "Show search engines" toggle from search settings w…
ee0bff8 
…hen unified search is enabled
@github-actions github-actions bot reopened this Nov 3, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Nov 3, 2022
@github-actions github-actions bot added this to the 108 milestone Nov 3, 2022
@SoftVision-LorandJanos
Copy link

Verified as fixed in the latest Nightly 108.0a1 (2022-11-07).
The "Show search engines" toggle is no longer displayed in Search settings when Unified search is enabled.
Device used: Oppo Find X5 (Android 12).
Closing the ticket as verified.

@SoftVision-LorandJanos SoftVision-LorandJanos added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Nov 7, 2022
This was referenced Dec 6, 2022
Merged
Merged
Merged
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@mergify
[fenix] For mozilla-mobile/fenix#25814 - Hide "Show search engines" t…
85a6c4c 
…oggle from search settings when unified search is enabled
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rocketsroger rocketsroger

@Alexandru2909 Alexandru2909

Labels
eng:qa:verified QA Verified
Projects
None yet
Milestone
108
3 participants
@rocketsroger @Alexandru2909 @SoftVision-LorandJanos