Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Use history fragment to display synced history #25942

Closed
mavduevskiy opened this issue Jul 8, 2022 · 0 comments · Fixed by #25943, nathanmkaya/fenix#108 or fork-house/fenix#12
Closed

Use history fragment to display synced history #25942

mavduevskiy opened this issue Jul 8, 2022 · 0 comments · Fixed by #25943, nathanmkaya/fenix#108 or fork-house/fenix#12
Assignees
@mavduevskiy
Milestone
105

Comments

@mavduevskiy
Copy link
Contributor

mavduevskiy commented Jul 8, 2022 •
edited by data-sync-user
Loading

Using the same history fragment for both remote and local history screens doesn't cost much but saves from a lot of code duplication, as the only difference between the screens is the navigation buttons in local screen and the title.

Jira ticket: link
Design: link

┆Issue is synchronized with this Jira Task
@mavduevskiy mavduevskiy self-assigned this Jul 8, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Jul 8, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Jul 8, 2022
Closes mozilla-mobile#25942: use HistoryFragment to show synced history
6997057
@mavduevskiy mavduevskiy removed the needs:triage Issue needs triage label Jul 8, 2022
@mavduevskiy mavduevskiy mentioned this issue Jul 8, 2022
Merged
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Jul 8, 2022
Closes mozilla-mobile#25942: fix a failing unit test
f8f50e9
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Jul 12, 2022
Closes mozilla-mobile#25942: change comment
5044881
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Jul 19, 2022
Closes mozilla-mobile#25942: remove global navigation, add a comma to…
f24f01a 
… a bind method in HistoryAdapter
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Jul 19, 2022
Closes mozilla-mobile#25942: added extra comma in the end of construc…
5aecb29 
…tors, fix lint
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Jul 19, 2022
Closes mozilla-mobile#25942: hide navigation buttons from synced hist…
94a90e4 
…ory empty state
JohanLorenzo pushed a commit to mavduevskiy/fenix that referenced this issue Jul 20, 2022
@JohanLorenzo
Closes mozilla-mobile#25942: use HistoryFragment to show synced history
f06dfbd
JohanLorenzo pushed a commit to mavduevskiy/fenix that referenced this issue Jul 20, 2022
@JohanLorenzo
Closes mozilla-mobile#25942: fix a failing unit test
e9e2599
JohanLorenzo pushed a commit to mavduevskiy/fenix that referenced this issue Jul 20, 2022
@JohanLorenzo
Closes mozilla-mobile#25942: change comment
266838b
JohanLorenzo pushed a commit to mavduevskiy/fenix that referenced this issue Jul 20, 2022
@JohanLorenzo
Closes mozilla-mobile#25942: remove global navigation, add a comma to…
cb34ff5 
… a bind method in HistoryAdapter
JohanLorenzo pushed a commit to mavduevskiy/fenix that referenced this issue Jul 20, 2022
@JohanLorenzo
Closes mozilla-mobile#25942: added extra comma in the end of construc…
58984f1 
…tors, fix lint
JohanLorenzo pushed a commit to mavduevskiy/fenix that referenced this issue Jul 20, 2022
@JohanLorenzo
Closes mozilla-mobile#25942: hide navigation buttons from synced hist…
a0fc257 
…ory empty state
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Jul 26, 2022
Closes mozilla-mobile#25942: use HistoryFragment to show synced history
487d077
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Jul 26, 2022
Closes mozilla-mobile#25942: fix a failing unit test
5deba0a
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Jul 26, 2022
Closes mozilla-mobile#25942: change comment
d93ccca
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Jul 26, 2022
Closes mozilla-mobile#25942: remove global navigation, add a comma to…
e285cd3 
… a bind method in HistoryAdapter
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Jul 26, 2022
Closes mozilla-mobile#25942: added extra comma in the end of construc…
e33c10a 
…tors, fix lint
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Jul 26, 2022
Closes mozilla-mobile#25942: hide navigation buttons from synced hist…
cfecd1a 
…ory empty state
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Jul 28, 2022
Closes mozilla-mobile#25942: use HistoryFragment to show synced history
6d3f4e2
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Jul 28, 2022
Closes mozilla-mobile#25942: use HistoryFragment to show synced history
157f2f8
@mergify mergify bot closed this as completed in #25943 Jul 28, 2022
mergify bot pushed a commit that referenced this issue Jul 28, 2022
@mergify
Closes #25942: use HistoryFragment to show synced history
6483e1c
@github-actions github-actions bot added this to the 105 milestone Jul 28, 2022
mavduevskiy added a commit that referenced this issue Aug 15, 2022
@mavduevskiy
Revert "Closes #25942: use HistoryFragment to show synced history"
f5efa5d 
This reverts commit 6483e1c.
mergify bot pushed a commit that referenced this issue Aug 16, 2022
@mavduevskiy @mergify
Revert "Closes #25942: use HistoryFragment to show synced history"
40ef60c 
This reverts commit 6483e1c.
@github-actions github-actions bot mentioned this issue Aug 31, 2022
Merged
@github-actions github-actions bot mentioned this issue Aug 31, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mavduevskiy mavduevskiy

Labels
None yet
Projects
None yet
Milestone
105
1 participant
@mavduevskiy