Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Update the close icon to latest mobile icon #25952

Closed
gabrielluong opened this issue Jul 8, 2022 · 4 comments · Fixed by #26000, fork-house/fenix#12 or Smaehtin/fenix#109
Closed

Update the close icon to latest mobile icon #25952

gabrielluong opened this issue Jul 8, 2022 · 4 comments · Fixed by #26000, fork-house/fenix#12 or Smaehtin/fenix#109
Assignees
@mavduevskiy
Labels
eng:qa:verified QA Verified needs:triage Issue needs triage
Milestone
104

Comments

@gabrielluong
Copy link
Member

gabrielluong commented Jul 8, 2022 •
edited by data-sync-user

we can replace the smaller close icon with the bigger one (16x16) across the app

Originally posted by @topotropic in #25941 (comment)

We'll want to replace ic_close with the latest mobile icon in https://www.figma.com/file/Kv7wWr8vH6AQrGhu9vmjdE/Mobile-Icons?node-id=221%3A1164. We should also inspect that this bigger close icon does not affect existing dialogs or component that should be using the smaller close icon

┆Issue is synchronized with this Jira Task
@github-actions github-actions bot added the needs:triage Issue needs triage label Jul 8, 2022
@sunilk9211235
Copy link
Contributor

hey @gabrielluong let me know if i can do this?

@gabrielluong
Copy link
Member Author

gabrielluong commented Jul 10, 2022 •
edited

@sunilk9211 I believe @mavduevskiy is already working with UX on this. Sorry about that.

@sunilk9211235
Copy link
Contributor

That's great. Thanks.

@mavduevskiy mavduevskiy self-assigned this Jul 11, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Jul 12, 2022
Closes mozilla-mobile#25952: update close icon
2d52f9a
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Jul 13, 2022
Closes mozilla-mobile#25952: update close icon, start using close_20 …
cffc2aa 
…on smaller ui elements
@mavduevskiy mavduevskiy mentioned this issue Jul 13, 2022
Merged
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Jul 13, 2022
Closes mozilla-mobile#25952: remove indentation change in close icon
38630b7
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Jul 15, 2022
Closes mozilla-mobile#25952: update close icon, start using close_20 …
9703047 
…on smaller ui elements
@mergify mergify bot closed this as completed in #26000 Jul 15, 2022
mergify bot pushed a commit that referenced this issue Jul 15, 2022
@mergify
Closes #25952: update close icon, start using close_20 on smaller ui …
bbc835a 
…elements
@github-actions github-actions bot added this to the 104 milestone Jul 15, 2022
This was referenced Jul 15, 2022
Merged
Merged
@LaurentiuApahideanSV
Copy link

I tested the issue on Firefox Beta 104.0b1 and the following buttons have increased in size:
close button from downloads manager
close button from sites in a collection
close button from tabs that are in the inactive section
close button from tabs in list view
close button from history
close button from Recently closed tabs
close button from the save to collection screen
close button from sharing screen after sharing a collection
close button from ETP exceptions list

Devices used:

  • Huawei MediaPad M3 (Android 7)
  • OnePlus 6T (Android 9)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mavduevskiy mavduevskiy

Labels
eng:qa:verified QA Verified needs:triage Issue needs triage
Projects
None yet
Milestone
104
4 participants
@gabrielluong @sunilk9211235 @LaurentiuApahideanSV @mavduevskiy