Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Refactor RecentSyncedTabsFeature to rely on SyncStore instead of implementing SyncedTabsView #25955

Closed
MatthewTighe opened this issue Jul 8, 2022 · 0 comments · Fixed by #26028, fork-house/fenix#12 or Smaehtin/fenix#109
Closed

Refactor RecentSyncedTabsFeature to rely on SyncStore instead of implementing SyncedTabsView #25955

MatthewTighe opened this issue Jul 8, 2022 · 0 comments · Fixed by #26028, fork-house/fenix#12 or Smaehtin/fenix#109
Assignees
@MatthewTighe
Labels
needs:triage Issue needs triage TaskContinuity https://mozilla-hub.atlassian.net/browse/FNXV2-19368
Milestone
104

Comments

@MatthewTighe
Copy link
Contributor

MatthewTighe commented Jul 8, 2022 •
edited by data-sync-user
Loading

Now that SyncStore is available, RecentSyncedTabsFeature can be refactored to move away from the SyncedTabsView pattern which should simplify the overall design of the feature.

┆Issue is synchronized with this Jira Task
@MatthewTighe MatthewTighe added the TaskContinuity https://mozilla-hub.atlassian.net/browse/FNXV2-19368 label Jul 8, 2022
@MatthewTighe MatthewTighe self-assigned this Jul 8, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Jul 8, 2022
@MatthewTighe MatthewTighe mentioned this issue Jul 8, 2022
Merged
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Jul 14, 2022
@MatthewTighe
Fixes mozilla-mobile#25955: refactor RecentSyncedTabsFeature to use S…
9c568f7 
…yncStore
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Jul 14, 2022
@MatthewTighe
Fixes mozilla-mobile#25955: refactor RecentSyncedTabsFeature to use S…
3b4bb52 
…yncStore
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Jul 14, 2022
@MatthewTighe
Fixes mozilla-mobile#25955: refactor RecentSyncedTabsFeature to use S…
b78ce44 
…yncStore
@github-actions github-actions bot mentioned this issue Jul 14, 2022
Merged
4 tasks
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Jul 15, 2022
@MatthewTighe
Fixes mozilla-mobile#25955: refactor RecentSyncedTabsFeature to use S…
6d84d8a 
…yncStore
@MozillaNoah MozillaNoah mentioned this issue Jul 15, 2022
Closed
@mergify mergify bot closed this as completed in #26028 Jul 16, 2022
mergify bot pushed a commit that referenced this issue Jul 16, 2022
@MatthewTighe @mergify
Fixes #25955: refactor RecentSyncedTabsFeature to use SyncStore
5e15e9a
@github-actions github-actions bot added this to the 104 milestone Jul 16, 2022
This was referenced Jul 16, 2022
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MatthewTighe MatthewTighe

Labels
needs:triage Issue needs triage TaskContinuity https://mozilla-hub.atlassian.net/browse/FNXV2-19368
Projects
None yet
Milestone
104
1 participant
@MatthewTighe