Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[UITests] Track ignored tests from when migrating tabs tray to compose #26087

Closed
1 task
Tracked by #21318
Alexandru2909 opened this issue Jul 19, 2022 · 7 comments · Fixed by #27206, #27446, nathanmkaya/fenix#108, #28180 or #28185
Closed
1 task
Tracked by #21318

[UITests] Track ignored tests from when migrating tabs tray to compose #26087

Alexandru2909 opened this issue Jul 19, 2022 · 7 comments · Fixed by #27206, #27446, nathanmkaya/fenix#108, #28180 or #28185
Assignees
@sv-ohorvath @AndiAJ
Labels
eng:disabled-test For any test that has been disabled eng:ui-test UI Tests
Milestone
110

Comments

@Alexandru2909
Copy link
Contributor

Alexandru2909 commented Jul 19, 2022 •
edited by Mugurell
Loading

QA recommended having one ticket tracking all changes which resulted in disabled tests following the compose migration of the tabs tray:

Tests which cannot easily be updated to support compose can be @Ignored with the following comment:

"Failing after compose migration. See: #26087"

 

cc @sv-ohorvath @AndiAJ

┆Issue is synchronized with this Jira Task
@Alexandru2909 Alexandru2909 added eng:disabled-test For any test that has been disabled eng:ui-test UI Tests labels Jul 19, 2022
@Alexandru2909 Alexandru2909 mentioned this issue Jul 19, 2022
Merged
3 tasks
@github-actions github-actions bot added the needs:triage Issue needs triage label Jul 19, 2022
@sv-ohorvath sv-ohorvath removed the needs:triage Issue needs triage label Jul 19, 2022
@AndiAJ
Copy link
Collaborator

AndiAJ commented Jul 27, 2022

Thanks @Alexandru2909 ! ☺️

Just for a better overview, these UI tests were disabled:
► MenuScreenShotTest

  • tabMenuTest

► BookmarksTest

  • openSelectionInNewTabTest
  • openSelectionInPrivateTabTest

► CollectionTest

  • createFirstCollectionTest
  • verifyExpandedCollectionItemsTest
  • openAllTabsInCollectionTest
  • shareCollectionTest
  • deleteCollectionTest
  • mainMenuSaveToExistingCollection
  • verifyAddTabButtonOfCollectionMenu
  • renameCollectionTest
  • createSecondCollectionTest
  • removeTabFromCollectionTest
  • swipeLeftToRemoveTabFromCollectionTest
  • swipeRightToRemoveTabFromCollectionTest
  • selectTabOnLongTapTest
  • navigateBackInCollectionFlowTest
  • undoDeleteCollectionTest

► ContextMenusTest

  • verifyContextOpenLinkNewTab
  • verifyContextOpenLinkPrivateTab

► CrashReportingTest

  • privateBrowsingUseAppWhileTabIsCrashedTest

► HistoryTest

  • openHistoryInNewTabTest
  • openHistoryInPrivateTabTest
  • verifyRecentlyClosedTabsListTest

► SearchTest

  • noRecentlyVisitedSearchGroupInPrivateBrowsingTest

► SettingsPrivacyTest

  • launchPageShortcutInPrivateModeTest

► SettingsSearchTest

  • toggleSearchBookmarksAndHistoryTest

► SmokeTest

  • verifyBasicNavigationToolbarFunctionality
  • openRecentlyClosedItemTest
  • deleteRecentlyClosedTabsItemTest
  • shareTabsFromTabsTrayTest
  • privateTabsTrayWithOpenedTabTest
  • tabMediaControlButtonTest

► StrictEnhancedTrackingProtectionTest

  • testStrictVisitProtectionSheet
  • testStrictVisitSheetDetails

► TabbedBrowsingTest

  • openNewTabTest
  • openNewPrivateTabTest
  • closeAllTabsTest
  • closeTabTest
  • verifyUndoSnackBarTest
  • closePrivateTabTest
  • verifyPrivateTabUndoSnackBarTest
  • verifyOpenTabDetails

cc @sv-ohorvath

@sv-ohorvath sv-ohorvath self-assigned this Aug 1, 2022
@sv-ohorvath
Copy link
Contributor

I started fixing the tests, but some are blocked and failing, and the reason seems to be that the work on the tabs tray is incomplete and certain transitions don't work so well in UI tests. Testing manually, there's no visible issue.
After discussing with the team, I've decided to leave the tests disabled on Debug until the refactoring work is complete.
Tracking for the dev work done is here #21318
We will continue to run these tests on Beta/RC builds, but not on debug.

@Mugurell
Copy link
Contributor

Mugurell commented Aug 2, 2022

Talked with Oana about using this ticket as some sort of a meta for tracking all disabled tests following the compose migration of the tabs tray.
Will update the ticket description and add this to the meta ticket for the migration.

@Mugurell Mugurell mentioned this issue Aug 2, 2022
Closed
13 tasks
@Mugurell Mugurell changed the title [UITests] Re-enable ignored tests caused by tabs tray grid viewHolder migration to compose [UITests] Track ignored tests from when migrating tabs tray to compose Aug 2, 2022
@sv-ohorvath
Copy link
Contributor

Confirmed with Alexandru and Petru that there is still more refactorization work to be done on the tabs tray which would affect the tests, so we'll leave them disabled until they're fully done.

@AndiAJ
Copy link
Collaborator

AndiAJ commented Sep 20, 2022 •
edited
Loading

openAllInTabsTest and openAllInPrivateTabsTest got disabled in #21212

@AndiAJ AndiAJ mentioned this issue Sep 29, 2022
Merged
4 tasks
AndiAJ added a commit to AndiAJ/fenix that referenced this issue Sep 29, 2022
@AndiAJ
For mozilla-mobile#26087 re-enable UI tests affected by tabs tray mig…
7a48ce7 
…ration to compose
@mergify mergify bot closed this as completed in #27206 Sep 29, 2022
mergify bot pushed a commit that referenced this issue Sep 29, 2022
@AndiAJ @mergify
For #26087 re-enable UI tests affected by tabs tray migration to compose
f58442d
@github-actions github-actions bot added this to the 107 milestone Sep 29, 2022
@AndiAJ
Copy link
Collaborator

AndiAJ commented Oct 3, 2022 •
edited
Loading

Just for a better overview, the updated list is as it follows:
► MenuScreenShotTest

► BookmarksTest

► CollectionTest

  • createFirstCollectionTest
  • verifyExpandedCollectionItemsTest
  • openAllTabsInCollectionTest
  • shareCollectionTest
  • deleteCollectionTest
  • mainMenuSaveToExistingCollection
  • verifyAddTabButtonOfCollectionMenu
  • renameCollectionTest
  • createSecondCollectionTest
  • removeTabFromCollectionTest
  • swipeLeftToRemoveTabFromCollectionTest
  • swipeRightToRemoveTabFromCollectionTest
  • selectTabOnLongTapTest
  • navigateBackInCollectionFlowTest
  • undoDeleteCollectionTest

► ContextMenusTest

► CrashReportingTest

► HistoryTest

► SearchTest

  • noRecentlyVisitedSearchGroupInPrivateBrowsingTest

► SettingsPrivacyTest

► SettingsSearchTest

► SmokeTest

► StrictEnhancedTrackingProtectionTest

► TabbedBrowsingTest

@AndiAJ AndiAJ reopened this Oct 19, 2022
AndiAJ added a commit to AndiAJ/fenix that referenced this issue Oct 19, 2022
@AndiAJ
For mozilla-mobile#25029 and mozilla-mobile#26087 re-enable useAppWhi…
cd0e406 
…leTabIsCrashedTest and privateBrowsingUseAppWhileTabIsCrashedTest UI tests
@github-actions github-actions bot mentioned this issue Oct 19, 2022
Merged
4 tasks
mergify bot pushed a commit that referenced this issue Oct 19, 2022
@AndiAJ @mergify
For #25029 and #26087 re-enable useAppWhileTabIsCrashedTest and priva…
9721381 
…teBrowsingUseAppWhileTabIsCrashedTest UI tests
@mergify mergify bot closed this as completed in #27446 Oct 19, 2022
@github-actions github-actions bot mentioned this issue Nov 3, 2022
Merged
@sv-ohorvath sv-ohorvath reopened this Nov 25, 2022
AndiAJ added a commit to AndiAJ/fenix that referenced this issue Dec 13, 2022
@AndiAJ
For mozilla-mobile#26087 fix disabled tabMediaControlButtonTest UI test
d4b22fc
@github-actions github-actions bot mentioned this issue Dec 13, 2022
Merged
4 tasks
@AndiAJ AndiAJ removed this from the 107 milestone Dec 13, 2022
@mergify mergify bot closed this as completed in #28180 Dec 13, 2022
mergify bot pushed a commit that referenced this issue Dec 13, 2022
@AndiAJ @mergify
For #26087 fix disabled tabMediaControlButtonTest UI test
3632aab
@github-actions github-actions bot added this to the 110 milestone Dec 13, 2022
@AndiAJ AndiAJ removed this from the 110 milestone Dec 13, 2022
@AndiAJ AndiAJ reopened this Dec 13, 2022
AndiAJ added a commit to AndiAJ/fenix that referenced this issue Dec 14, 2022
@AndiAJ
For mozilla-mobile#26087 re-enable UI tests disabled due to tabs tray…
615bd26 
… migration to compose
@github-actions github-actions bot mentioned this issue Dec 14, 2022
Merged
4 tasks
AndiAJ added a commit to AndiAJ/fenix that referenced this issue Dec 14, 2022
@AndiAJ
For mozilla-mobile#26087 re-enable UI tests disabled due to tabs tray…
f5007d1 
… migration to compose
AndiAJ added a commit to AndiAJ/fenix that referenced this issue Dec 15, 2022
@AndiAJ
For mozilla-mobile#26087 re-enable UI tests disabled due to tabs tray…
2a50351 
… migration to compose
@mergify mergify bot closed this as completed in #28185 Dec 15, 2022
mergify bot pushed a commit that referenced this issue Dec 15, 2022
@AndiAJ @mergify
For #26087 re-enable UI tests disabled due to tabs tray migration to …
d4d814a 
…compose
@github-actions github-actions bot added this to the 110 milestone Dec 15, 2022
@AndiAJ AndiAJ reopened this Dec 15, 2022
AndiAJ added a commit to AndiAJ/fenix that referenced this issue Dec 21, 2022
@AndiAJ
For mozilla-mobile#26087 re-enable collections UI tests
13d8d0a
@github-actions github-actions bot mentioned this issue Dec 21, 2022
Merged
4 tasks
AndiAJ added a commit to AndiAJ/fenix that referenced this issue Dec 22, 2022
@AndiAJ
For mozilla-mobile#26087 re-enable collections UI tests
53dceaa
AndiAJ added a commit to AndiAJ/fenix that referenced this issue Dec 22, 2022
@AndiAJ
For mozilla-mobile#26087 re-enable collections UI tests (Part 1)
3b865fb
AndiAJ added a commit to AndiAJ/fenix that referenced this issue Dec 22, 2022
@AndiAJ
For mozilla-mobile#26087 re-enable collections UI tests (Part 2)
9a1da0e
AndiAJ added a commit to AndiAJ/fenix that referenced this issue Dec 22, 2022
@AndiAJ
For mozilla-mobile#26087 re-enable collections UI tests disabled by t…
c7bcb2b 
…he tabs tray migration to compose
@cpeterso
Copy link

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1807270

Change performed by the Move to Bugzilla add-on.

AndiAJ added a commit to AndiAJ/fenix that referenced this issue Jan 4, 2023
@AndiAJ
For mozilla-mobile#26087 re-enable collections UI tests disabled by t…
8978738 
…he tabs tray migration to compose
This was referenced Jan 22, 2023
Merged
Merged
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@AndiAJ @mergify
[fenix] For mozilla-mobile/fenix#26087 re-enable UI tests affected by…
12db573 
… tabs tray migration to compose
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@AndiAJ @mergify
[fenix] For mozilla-mobile/fenix#25029 and mozilla-mobile/fenix#26087 …
1b5c756 
…re-enable useAppWhileTabIsCrashedTest and privateBrowsingUseAppWhileTabIsCrashedTest UI tests
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@AndiAJ @mergify
[fenix] For mozilla-mobile/fenix#26087 fix disabled tabMediaControlBu…
4f3215a 
…ttonTest UI test
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@AndiAJ @mergify
[fenix] For mozilla-mobile/fenix#26087 re-enable UI tests disabled du…
abfda95 
…e to tabs tray migration to compose
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sv-ohorvath sv-ohorvath

@AndiAJ AndiAJ

Labels
eng:disabled-test For any test that has been disabled eng:ui-test UI Tests
Projects
None yet
Milestone
110
5 participants
@cpeterso @sv-ohorvath @Mugurell @Alexandru2909 @AndiAJ