This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Recent synced tab should retrieve hero image URL from synced history #26124
Closed
Comments
MatthewTighe
added a commit
to MatthewTighe/fenix
that referenced
this issue
Jul 26, 2022
…URLs from history
MatthewTighe
added a commit
to MatthewTighe/fenix
that referenced
this issue
Jul 26, 2022
…URLs from history
MatthewTighe
added a commit
to MatthewTighe/fenix
that referenced
this issue
Jul 26, 2022
…URLs from history
MatthewTighe
added a commit
to MatthewTighe/fenix
that referenced
this issue
Jul 26, 2022
…URLs from history
MatthewTighe
added a commit
to MatthewTighe/fenix
that referenced
this issue
Jul 26, 2022
…URLs from history
4 tasks
MatthewTighe
added a commit
to MatthewTighe/fenix
that referenced
this issue
Jul 28, 2022
…URLs from history
MatthewTighe
added a commit
to MatthewTighe/fenix
that referenced
this issue
Aug 16, 2022
…URLs from history
MatthewTighe
added a commit
to MatthewTighe/fenix
that referenced
this issue
Aug 16, 2022
…URLs from history
@LaurentiuApahideanSV I don't believe we can display favicons or hero images until a site has been loaded locally. Had the tabs above been visited on the device that they are only displaying letters on? |
I'm now seeing that we may be missing preview image URLs from our history object. I filed #26591 to investigate further |
Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1813797 Change performed by the Move to Bugzilla add-on. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Currently, a centered favicon is being displayed in the recent synced tab on the homescreen. A better image can be retrieved by looking up the
previewImageUrl
for the Places history entry (which is Sync'd), and using that instead of theiconUrl
attached to tabs.See the bookmark implementation for how this can be done.
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: