Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Recent synced tab should retrieve hero image URL from synced history #26124

Closed
MatthewTighe opened this issue Jul 20, 2022 · 5 comments · Fixed by #26195 or nathanmkaya/fenix#108
Closed
Assignees
Labels
TaskContinuity https://mozilla-hub.atlassian.net/browse/FNXV2-19368
Milestone

Comments

@MatthewTighe
Copy link
Contributor

MatthewTighe commented Jul 20, 2022

Currently, a centered favicon is being displayed in the recent synced tab on the homescreen. A better image can be retrieved by looking up the previewImageUrl for the Places history entry (which is Sync'd), and using that instead of the iconUrl attached to tabs.

See the bookmark implementation for how this can be done.

┆Issue is synchronized with this Jira Task

@MatthewTighe MatthewTighe added the TaskContinuity https://mozilla-hub.atlassian.net/browse/FNXV2-19368 label Jul 20, 2022
@MatthewTighe MatthewTighe self-assigned this Jul 20, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Jul 20, 2022
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Jul 26, 2022
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Jul 26, 2022
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Jul 26, 2022
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Jul 26, 2022
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Jul 26, 2022
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Jul 26, 2022
@SoftVision-LorandJanos
Copy link

Verified on the latest Nightly 105.0a1 (2022-07-28) build with the following result:

Screenshot_20220728-172712
Screenshot_20220728-173147
Screenshot_20220728-173907
Screenshot_20220728-173928

  • Sometimes the favicon is not display at first only after refresh or resync (As seen on the last two screenshots with the Telegraph site as an example)

Device used: Google Pixel 4 (Android 12).

MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Jul 28, 2022
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Aug 16, 2022
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Aug 16, 2022
@mergify mergify bot closed this as completed in #26195 Aug 16, 2022
@github-actions github-actions bot reopened this Aug 16, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Aug 16, 2022
@github-actions github-actions bot added this to the 105 milestone Aug 16, 2022
@LaurentiuApahideanSV
Copy link

I tested the issue on Fenix Nightly 105.0a1 (2022-08-18) and for many websites the favicon do not not sync. I've attached a screenshot illustrating the issue, on the left are the favicons loaded on the original device and on the right is what these favicons look when synced to another device.
sync

Devices used:

  • Google Pixel 6 (Android 13)
  • Samsung Galaxy S22 (Android 12)

@gabrielluong gabrielluong removed the needs:triage Issue needs triage label Aug 19, 2022
@MatthewTighe
Copy link
Contributor Author

@LaurentiuApahideanSV I don't believe we can display favicons or hero images until a site has been loaded locally. Had the tabs above been visited on the device that they are only displaying letters on?

@MatthewTighe
Copy link
Contributor Author

I'm now seeing that we may be missing preview image URLs from our history object. I filed #26591 to investigate further

@boek
Copy link
Contributor

boek commented Jan 30, 2023

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1813797

Change performed by the Move to Bugzilla add-on.

@boek boek closed this as completed Jan 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
TaskContinuity https://mozilla-hub.atlassian.net/browse/FNXV2-19368
Projects
None yet
5 participants