Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

TCP CFR #26224

Closed
Mugurell opened this issue Jul 28, 2022 · 1 comment · Fixed by #26226 or nathanmkaya/fenix#108
Closed

TCP CFR #26224

Mugurell opened this issue Jul 28, 2022 · 1 comment · Fixed by #26226 or nathanmkaya/fenix#108
Assignees
@Mugurell
Labels
eng:qa:verified QA Verified needs:triage Issue needs triage
Milestone
106

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Jul 28, 2022 •
edited by data-sync-user
Loading

https://mozilla-hub.atlassian.net/browse/FNXV2-20991

┆Issue is synchronized with this Jira Task
@Mugurell Mugurell self-assigned this Jul 28, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Jul 28, 2022
Mugurell added a commit to Mugurell/fenix that referenced this issue Jul 28, 2022
@Mugurell
For mozilla-mobile#26224 - New TCP CFR popup composable
f36835b 
If Total Cookie Protection is enabled when first accessing a normal tab
(not a custom tab) a new Contextual Feature Recommendation popup will be shown
informing about the added protection and allowing the user to open a support
page with more data about the new option for privacy protection.
Mugurell added a commit to Mugurell/fenix that referenced this issue Jul 28, 2022
@Mugurell
For mozilla-mobile#26224 - TCP CFR telemetry
387b2b2
Mugurell added a commit to Mugurell/fenix that referenced this issue Jul 28, 2022
@Mugurell
For mozilla-mobile#26224 - New TCP CFR popup composable
da78632 
If Total Cookie Protection is enabled when first accessing a normal tab
(not a custom tab) a new Contextual Feature Recommendation popup will be shown
informing about the added protection and allowing the user to open a support
page with more data about the new option for privacy protection.
Mugurell added a commit to Mugurell/fenix that referenced this issue Jul 28, 2022
@Mugurell
For mozilla-mobile#26224 - TCP CFR telemetry
fedcd94
Mugurell added a commit to Mugurell/fenix that referenced this issue Jul 28, 2022
@Mugurell
For mozilla-mobile#26224 - New TCP CFR popup
8760f08 
If Total Cookie Protection is enabled when first accessing a normal tab
(not a custom tab) a new Contextual Feature Recommendation popup will be shown
informing about the added protection and allowing the user to open a support
page with more data about the new option for privacy protection.
Mugurell added a commit to Mugurell/fenix that referenced this issue Jul 28, 2022
@Mugurell
For mozilla-mobile#26224 - TCP CFR telemetry
4a5e6cd
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Jul 28, 2022
@github-actions github-actions bot mentioned this issue Jul 28, 2022
Merged
4 tasks
Mugurell added a commit to Mugurell/fenix that referenced this issue Jul 28, 2022
@Mugurell
For mozilla-mobile#26224 - New TCP CFR popup
4810a91 
If Total Cookie Protection is enabled when first accessing a normal tab
(not a custom tab) a new Contextual Feature Recommendation popup will be shown
informing about the added protection and allowing the user to open a support
page with more data about the new option for privacy protection.
Mugurell added a commit to Mugurell/fenix that referenced this issue Jul 28, 2022
@Mugurell
For mozilla-mobile#26224 - TCP CFR telemetry
d14cceb
Mugurell added a commit to Mugurell/fenix that referenced this issue Jul 28, 2022
@Mugurell
For mozilla-mobile#26224 - New TCP CFR popup
1cdcaf8 
If Total Cookie Protection is enabled when first accessing a normal tab
(not a custom tab) a new Contextual Feature Recommendation popup will be shown
informing about the added protection and allowing the user to open a support
page with more data about the new option for privacy protection.
Mugurell added a commit to Mugurell/fenix that referenced this issue Jul 28, 2022
@Mugurell
For mozilla-mobile#26224 - TCP CFR telemetry
037e6dd
Mugurell added a commit to Mugurell/fenix that referenced this issue Aug 4, 2022
@Mugurell
For mozilla-mobile#26224 - New TCP CFR popup
7732e16 
If Total Cookie Protection is enabled when first accessing a normal tab
(not a custom tab) a new Contextual Feature Recommendation popup will be shown
informing about the added protection and allowing the user to open a support
page with more data about the new option for privacy protection.
Mugurell added a commit to Mugurell/fenix that referenced this issue Aug 4, 2022
@Mugurell
For mozilla-mobile#26224 - metrics.yaml cleanup of unneeded newlines
1bfb5f1
Mugurell added a commit to Mugurell/fenix that referenced this issue Aug 4, 2022
@Mugurell
For mozilla-mobile#26224 - New TCP CFR popup
030c18a 
If Total Cookie Protection is enabled when first accessing a normal tab
(not a custom tab) a new Contextual Feature Recommendation popup will be shown
informing about the added protection and allowing the user to open a support
page with more data about the new option for privacy protection.
Mugurell added a commit to Mugurell/fenix that referenced this issue Aug 4, 2022
@Mugurell
For mozilla-mobile#26224 - TCP CFR telemetry
219782f
Mugurell added a commit to Mugurell/fenix that referenced this issue Aug 4, 2022
@Mugurell
For mozilla-mobile#26224 - metrics.yaml cleanup of unneeded newlines
b45827e
Mugurell added a commit to Mugurell/fenix that referenced this issue Aug 10, 2022
@Mugurell
For mozilla-mobile#26224 - New TCP CFR popup
0a8a2d6 
If Total Cookie Protection is enabled when first accessing a normal tab
(not a custom tab) a new Contextual Feature Recommendation popup will be shown
informing about the added protection and allowing the user to open a support
page with more data about the new option for privacy protection.
Mugurell added a commit to Mugurell/fenix that referenced this issue Aug 10, 2022
@Mugurell
For mozilla-mobile#26224 - Use the browserscreen.cfrs-enabled.tcp Nim…
8fa9a9e 
…bus feature to display the cfr.

This adds a new "browserscreen" feature with initially just a "cfrs-enabled"
variable, similar to "homescreen.sections-enabled" to allow controlling from
Nimbus if certain CFRs should be shown while browsing.
Other variables can be added to the "browserscreen" feature later.
Mugurell added a commit to Mugurell/fenix that referenced this issue Aug 10, 2022
@Mugurell
For mozilla-mobile#26224 - TCP CFR telemetry
7f39fed
Mugurell added a commit to Mugurell/fenix that referenced this issue Aug 10, 2022
@Mugurell
For mozilla-mobile#26224 - metrics.yaml cleanup of unneeded newlines
82885b8
Mugurell added a commit to Mugurell/fenix that referenced this issue Aug 11, 2022
@Mugurell
For mozilla-mobile#26224 - New TCP CFR popup
7be5e49 
If Total Cookie Protection is enabled when first accessing a normal tab
(not a custom tab) a new Contextual Feature Recommendation popup will be shown
informing about the added protection and allowing the user to open a support
page with more data about the new option for privacy protection.
Mugurell added a commit to Mugurell/fenix that referenced this issue Aug 11, 2022
@Mugurell
For mozilla-mobile#26224 - Use the browserscreen.cfrs-enabled.tcp Nim…
4f28d9d 
…bus feature to display the cfr

This adds a new "browserscreen" feature with initially just a "cfrs-enabled"
variable, similar to "homescreen.sections-enabled" to allow controlling from
Nimbus if certain CFRs should be shown while browsing.
Other variables can be added to the "browserscreen" feature later.
Mugurell added a commit to Mugurell/fenix that referenced this issue Aug 11, 2022
@Mugurell
For mozilla-mobile#26224 - TCP CFR telemetry
872665f
Mugurell added a commit to Mugurell/fenix that referenced this issue Aug 11, 2022
@Mugurell
For mozilla-mobile#26224 - metrics.yaml cleanup of unneeded newlines
1fab747
Mugurell added a commit to Mugurell/fenix that referenced this issue Aug 12, 2022
@Mugurell
For mozilla-mobile#26224 - New TCP CFR popup
f8b1198 
If Total Cookie Protection is enabled when first accessing a normal tab
(not a custom tab) a new Contextual Feature Recommendation popup will be shown
informing about the added protection and allowing the user to open a support
page with more data about the new option for privacy protection.
Mugurell added a commit to Mugurell/fenix that referenced this issue Aug 12, 2022
@Mugurell
For mozilla-mobile#26224 - Use the browserscreen.cfrs-enabled.tcp Nim…
b4dba37 
…bus feature to display the cfr

This adds a new "browserscreen" feature with initially just a "cfrs-enabled"
variable, similar to "homescreen.sections-enabled" to allow controlling from
Nimbus if certain CFRs should be shown while browsing.
Other variables can be added to the "browserscreen" feature later.
Mugurell added a commit to Mugurell/fenix that referenced this issue Aug 12, 2022
@Mugurell
For mozilla-mobile#26224 - TCP CFR telemetry
5466a64
Mugurell added a commit to Mugurell/fenix that referenced this issue Aug 25, 2022
@Mugurell
For mozilla-mobile#26224 - metrics.yaml cleanup of unneeded newlines
146c8b2
Mugurell added a commit to Mugurell/fenix that referenced this issue Aug 25, 2022
@Mugurell
For mozilla-mobile#26224 - New TCP CFR popup
9768bae 
If Total Cookie Protection is enabled when first accessing a normal tab
(not a custom tab) a new Contextual Feature Recommendation popup will be shown
informing about the added protection and allowing the user to open a support
page with more data about the new option for privacy protection.
Mugurell added a commit to Mugurell/fenix that referenced this issue Aug 25, 2022
@Mugurell
For mozilla-mobile#26224 - Use the mr2022.sectionsEnabled.tcp-cfr Nim…
0879bb1 
…bus feature to display the cfr
Mugurell added a commit to Mugurell/fenix that referenced this issue Aug 25, 2022
@Mugurell
For mozilla-mobile#26224 - TCP CFR telemetry
495ef33
Mugurell added a commit to Mugurell/fenix that referenced this issue Aug 25, 2022
@Mugurell
For mozilla-mobile#26224 - metrics.yaml cleanup of unneeded newlines
e50ad2d
Mugurell added a commit to Mugurell/fenix that referenced this issue Aug 25, 2022
@Mugurell
For mozilla-mobile#26224 - Disable the TCP CFR in failing UI tests
d3ab41c
Mugurell added a commit to Mugurell/fenix that referenced this issue Aug 25, 2022
@Mugurell
For mozilla-mobile#26224 - New TCP CFR popup
181bd41 
If Total Cookie Protection is enabled when first accessing a normal tab
(not a custom tab) a new Contextual Feature Recommendation popup will be shown
informing about the added protection and allowing the user to open a support
page with more data about the new option for privacy protection.
Mugurell added a commit to Mugurell/fenix that referenced this issue Aug 25, 2022
@Mugurell
For mozilla-mobile#26224 - Use the mr2022.sectionsEnabled.tcp-cfr Nim…
c3c95cb 
…bus feature to display the cfr
Mugurell added a commit to Mugurell/fenix that referenced this issue Aug 25, 2022
@Mugurell
For mozilla-mobile#26224 - TCP CFR telemetry
13cc7e5
Mugurell added a commit to Mugurell/fenix that referenced this issue Aug 25, 2022
@Mugurell
For mozilla-mobile#26224 - metrics.yaml cleanup of unneeded newlines
8ed9f35
Mugurell added a commit to Mugurell/fenix that referenced this issue Aug 25, 2022
@Mugurell
For mozilla-mobile#26224 - Disable the TCP CFR in failing UI tests
092ab10
Mugurell added a commit to Mugurell/fenix that referenced this issue Aug 25, 2022
@Mugurell
For mozilla-mobile#26224 - Use the mr2022.sectionsEnabled.tcp-cfr Nim…
155e6ad 
…bus feature to display the cfr
Mugurell added a commit to Mugurell/fenix that referenced this issue Aug 25, 2022
@Mugurell
For mozilla-mobile#26224 - TCP CFR telemetry
fb39c78
Mugurell added a commit to Mugurell/fenix that referenced this issue Aug 25, 2022
@Mugurell
For mozilla-mobile#26224 - metrics.yaml cleanup of unneeded newlines
bc4f3c0
Mugurell added a commit to Mugurell/fenix that referenced this issue Aug 25, 2022
@Mugurell
For mozilla-mobile#26224 - Disable the TCP CFR in failing UI tests
8b00f21
@mergify mergify bot closed this as completed in #26226 Aug 25, 2022
mergify bot pushed a commit that referenced this issue Aug 25, 2022
@Mugurell @mergify
For #26224 - New TCP CFR popup
4286606 
If Total Cookie Protection is enabled when first accessing a normal tab
(not a custom tab) a new Contextual Feature Recommendation popup will be shown
informing about the added protection and allowing the user to open a support
page with more data about the new option for privacy protection.
mergify bot pushed a commit that referenced this issue Aug 25, 2022
@Mugurell @mergify
For #26224 - Use the mr2022.sectionsEnabled.tcp-cfr Nimbus feature to…
f4b823b 
… display the cfr
mergify bot pushed a commit that referenced this issue Aug 25, 2022
@Mugurell @mergify
For #26224 - TCP CFR telemetry
67a55fe
mergify bot pushed a commit that referenced this issue Aug 25, 2022
@Mugurell @mergify
For #26224 - metrics.yaml cleanup of unneeded newlines
00d2a9d
mergify bot pushed a commit that referenced this issue Aug 25, 2022
@Mugurell @mergify
For #26224 - Disable the TCP CFR in failing UI tests
b16e691
@github-actions github-actions bot added this to the 106 milestone Aug 25, 2022
@github-actions github-actions bot reopened this Aug 25, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Aug 25, 2022
@LaurentiuApahideanSV
Copy link

I tested the issue on a Fenix debug build 1.0.2236 (2022-08-30) the TCP CFR is displayed once when visiting a website after a fresh install.
Screenshot_20220830-150359~3

Devices used:

  • OnePlus 6T (Android 9)
  • Google Pixel 6 (Android 13)

@LaurentiuApahideanSV LaurentiuApahideanSV added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Aug 30, 2022
@github-actions github-actions bot mentioned this issue Sep 19, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Mugurell Mugurell

Labels
eng:qa:verified QA Verified needs:triage Issue needs triage
Projects
None yet
Milestone
106
2 participants
@Mugurell @LaurentiuApahideanSV