Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]: "Jump back in" section displays tab groups but tabs tray no longer supports them #26227

Closed
csadilek opened this issue Jul 28, 2022 · 2 comments · Fixed by #26288, #26304, #26670, nathanmkaya/fenix#108 or fork-house/fenix#12
Closed

[Bug]: "Jump back in" section displays tab groups but tabs tray no longer supports them #26227

csadilek opened this issue Jul 28, 2022 · 2 comments · Fixed by #26288, #26304, #26670, nathanmkaya/fenix#108 or fork-house/fenix#12
Assignees
@MozillaNoah
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged
Milestone
105

Comments

@csadilek
Copy link
Contributor

csadilek commented Jul 28, 2022 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Trigger a search
  2. Open a few search results in tabs
  3. Go to home screen

Expected behaviour

Jump back in should display last tab, but no tab group

Actual behaviour

Jump back in shows tab group. Tapping on it opens the tabs tray which no longer supports groups and therefore doesn't highlight the group. It also may, depending on the previously selected tab, highlight an unrelated tab.

Device name

Pixel 6a

Android version

Android 12

Firefox release type

Firefox Nightly

Firefox version

105.0a1

Device logs

No response

Additional information

Tab groups were removed as part of #21898 in 7e59a64. However, the "Jump back in" section wasn't addressed as part of this work, leaving this in an inconsistent state.

┆Issue is synchronized with this Jira Task
@csadilek csadilek added 🐞 bug Crashes, Something isn't working, .. needs:triage Issue needs triage and removed needs:triage Issue needs triage labels Jul 28, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Jul 28, 2022
@MozillaNoah MozillaNoah self-assigned this Jul 28, 2022
@MozillaNoah MozillaNoah removed the needs:triage Issue needs triage label Jul 28, 2022
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Aug 2, 2022
This was referenced Aug 2, 2022
Merged
Merged
@github-actions github-actions bot added eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Aug 2, 2022
@mergify mergify bot closed this as completed in #26288 Aug 2, 2022
mergify bot pushed a commit that referenced this issue Aug 2, 2022
@MozillaNoah @mergify
For #26227 - Remove search term tab groups from Jump Back In
fa00527
mergify bot pushed a commit that referenced this issue Aug 2, 2022
@MozillaNoah @mergify
For #26227 - Remove search term tab groups from Recently Visited
c45e4b4
@github-actions github-actions bot added this to the 105 milestone Aug 2, 2022
@github-actions github-actions bot reopened this Aug 2, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Aug 2, 2022
@csadilek csadilek removed the eng:qa:needed QA Needed label Aug 3, 2022
@csadilek
Copy link
Contributor Author

csadilek commented Aug 3, 2022

Reverting patch because it by mistake also removed history groups in "Recently Visited".

csadilek added a commit that referenced this issue Aug 3, 2022
@csadilek
Revert "For #26227 - Remove search term tab groups from Recently Visi…
23b53de 
…ted"

This reverts commit c45e4b4.
csadilek added a commit that referenced this issue Aug 3, 2022
@csadilek
Revert "For #26227 - Remove search term tab groups from Jump Back In"
38a85a6 
This reverts commit fa00527.
mergify bot pushed a commit that referenced this issue Aug 3, 2022
@csadilek @mergify
Revert "For #26227 - Remove search term tab groups from Recently Visi…
b24650c 
…ted"

This reverts commit c45e4b4.
mergify bot pushed a commit that referenced this issue Aug 3, 2022
@csadilek @mergify
Revert "For #26227 - Remove search term tab groups from Jump Back In"
7ddc500 
This reverts commit fa00527.
@github-actions github-actions bot mentioned this issue Aug 3, 2022
Merged
4 tasks
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Aug 3, 2022
@mergify mergify bot closed this as completed in #26304 Aug 4, 2022
mergify bot pushed a commit that referenced this issue Aug 4, 2022
@MozillaNoah @mergify
For #26227 - Remove search term tab groups from Jump Back In
8656fd4
@github-actions github-actions bot reopened this Aug 4, 2022
@github-actions github-actions bot removed the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Aug 4, 2022
@github-actions github-actions bot added the eng:qa:needed QA Needed label Aug 4, 2022
@SoftVision-LorandJanos
Copy link

Verified as fixed on the latest Nightly 105.0a1 (2022-08-05) build.
After switching to the last tab opened from the search, that lastly viewed tab is displayed in the "Jump back in" section.
Device used: Oppo Find X5 (Android 12).
Closing the ticket as fixed.

@SoftVision-LorandJanos SoftVision-LorandJanos added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Aug 5, 2022
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Aug 26, 2022
@rocketsroger
For mozilla-mobile#26227: Clean up double exclamation operator in Bro…
f5aaed3 
…wserState
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Aug 26, 2022
@github-actions github-actions bot mentioned this issue Aug 26, 2022
Merged
4 tasks
mergify bot pushed a commit that referenced this issue Aug 26, 2022
@rocketsroger @mergify
For #26227: Clean up double exclamation operator in BrowserState
6933719
This was referenced Sep 2, 2022
Merged
Merged
@Alexandru2909 Alexandru2909 mentioned this issue Oct 14, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MozillaNoah MozillaNoah

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged
Projects
None yet
Milestone
105
3 participants
@csadilek @SoftVision-LorandJanos @MozillaNoah